From: Nathan Chancellor <nathan@kernel.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Nicolas Schier <nsc@kernel.org>,
Julian Braha <julianbraha@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Arnd Bergmann <arnd@arndb.de>, Kees Cook <kees@kernel.org>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH 1/4] scripts/Kconfig.toolchain: Remove CONFIG_CC_HAS_NO_PROFILE_FN_ATTR
Date: Wed, 11 Nov 2026 12:10:13 -0700 [thread overview]
Message-ID: <20261111191013.GA2689488@ax162> (raw)
In-Reply-To: <CAKwvOd=gkPRazfqjd2xpvW-Pr8gLXVvxBYuzuyAOWi2xwinRTw@mail.gmail.com>
On Wed, Nov 11, 2026 at 11:06:06AM -0800, Nick Desaulniers wrote:
> On Tue, Nov 10, 2026 at 9:42 PM Nathan Chancellor <nathan@kernel.org> wrote:
> > diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig
> > index 04f4ebdc3cf5..f62de2dea8a3 100644
> > --- a/kernel/gcov/Kconfig
> > +++ b/kernel/gcov/Kconfig
> > @@ -4,7 +4,6 @@ menu "GCOV-based kernel profiling"
> > config GCOV_KERNEL
> > bool "Enable gcov-based kernel profiling"
> > depends on DEBUG_FS
> > - depends on !ARCH_WANTS_NO_INSTR || CC_HAS_NO_PROFILE_FN_ATTR
>
> did you want to retain `depends on !ARCH_WANTS_NO_INSTR` (deleting the
> ` || CC_HAS_NO_PROFILE_FN_ATTR`)?
No. If CONFIG_CC_HAS_NO_PROFILE_FN_ATTR is always 'y', this whole
'depends on' line is 'y', so it can be removed entirely. The noinstr
part of that dependency was only added because the "no profile"
attribute is only relevant for noinstr.
--
Cheers,
Nathan
next prev parent reply other threads:[~2026-11-11 19:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 5:42 [PATCH 0/4] scripts/Kconfig.toolchain: Document minimum supported versions for dynamic checks Nathan Chancellor
2026-11-11 5:42 ` [PATCH 1/4] scripts/Kconfig.toolchain: Remove CONFIG_CC_HAS_NO_PROFILE_FN_ATTR Nathan Chancellor
2026-11-11 19:06 ` Nick Desaulniers
2026-11-11 19:10 ` Nathan Chancellor [this message]
2026-11-11 19:29 ` Nick Desaulniers
2026-11-11 5:42 ` [PATCH 2/4] scripts/Kconfig.toolchain: Do not dynamically probe '-fno-addrsig' Nathan Chancellor
2026-11-11 16:51 ` Nick Desaulniers
2026-11-11 18:36 ` Nathan Chancellor
2026-11-11 18:45 ` Nick Desaulniers
2026-11-11 5:42 ` [PATCH 3/4] scripts/Kconfig.toolchain: Clean up '-fno-allow-store-data-races' handling Nathan Chancellor
2026-11-11 5:42 ` [PATCH 4/4] scripts/Kconfig.toolchain: Document minimum supported versions for dynamic checks Nathan Chancellor
2026-11-11 19:01 ` Julian Braha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261111191013.GA2689488@ax162 \
--to=nathan@kernel.org \
--cc=arnd@arndb.de \
--cc=julianbraha@gmail.com \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=ndesaulniers@google.com \
--cc=nsc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®