mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hunter Laux <hunterlaux@gmail.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	Lars-Peter Clausen <lars@metafoo.de>,
	"H. Nikolaus Schaller" <hns@goldelico.com>
Subject: Re: [PATCH] MIPS: ingenic: Let Config.VI tell whether the icache is virtual
Date: Wed, 11 Nov 2026 12:56:09 -0700	[thread overview]
Message-ID: <20261111195609.2694096-1-hunterlaux@gmail.com> (raw)
In-Reply-To: <1a6aac61cb167ce0eea611afe73e8c87782edd43.camel@crapouillou.net>

Hi Paul,

On Wed, 11 Nov 2026 17:23:31 +0100, Paul Cercueil wrote:
> The docs I have do say that both caches are "virtually indexed, physically
> tagged". So the patch looks good.

Thanks for checking.

> If anything it's missing a Fixes: tag (with stable@vger.kernel.org in Cc).

I don't think it needs to go to stable. The vtag setting doesn't cause
wrong behaviour, only extra icache flushes. I can add a Fixes: tag
without Cc: stable if you'd like the origin recorded.

>> -#define cpu_has_vtag_icache	1
>
> Don't remove it, set it to 0.

The Config.VI probe already reports it correctly, so I left it to the
probe. Would you prefer the constant anyway?

Hunter

  reply	other threads:[~2026-11-11 19:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11  4:09 Hunter Laux via B4 Relay
2026-11-11 16:23 ` Paul Cercueil
2026-11-11 19:56   ` Hunter Laux [this message]
2026-11-11 17:00 ` H. Nikolaus Schaller
2026-11-11 19:56   ` Hunter Laux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261111195609.2694096-1-hunterlaux@gmail.com \
    --to=hunterlaux@gmail.com \
    --cc=hns@goldelico.com \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=paul@crapouillou.net \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®