mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Leo Yan <leo.yan@arm.com>
To: Rob Herring <robh@kernel.org>
Cc: Jie Gan <jie.gan@oss.qualcomm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Mike Leach <mike.leach@arm.com>,
	James Clark <james.clark@linaro.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Tingwei Zhang <tingwei.zhang@oss.qualcomm.com>,
	Yuanfang Zhang <yuanfang.zhang@oss.qualcomm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Abel Vesa <abelvesa@kernel.org>,
	Jingyi Wang <jingyi.wang@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Subject: Re: [PATCH v7 0/5] Fix traceNoC probe issue on multiple QCOM platforms
Date: Wed, 11 Nov 2026 20:43:22 +0000	[thread overview]
Message-ID: <20261111204322.GH9176@e132581.arm.com> (raw)
In-Reply-To: <20261110154643.GA4159803-robh@kernel.org>

On Tue, Nov 10, 2026 at 09:46:43AM -0600, Rob Herring wrote:
> On Tue, Nov 10, 2026 at 09:21:13AM +0800, Jie Gan wrote:
> > The CoreSight TNOC (Trace Network-On-Chip) binding so far only allowed the
> > two-string AMBA form "qcom,coresight-tnoc", "arm,primecell". That form
> > forces the device onto the AMBA bus, where the driver must read the
> > peripheral ID from the device registers during probe. On several QCOM
> > platforms this AMBA peripheral-ID probing fails, so the traceNoC device
> > never probes and its trace path is unavailable.
> 
> But it works fine on some platforms? We have a property to override the 
> peripheral-ID which would solve your issue. That would be much simpler 
> and avoid the ABI break on any of the working platforms.

Looking back at the earlier discussion [1], Jie in v2 already proposed
"arm,primecell-periphid". Questions about AMBA IDs and ATID handling got
mixed together. The series later moved towards platform-device probing,
then became current shape.

Hope we make the right decision on arm,primecell-periphid this time.

Anyway, I'd like to apologise to Jie for all the back and forth.

Thanks,
Leo

[1] https://lore.kernel.org/linux-arm-kernel/9432df20-08bf-4134-b4b9-e6b5d618af81@oss.qualcomm.com/

      parent reply	other threads:[~2026-11-11 20:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10  1:21 Jie Gan
2026-11-10  1:21 ` [PATCH v7 1/5] dt-bindings: arm: coresight-tnoc: Bind on platform bus instead of AMBA Jie Gan
2026-11-10  1:21 ` [PATCH v7 2/5] coresight: tnoc: Bind Aggregator TNOC on the platform bus Jie Gan
2026-11-10  1:21 ` [PATCH v7 3/5] arm64: dts: qcom: kaanapali: bind traceNoC " Jie Gan
2026-11-10  1:21 ` [PATCH v7 4/5] arm64: dts: qcom: sm8750: " Jie Gan
2026-11-10  1:21 ` [PATCH v7 5/5] arm64: dts: qcom: glymur: use Aggregator TNOC compatible Jie Gan
2026-11-10  9:44   ` Abel Vesa
2026-11-10 11:46 ` [PATCH v7 0/5] Fix traceNoC probe issue on multiple QCOM platforms Suzuki K Poulose
2026-11-10 15:46 ` Rob Herring
2026-11-11 12:58   ` Suzuki K Poulose
2026-11-11 15:07     ` Leo Yan
2026-11-11 20:43   ` Leo Yan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261111204322.GH9176@e132581.arm.com \
    --to=leo.yan@arm.com \
    --cc=abelvesa@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=coresight@lists.linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=james.clark@linaro.org \
    --cc=jie.gan@oss.qualcomm.com \
    --cc=jingyi.wang@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike.leach@arm.com \
    --cc=robh@kernel.org \
    --cc=suzuki.poulose@arm.com \
    --cc=tingwei.zhang@oss.qualcomm.com \
    --cc=yuanfang.zhang@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®