From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794489520; b=MdUHzVh1Ma0fTdCZkZ2bj6PP88JFpxhWr2cdTn9qMV0OFGoluNU6sxkl0XSjuBhm17NT q4pnIJBMIGiJAgBSIPgWdWUshQYNhz+N8sHsIDF8/4ndSKfotPIXCBI7O4rVexChbBDk1 J+kfhJvAE20PZADfLBJQUhWDjBuyeoc1/FQ3ZULRQO9VQyxWAyNZlTvTOijYQbPo44suK lYJYRaFXQIgR3OVGdOFg4Xe+rtzWL59K9KUIlGXve5G+uJD+dUoG/OTrvITyS4URqPN2+ 5v8++kWVBNNWnR/vr6qfa4TDrpGYze/ez1B27opIQyZGG8bIiqZ+lfpnqyTJfyRyZ4g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794489520; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:From: Subject:Date:Message-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:X-B4-Tracking:X-Change-ID:To:Cc:X-Mailer: X-Proofpoint-ORIG-GUID:X-Proofpoint-Spam-Details-Enc: X-Proofpoint-Spam-Info:X-Proofpoint-GUID:X-Authority-Analysis: X-Proofpoint-Virus-Version:X-Proofpoint-Spam-Details; bh=0reVTygQYZvGgH/DtOXkcK6EGhSpuDmU2CumM9pari8=; b=nnBb3yZVl/rIWdYv4ZP3rSbF2Iy/T2rSyym2/yW1y+HEs+J7ag0fHMJFRFbjAvvCnJbV wafH0AhhoQhK8BIZYLVpkRDdI0x/b59BZ30Wf8qlLcJs94iP+mYLrvu8TTuTNIL0R6/kj 7X7L4gj/tjIgKj+YiXxUHjDXJh/sb9aqAlaji4qvk27CbPbJctdRDBqpPUHMhTEr2iOtV zVQ4m4uOppf9Hhp0Of68+xbLzCkdiQLsv7nHigAi05UXPglcDq/sGvwdxxwkPrbUxbwig zhQ9qg26UvzR+XIygNR8Me8OiRlldyo9PKGmQ8uHul/tF/6WNl96dxrl1tEKD2eG2Ew== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=k6oaWtMF; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=Z4kQJXkk; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9A9F606A31C for ; Thu, 12 Nov 2026 13:18:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org C9A9F606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=k6oaWtMF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=Z4kQJXkk Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6AC91IgU4149283 for ; Thu, 12 Nov 2026 13:18:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=0reVTygQYZvGgH/DtOXkcK 6EGhSpuDmU2CumM9pari8=; b=k6oaWtMFbt7v7dpBKEPbHRgaguk/AXr79CCMIA pYowYhoiV7TQWcgNfvL9ZHp8lSojuQngdWRd5eZNNoCI52UWL5E/YHIsGxXslnm+ 0HCsAVXhIUyPrxvx4ey3y+S0nn5xd8F5qSMZszNFrCcYnhp/KbqsJ7dFKzkrc7Xz DrP7GA1rbekvL0WDG1t8e06WYdLsY8kTV48XF2x06rNB27drGlvJsz2zyX9JkvvJ xlhS4svxPKicXfAJ/3sW8UQKjl674+sPOW+urnTgt90R7ZPFPXkTfKm1TWCOiWG6 80hGQMiAeO9wbMuYosH28vf4tmaQafsQwgUjxinUNUr7ySRg== Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hvxc63hxb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Nov 2026 13:18:38 +0000 (GMT) Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-36efb506f29so1077145eec.1 for ; Thu, 12 Nov 2026 05:18:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1794489518; x=1795094318; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=0reVTygQYZvGgH/DtOXkcK6EGhSpuDmU2CumM9pari8=; b=Z4kQJXkkuBYcYZ7tSzY6NfHQhbPL/HYDW075fvGpkibLkkkdo3+HG+l2T33fhATo/a yK8E82veWF9s4CygE+pXYrRHDK4m2QV2Ul5yB9Wrs9OAKmnKcLdjuDdWtV8YK52u1LZT VLRrvDl6KuE0ID+oMlvl06ODtwu0Z1qKwKtz50I1KAIVAa9WXn2uuh5/ZH94uKGBeeQj umQkMFPkylZwyGbDI4/AOaSVOy8tudVrsRlzt2ibSduWLEWXp/NxZPm3294eRQSxzZF5 DBMh3bffPWHZiDrqVmgqjNpRe+OXTYJ2BCeJuznJIkM6Uxk0LqcRjS0ECXPVVsmftUb+ O5nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794489518; x=1795094318; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=0reVTygQYZvGgH/DtOXkcK6EGhSpuDmU2CumM9pari8=; b=nGo6UwOWNkhGjftyhbqXKZx1+DndgZASyiYAh36NzmcPrB+Hr27KiKreRxbMyqbUlw +5Eri/7xyFNp6Gdw7EgD4WupI0NkrVVxwKYkMynO8gYPw2ovy5R+sY/0OUg0wEVyVzB3 Rj94sPzUNWjFQD2UfRRfmFODfz+0coRmvH1kLAd/BQACPYDyNkwh5eYddlQ3WEBlJvIH CPAfxpYSPsK2IMoUzt+/jgm5r1RolS3ri5GNvyOKQRmlD9qB3Bb7FNSZOkUu3bCwPdO+ Vw/s+7prl59dOfEpgImbAmjerMts0+tEymvo5nmdgY6Km3zo+Og37tsEUPf9yDzEKXS0 izug== X-Forwarded-Encrypted: i=1; AL+hErEDaeWtAK/gtRJxERn8sx91/z6hkFaMAFdgCeFFxdjDBPlLYTvmmGzOuMd9pbZPFmrT5ArbL6H0LCc/7K4=@vger.kernel.org X-Gm-Message-State: APuU4Z++3R3E6s/lBRYAcG/GiLGNpKS/Zpx1pXu7TK6lyQEE89MnXnyB 0+2f+8QISAZr0+66yPG03q/DQGFSkl3O+/UFtYd9GUhCbMU+X51SK8iY2SVWzp3d3wlCgt/Jzo1 cOUb/nES3fV4EkvE3tfXap3wAqi1wFRA6rjg2bxNu99O1NIT0DD8iMxerKhXlpLMCzt8= X-Gm-Gg: AYBFou20NjpKvI75YuOQ9Mutu0uVA4C41PFXWNVgpuxchx55NHjWGw6pPwWtdZdIatw LKaF7KUIcWKavP9U/OFeZb7K+tgBRBAeA/kGtN2rvfBkQ6NahI0KQo6pdrhkliRm8rxJ/KJeBeU DWAn3jgxtk9plTkizv7VRHQ/80+yOplNIZgZOQXulfXT5VrOqNYGJbBTzvkUbm7S5wDeVS83q1v 5+RzSpPnwMzZMe+VUCDr7TZ7i/OcSod6wDuKXOPwuDeXRSrIZajgXLxpJTht/5dKVHqO0jA3dN+ l2wkeKtpKcVnr2A99/29kgmN2GVaUH+Tt6jIRxLwl6eqwCfm1fA8Q5dqSxpm2fqTsOEZukFSG6q FItvYQzyu8gVsWFDPzjIUjWK59FTfhdkQuzHSRNL7Tp8YPXv2surkL6DFcuBgPbHW//CqScnRtM uJkheH0nw= X-Received: by 2002:a05:701b:2906:b0:143:271a:3df2 with SMTP id a92af1059eb24-1b3c0361cc2mr4490664c88.44.1794489517441; Thu, 12 Nov 2026 05:18:37 -0800 (PST) X-Received: by 2002:a05:701b:2906:b0:143:271a:3df2 with SMTP id a92af1059eb24-1b3c0361cc2mr4490638c88.44.1794489516809; Thu, 12 Nov 2026 05:18:36 -0800 (PST) Received: from hu-kuldsing-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-375212e7d24sm43798356eec.22.2026.11.12.05.18.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2026 05:18:36 -0800 (PST) From: Kuldeep Singh Subject: [PATCH v2 0/2] Fix MMC/UFS sequence for ICE calls Date: Thu, 12 Nov 2026 18:48:16 +0530 Message-Id: <20261112-qcom_ice_pm_enable-v2-0-177e454d6f22@oss.qualcomm.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAJi89WoC/32NQQqDMBREryJ/3Ujyq1Zd9R5FJMZvTVGjiUqLe PdGu+9m4MGbmQ0cWU0O8mADS6t22gwe8BKAauXwJKZrz4AcE8ER2aRMX2pF5diXNMiqI3ZVcY2 iyjKKEHxxtNTo9zn6KH7slupFaj6WDqPVbjb2c76u4vD+HqyCcdbcZBrxNFFJLO7GuXBaZOfdP vQBxb7vX8i1aCDNAAAA X-Change-ID: 20261022-qcom_ice_pm_enable-3c5d21b99e42 To: Adrian Hunter , Ulf Hansson , Abel Vesa , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Eric Biggers Cc: Kuldeep Singh , linux-mmc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, stable@vger.kernel.org X-Mailer: b4 0.15.2 X-Proofpoint-ORIG-GUID: iMH1RfLSTckiHLorH29ZFuZ3CWYPDgPV X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTEyMDA1MiBTYWx0ZWRfXwwKR0t/X3sQO weaeSXSECeko41i1sl42urBVyQ0wZxvPzWFGHwaXNLoBOLhOhvRtKoP7C9RbcBDfTgGov1RZPrj Op7f27O6NrxmjWGzbi0mAgreye+NZLl9BXzmfGaUh1PBYO916bcrEbwbKhhX57s92/tLbBhjqV1 FnLqgjM5f5bbMpmDp6nZQeLVKE1c83RKwrLuP1LymKuzXshxRqZY+jLC0A+cZdteuiqqHhhdiKK ZrivvuWi+YboNPMv1iKfZP31iKMO6YiHwVqwivBaYfaZWkRSbQVifR0/FvQ1xLDmnIVibLa21hC xOsoXP5GbUWXaQtkJvV5LY+GS2qjP+mYb00I1Zn/JI+rPHMWo66hMPZLaIwaPNrnDgV/FPXPURB fBykacYPs79/DPWBia4nqmsuUf21oXjCY1wsldXzFLT3e6V8jwV5wQPqeiLuxcxsozBRn0sLxtf bOWHKqBOA67wxESBvPA== X-Proofpoint-Spam-Info: AW1haW4tMjYxMTEyMDA1MiBTYWx0ZWRfX7S6OzWYqB2pt 1IOA0ClNizrfg/oHwige20UAIdMQ22B1uIUVBp7LdDWjpzux4Y4FIKDI61cJ2NJpV+h2KKciXWX 1qPVP3cp2J4bG+ZtZ9iT1mDKx/6JMsY= X-Proofpoint-GUID: iMH1RfLSTckiHLorH29ZFuZ3CWYPDgPV X-Authority-Analysis: v=2.4 cv=O/ysLx9W c=1 sm=1 tr=0 ts=6af5bcae cx=c_pps a=Uww141gWH0fZj/3QKPojxA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=bC-a23v3AAAA:8 a=EUspDBNiAAAA:8 a=QyXUC8HyAAAA:8 a=VwQbUJbxAAAA:8 a=bLk-5xynAAAA:8 a=1XWaLZrsAAAA:8 a=k6_AVi2K15u0NLJkO0wA:9 a=QEXdDO2ut3YA:10 a=PxkB5W3o20Ba91AHUih5:22 a=FO4_E8m0qiDe52t0p3_H:22 a=zSyb8xVVt2t83sZkrLMb:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-12_01,2026-11-11_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 adultscore=0 malwarescore=0 impostorscore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2611040001 definitions=main-2611120052 This series fixes ICE initialization sequence where ICE is modeled as a standalone device and referenced by storage controllers through qcom,ice. Currently, ICE driver enables clocks during probe and keeps them prepared after probe completes. This keeps the ICE clock voted and hence, any key programming call from blk-crypto succeed even when storage driver don't have valid ice instance. This exposes serious bug in sequencing but it works as of now because ice clocks are voted. Storage controller should not rely on ice clock state and rather ensure valid ice handle is available before any crypto call is triggered. Fixing this issue require ice instance at early ufs/emmc probe so that correct sequence is established and ice is ready to accept key program calls from blk-crypto or any explicit storage operation. Validation: Tested on shikra-evk, kodiak rb3-gen2 and sm8750-mtp. Signed-off-by: Kuldeep Singh --- Changes in v2: - Drop patch 3/3 and post separately once 1/2 and 2/2 are merged. - Tag stable kernel for storage fixes. - Link to v1: https://patch.msgid.link/20261022-qcom_ice_pm_enable-v1-0-f7a84086c651@oss.qualcomm.com To: Adrian Hunter To: Ulf Hansson To: Abel Vesa To: Manivannan Sadhasivam To: "James E.J. Bottomley" To: "Martin K. Petersen" To: Eric Biggers Cc: linux-mmc@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-scsi@vger.kernel.org --- Kuldeep Singh (2): mmc: sdhci-msm: Enable ICE before enabling crypto support ufs: ufs-qcom: Enable ICE before enabling crypto support drivers/mmc/host/sdhci-msm.c | 21 ++++++--------------- drivers/ufs/host/ufs-qcom.c | 29 ++++++++++++++++++++--------- 2 files changed, 26 insertions(+), 24 deletions(-) --- base-commit: aaa2f954c21b205a0bcd0961e5b2be4e82e58455 change-id: 20261022-qcom_ice_pm_enable-3c5d21b99e42 Best regards, -- Kuldeep Singh