From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.53 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794497645; b=w2Dd4FVmu11FlnzfGw0BaFJkr32ggZmzVMjOOQi2Fxjo4VuqpgqyVcEaRQFgP9X2qj6F FRihK0MMjFHVR0D2yeWGsvpQonb90xJHJdgiGIsE6dXH6aUb42denQg9jOrwiMXH6JoUt KhWXT/qNoXdDu7EqTVirytOmWgXIGoWlbAGJzG4VOe7XElA5e/K4Iu0KbzIfgmuj2t2ny xS9mfaao95QLEbpxMFK5KHX6oebyEND+4WZ528Ud29QdLn2GfAwB5tLfhPE9DQap/4FAa QO6affYA4sr3+lq5Wpc1rvzzsHLoCTquoRVi0u4Tq4TazNNIsk1ekYhCF2lEyEYcDvA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794497645; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:Date:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding: Message-Id:References:In-Reply-To:To:Cc:X-Mailer: X-Developer-Signature:X-Developer-Key; bh=cb9BEjmbKiC1e6Ns5PB9qNgJqLkx/tEuk0+MP84fm7I=; b=Vcu1orU8V8O+D2KwgWPDi+03LbwCL0BI6wU5v/XHhvuCv/XMl6uLPOI85Ddx0LLEJCTo 0QHMAnFCsNMAKX1/6UTj09UwL4fB1+UYL/91mNPqauHzqpY+h3jvz0mpJeX7N5oBS/Wos m2mSVaBlND6HvR9wfV6tIov2b4R7DUVeJ0xH46pda3aThQPWbnoeZAYRo84ONeclAXQXw NZSIfTlNYbR4VxKTtzcQ4ImOYV8rH+8oMB+TYNkSPU9tfUDpBdEvbUeJz2Btxg+kF76/G 0EHj2ZDkq55arSL5D+zxCFySiB5eBoGJ4Tm19OiOPMEFg4DeNBv0jQruRrTkx98HhZg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b="Alal/djO"; arc=none smtp.remote-ip=209.85.128.53 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BB50606A8B5 for ; Thu, 12 Nov 2026 15:34:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 0BB50606A8B5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=Alal/djO Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4a35a60499eso34898665e9.0 for ; Thu, 12 Nov 2026 07:34:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794497643; x=1795102443; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cb9BEjmbKiC1e6Ns5PB9qNgJqLkx/tEuk0+MP84fm7I=; b=Alal/djO9WabNo0xNCNMd/5TqLehZJIEUmXgnMBpeUIigivbAcrzLOWlqX6ieAvcbl gsODy5uhWGx70IaMWM9o3NcF/zyiQBJGYuIj8aPMlAN6LC57a/ORWpvIJjCGHgGggPgn 4t8S6PTHSAirtwiQtvUTM61NnU3AaQXKpPMKHJzaLqvIn950y3GhcptqQgio4z/LU4gV hjT9FUJt2lqAhOcKKT43+o2WZyOAya4m4OzD6MH40yq2QGglv90WptSVYmTT5q4jU/3p tXqJZMeD6fA5vqP+ZfUjd9jMP9iG3rsZQ4EsGyfPCaW7EmgyXSZazY5nfGv0dpAWkAB7 n/fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794497643; x=1795102443; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=cb9BEjmbKiC1e6Ns5PB9qNgJqLkx/tEuk0+MP84fm7I=; b=MZ0XmiYyalDrnC1xh7Ca6PYuNSgs+CGzct+v6Hzk3Zd6/r9yEpnpuDYAy0DEIXyol+ 0phOXEB6FYzmpQZ3tBsC2pmHOv8gSnFIg5zho6XXIq1I4Yk3oCFpOSJKe/X2TuRnnfsc TKl0IWm9C2s1+fjBeeumzKiTAZBLw4IoSluDG4bL7YzmRKcuBYkZm7NnFqqbt86vmYum Zdko8nBEbQAfiRvACxFCs/7cUjqjpF9Yy+C0NZDQMYQ0CsIxnpM1cMJ9QpUZ88xlGzj0 v2bd+BOenHJZ08hOdXMBIVu7UsZngJDiQ16jwlQwsfkooCHs/ClhlbYUCw/EWZJ0N/PZ EYQg== X-Forwarded-Encrypted: i=1; AL+hErHfSgDnUyYJXe+VSCc4mExxPzMUVsASQGU3XJvmPHyV+F59HobnUBgqp7hnjCeWdM3+ASjwKGTFmGAUG+w=@vger.kernel.org X-Gm-Message-State: APuU4Z/p7Ul+g7OuRsGM13XDAGUxdWyTdSAkRjObf8Ik4MkMqOrT1dHV +uaYBBI6vMJJxrltqJugAW/vBz2rqphZIGgfZyTOj9vu7fy8k4Iy8OZa X-Gm-Gg: AYBFou2Q7sLfX5Ku4WlnHyOfY47fDvoh+ZLKHOE0CEvhLmOsIGL1kqscQ4yfbJHKkfU vSYJivxGw7KuaxeewKOB3J6ri3boKx19KeM3kctToLEiOYFRZjk+SMw/lKVvwMjQ7aVcLXXvSh/ XoSK45gJqjwGTqdwaSmCYqrNj71388WhXYreK3H1JuNNWnNo+N54YCz4HxRcs+PT6+4mmjJbua7 0bCK1F/r0UZDuxjfaXF7leu9kBEbbtjAIabn424wDj4fj9HC2I5yB4AN/p0igjJrvAExJlAY5Cm NxGnbjwybzHE8oPfKXcQsAh4k/UmhINz6DRN+EcG717Ntc2CDBy1CX9RyuRGM8f0e9+EUuao85h innYpIJh4bwiexvM7BZ+bG9880NoOk9hHjSpeSjq0aUxHSEqa6OwvBkLOtWvXc09V0MeS+ix56F UOJ5h+/alW2RSCEkCUOan6gOKmLPX8KVazVevcA53QDxAnwQS3OtB4PzLU01g5aHSFkTNoW5eB6 uZNMLOZokERmLhdc6AVfTo2BIaezICy27qNoNypgdTwu4FjKJWjAX/HtFM9gZ2VperlczQ1sxiS 6m9gzOOKw0BjhjDRP6eVtvWoeKyJE3fJDRyRPcO67RCmS2ClCXnW/VrFnW8YRnro4w5iDRPCmqL ltFR4Qoc= X-Received: by 2002:a05:600c:1c0d:b0:4a2:1e1:d55 with SMTP id 5b1f17b1804b1-4ba093a3cf9mr133072185e9.28.1794497643353; Thu, 12 Nov 2026 07:34:03 -0800 (PST) Received: from alchark-surface.localdomain (bba-86-98-194-229.alshamil.net.ae. [86.98.194.229]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4bb4e2593e4sm87105855e9.5.2026.11.12.07.33.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2026 07:34:02 -0800 (PST) From: Alexey Charkov Date: Thu, 12 Nov 2026 19:33:13 +0400 Subject: [PATCH v2 5/6] serial: vt8500: Use devm_clk_get_enabled() X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261112-vt8500-serial-cleanup-v2-5-36b258e0c0dd@gmail.com> References: <20261112-vt8500-serial-cleanup-v2-0-36b258e0c0dd@gmail.com> In-Reply-To: <20261112-vt8500-serial-cleanup-v2-0-36b258e0c0dd@gmail.com> To: Alexey Charkov , Krzysztof Kozlowski , Greg Kroah-Hartman , Jiri Slaby , Tony Prisk , Alan Cox Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Greg Kroah-Hartman , Wentao Liang X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1756; i=alchark@gmail.com; h=from:subject:message-id; bh=aNl/b6SlgUpHOAaonf2+NOgTxzDT2w4YvE4m0DcTp5A=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWR9veNVq5GRPm8+5/97Vp57flnN8ok9osmhc4pnQyWb+ aMLclUqHRNZGMS4GCzFFFnmfltiO9WIb9YuD4+vMHNYmUCGSIs0MAABCwNfbmJeqZGOkZ6ptqGe oZGOsY4RAxenAEx1kQTD/xjOrdoB5jYTvIocngROMXJnStaND3j2f4be9NNnDzQUFTH84Xlde5U 7PCF1/zJFi0kODQWJz9wmaGx9eWiFjNpzo++pTAA= X-Developer-Key: i=alchark@gmail.com; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 Let devres own the UART clock, so that no probe error path, present or future, has to remember to disable and put it. Pass the clock lookup error up through dev_err_probe() instead of replacing it with -EINVAL, so that a clock provider that is not ready yet defers the probe rather than failing it for good. Signed-off-by: Alexey Charkov --- drivers/tty/serial/vt8500_serial.c | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/tty/serial/vt8500_serial.c b/drivers/tty/serial/vt8500_serial.c index 0c8ddd55f94d..cd5188282f64 100644 --- a/drivers/tty/serial/vt8500_serial.c +++ b/drivers/tty/serial/vt8500_serial.c @@ -586,7 +586,6 @@ static int vt8500_serial_probe(struct platform_device *pdev) struct resource *mmres; struct device_node *np = pdev->dev.of_node; const unsigned int *flags; - int ret; int port; int irq; @@ -606,18 +605,10 @@ static int vt8500_serial_probe(struct platform_device *pdev) if (IS_ERR(vt8500_port->uart.membase)) return PTR_ERR(vt8500_port->uart.membase); - vt8500_port->clk = of_clk_get(pdev->dev.of_node, 0); - if (IS_ERR(vt8500_port->clk)) { - dev_err(&pdev->dev, "failed to get clock\n"); - return -EINVAL; - } - - ret = clk_prepare_enable(vt8500_port->clk); - if (ret) { - dev_err(&pdev->dev, "failed to enable clock\n"); - clk_put(vt8500_port->clk); - return ret; - } + vt8500_port->clk = devm_clk_get_enabled(&pdev->dev, NULL); + if (IS_ERR(vt8500_port->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(vt8500_port->clk), + "failed to get and enable clock\n"); vt8500_port->vt8500_uart_flags = *flags; vt8500_port->clk_predivisor = DIV_ROUND_CLOSEST( -- 2.56.0