From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.215.200 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794444085; b=NkuKEbaRI7waKIiGBkt8Ys3ibkopBvVHhb4immXUm5+u+LhmjshI0hQ1UQLHSBDhRZcY qAPz+33wAsG/+KxUWssAod/2WZ0DhgmPbWRBrwXXZhU9LLQKv0MyIQ3TJfGfusQTi5MBp +59xXQNdV77uHSmKoxHwY8FUdoQLN4r7vqYR1YQdIPbdayT+m7360KUNeTu40Kvi/b3eh WYnjBQ3Jh+N0ZOf/3H/N/Mz6XgZ0gpVZnOIFJ0g6mvoE2csR0aaPMyGGrNOv3g9KJEZCi aY+p96BOQ46/IJHcduCOhv4DPXMRuYx5NCeTwp3MhKrrEelqZh1tJdv94Z77cd38lrg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794444085; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=izpK0qiPp9EDp8rLCg6Dje1fDMudES+DfbenuKy5KPY=; b=ZHj8CHI1BV9/J1e4Lur5+sNbBZFwb+wbCEKG5+OaSYcQuTsD7FTq9qVaJiyhtXQ/z/Pe Z5cS8hGUE5Ks7S07sb8wb8UOuNwwv6elB+GYVXUWN7wCfJ37e0kh5EFTpD00QFye9O8qO 3yFbaQz3Qb9VFUKLXvioqoF+nOTx1aQMX0C11rIxkzv3XYCgCGRMottmdMLkLvu9ZVEEX bdROOfB1hvJ3flYbD3trjRY1VmOQ3UiOr627H0OTJffOhxgs3ZSw67j+WXz+JCbykvJil B1Q9+5wNJcZSuZfTM1qHyxK+NYSOmGNzJc7MlOl112hlxQqA6NV/8a2PzZz6XJOU9Cw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--stanleyjhu.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b="J/3F0HPb"; arc=none smtp.remote-ip=209.85.215.200 Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 295DC60A260D for ; Thu, 12 Nov 2026 00:41:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 295DC60A260D Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--stanleyjhu.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=J/3F0HPb Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cdb869327e7so3224163a12.0 for ; Wed, 11 Nov 2026 16:41:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1794444084; x=1795048884; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=izpK0qiPp9EDp8rLCg6Dje1fDMudES+DfbenuKy5KPY=; b=J/3F0HPbxmMssjL2YGdtICYkjUPYF5mEBw6p0geVV8v5RDPQIqAnRPtGFwDJrcPC7J PihVv9jcsjamuf0O85qOMP3b2DK+8aAQqPSK1PLFc5//IglVOHEbPgRH9lUbpzbfUdhp G6RjIt+JO1rIGqPyiEmoKl9kawf0HSmCWtdSy4QACqU+OdFxX55U3HZ0QmQYNtPGcf80 eKe/8/Ev8QRyqm1LovRcbdXEp4aheY4oS7PXgpV22s8mbVGGW4mjSsSIC0dbfJIwNqsq 1TfQbt/39mph01aChZOVDep7glrCLHAY+rj4JMLLmrlb+VZ4MZ4+D1zFj8KQIfdi12DS 8QBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794444084; x=1795048884; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=izpK0qiPp9EDp8rLCg6Dje1fDMudES+DfbenuKy5KPY=; b=w3NTpAOMIzNylVrzbUfyJu37cUDMv95Cu9+qo9wbhh9jaM6WRlvN2IfKzHKuHnhQ4l FV5cyQabjLwrSLnFklL6Z5Nim0JAozhh929ZHkX9VgdkQy8wC1plRwNb64DIlRnWED4E Wxn+JZncO9ObPAZ0X48eSkyP2OoILDJfv8l/a53MxOWOFibWApg7Y40g8N4ZIhp38a30 4uLOct3VDdacD0q8d4vFq+FEble+No1zLCGXELYc4I8yVP4pWx6jjKtwnXL2xC0bHvpi Lk3YOMJW/wwlluPiD2BmSDlIwVJtye43yqKjt0JL1gVzRhB1XMAN7+fpMqi8UYZ1VfWa KORQ== X-Forwarded-Encrypted: i=1; AL+hErHz9bxyEfMKJWtzMQYkLWu7WyUeTFnaa4PK6SHju4D0QKdiNcTf5WL1UQrItHP7jjn4XvAPM9allm3WQdo=@vger.kernel.org X-Gm-Message-State: APuU4Z+XDHwzbXXoD9YizRc3aeXTqfMjTMr2lrSwKsnbvhPLM0TYLHZa Px8p+zdmNZLa5mgCAeVh56bCPUc72bZfzsFhJmtZyeXHtEi+2TbAbX56FsB7rd+cUOIOlvUkGZL Zwis8rIImnMAmSkpt8tVHNA== X-Received: from pgq9.prod.google.com ([2002:a63:1049:0:b0:cd8:b3c4:e64d]) (user=stanleyjhu job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:748b:b0:3ef:ed4d:520b with SMTP id adf61e73a8af0-3f2fd195b16mr3698235637.21.1794444084204; Wed, 11 Nov 2026 16:41:24 -0800 (PST) Date: Thu, 12 Nov 2026 08:41:12 +0800 In-Reply-To: <20261112004112.3059801-1-stanleyjhu@google.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261112004112.3059801-1-stanleyjhu@google.com> X-Mailer: git-send-email 2.56.0.567.gdb80ae8cd5-goog Message-ID: <20261112004112.3059801-4-stanleyjhu@google.com> Subject: [PATCH v6 3/3] scsi: ufs: rpmb: Drop the unregistered ufs_rpmb bus From: Stanley Jhu To: "Martin K . Petersen" , Jens Wiklander , linux-scsi@vger.kernel.org Cc: Greg Kroah-Hartman , Arnd Bergmann , Bart Van Assche , Avri Altman , Alim Akhtar , Bean Huo , Bean Huo , Alexey Charkov , Can Guo , Ulf Hansson , Linus Walleij , Shyam Saini , "=?UTF-8?q?Alex=20Benn=C3=A9e?=" , "James E . J . Bottomley" , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ufs_rpmb_probe() assigns ufs_rpmb_bus_type to dev.bus without ever calling bus_register(). Since commit 36f35b8df697 ("driver core: reject devices with unregistered buses"), device_register() rejects unregistered buses with -EINVAL and UFS RPMB region registration fails. ufs_rpmb_bus_type defines no callbacks and has no drivers, and consumers look up regions through /sys/class/rpmb. Drop ufs_rpmb_bus_type and leave dev.bus unset. Fixes: b06b8c421485 ("scsi: ufs: core: Add OP-TEE based RPMB driver for UFS devices") Cc: stable@vger.kernel.org Reviewed-by: Bean Huo Signed-off-by: Stanley Jhu --- drivers/ufs/core/ufs-rpmb.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/ufs/core/ufs-rpmb.c b/drivers/ufs/core/ufs-rpmb.c index 11d2d8e789d0..6803f3e62d78 100644 --- a/drivers/ufs/core/ufs-rpmb.c +++ b/drivers/ufs/core/ufs-rpmb.c @@ -28,10 +28,6 @@ #define UFS_RPMB_SEC_PROTOCOL 0xEC /* JEDEC UFS application */ #define UFS_RPMB_SEC_PROTOCOL_ID 0x01 /* JEDEC UFS RPMB protocol ID, CDB byte3 */ -static const struct bus_type ufs_rpmb_bus_type = { - .name = "ufs_rpmb", -}; - /* UFS RPMB device structure */ struct ufs_rpmb_dev { u8 region_id; @@ -206,7 +202,6 @@ int ufs_rpmb_probe(struct ufs_hba *hba) ufs_rpmb->sdev = sdev; ufs_rpmb->region_id = region; ufs_rpmb->dev.parent = &sdev->sdev_gendev; - ufs_rpmb->dev.bus = &ufs_rpmb_bus_type; ufs_rpmb->dev.release = ufs_rpmb_device_release; dev_set_name(&ufs_rpmb->dev, "ufs_rpmb%d", region); -- 2.56.0.567.gdb80ae8cd5-goog