mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daejun Park <daejun7.park@samsung.com>
To: Brian Foster <bfoster@redhat.com>
Cc: Carlos Maiolino <cem@kernel.org>,
	"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
	Christoph Hellwig <hch@lst.de>,
	Dave Chinner <david@fromorbit.com>,
	"Darrick J. Wong" <djwong@kernel.org>,
	Amir Goldstein <amir73il@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Daejun Park <daejun7.park@samsung.com>
Subject: RE:(2) [PATCH v2 2/2] xfs: skip the fsync flush when a later flush has completed
Date: Thu, 12 Nov 2026 11:39:40 +0900	[thread overview]
Message-ID: <20261112023940epcms2p691f2ef101b0e3988d15c4250877dfea3@epcms2p6> (raw)
In-Reply-To: <avR6G6TQehW08BD0@bfoster>

On Wed, Nov 11, 2026 at 09:22:19AM -0500, Brian Foster wrote:
> Hmm.. that's kind of interesting. So IIUC unless dm can pass through a
> preflush+data bio, it will split out the flushes and ignore any error
> status in favor of the packaged data I/O..?

Yes. dm sends the empty flush first and then reissues the data without
REQ_PREFLUSH. __dm_io_complete() drops the flush error when it reissues
the data.

I sent a fix to dm-devel. With the fix, a failed preflush fails the
iclog write, and XFS shuts down:

https://lore.kernel.org/r/20261112-dm-flush-data-error-v1-1-c83d3f8f3ac4@samsung.com

[...]
> But if you have to post this again I think it would be useful to
> describe this caveat in the commit log description as well. If there
> happens to be some currently unknown flush failiure scenario that
> materializes in the future and we don't currently hit due to spamming
> enough flushes, that would be a useful clue about a subtle behavior
> change.

Thanks, agreed. If I post a v3, the dm paragraph below the --- will move
into the commit log of patch 2.

Best regards,
Daejun

  parent reply	other threads:[~2026-11-12  2:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11  3:17 [PATCH v2 0/2] xfs: skip redundant fsync cache flushes Daejun Park via B4 Relay
2026-11-11  3:17 ` [PATCH v2 1/2] xfs: number the cache flushes submitted to each buftarg Daejun Park via B4 Relay
2026-11-11 14:22   ` Brian Foster
2026-11-20 18:14   ` Christoph Hellwig
2026-11-11  3:17 ` [PATCH v2 2/2] xfs: skip the fsync flush when a later flush has completed Daejun Park via B4 Relay
2026-11-11 14:22   ` Brian Foster
     [not found]   ` <CGME20261111142234epcas2p48d80bde0c65d09a2fd8bdfdc9bdd2b1f@epcms2p6>
2026-11-12  2:39     ` Daejun Park [this message]
2026-11-20 18:17   ` Christoph Hellwig
2026-11-11  6:47 ` [PATCH v2 0/2] xfs: skip redundant fsync cache flushes Dave Chinner
     [not found] ` <CGME20261111064724epcas2p11498de70e50f2fbf4e21d5e7a723e01d@epcms2p5>
2026-11-17  2:33   ` Daejun Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261112023940epcms2p691f2ef101b0e3988d15c4250877dfea3@epcms2p6 \
    --to=daejun7.park@samsung.com \
    --cc=amir73il@gmail.com \
    --cc=bfoster@redhat.com \
    --cc=cem@kernel.org \
    --cc=david@fromorbit.com \
    --cc=djwong@kernel.org \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®