mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: fixca <jaehoon1744@dankook.ac.kr>
To: shumingf@realtek.com
Cc: broonie@kernel.org, Vijendar.Mukunda@amd.com,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	JaeHoon Kim <jaehoon1744@dankook.ac.kr>
Subject: [PATCH RFC 0/1] ASoC: rt1320: LG gram 16Z95U speaker works with the BIOS init values
Date: Thu, 12 Nov 2026 13:01:42 +0900	[thread overview]
Message-ID: <20261112040143.6945-1-jaehoon1744@gmail.com> (raw)
In-Reply-To: <20261111013953.4011-1-jaehoon1744@gmail.com>

From: JaeHoon Kim <jaehoon1744@dankook.ac.kr>

Hi Shuming,

Follow-up on the silent RT1320 speaker on the LG gram 16Z95U (SSID
1854:056c), from the "SoundWire audio for LG gram 16Z95U" thread. Thanks
to Mark for applying the two ACP patches, and to Vijendar for confirming
the AUDIO1_TX pin.

The speakers now work, with one change in the RT1320 driver: using the
values from the BIOS SDCA function initialization table of the SmartAmp
function instead of rt1320_vc_blind_write[].

Results on 7.2.15 (version_id=2, dev_id=0x6981):

  rt1320_vc_blind_write[]     stream runs without errors, silent at 0 dB
  BIOS init values (patch)    speakers work, correct L/R, no distortion

The BIOS table has the same structure as rt1320_vc_blind_write[]. The
differences are listed in the patch description. Two of them stand out:

 - The L/R mapping in 0x1000db15-0x1000db23 is swapped compared to the
   driver, and the swapped (BIOS) mapping gives the correct channels on
   this machine.
 - Several registers are written only by the BIOS table (0xc5c2-0xc5d0,
   0xc050-0xc063, 0xc582, 0xc60b, 0xc682, 0xdc20, 0xcd00, 0xcf02,
   0xce1b-0xce44), and 0xc900/0xc901 and 0xd471/0xd479 have different
   values.

The attached patch is a test patch against v7.2.15, not meant for merging:
it changes about 50 registers at once and I do not know which ones are
required. DSP firmware and RAE files are still not loaded on this
machine, so the speaker protection that Windows sets up (R0 calibration,
EnableAdvanceMode) is not active.

Questions:

 1. Which of these registers does this design actually need? I can
    test a smaller patch, or narrow it down by removing groups of
    registers if that helps.
 2. Would you prefer the driver to apply the BIOS
    "mipi-sdca-function-initialization-table" in general, or a
    per-machine table like in this patch?
 3. Could Realtek provide DSP firmware / RAE files for this machine
    for linux-firmware?

Thanks,
JaeHoon Kim

  parent reply	other threads:[~2026-11-12  4:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11  1:39 [PATCH RFC v2 0/2] ASoC: amd: SoundWire audio for LG gram 16Z95U (rt713 + rt1320), speaker still silent fixca
2026-11-11  1:39 ` [PATCH RFC v2 1/2] ASoC: amd: acp: Add ACP70 ACPI flag override for LG gram 16Z95U fixca
2026-11-11  1:57   ` Mukunda,Vijendar
2026-11-11  1:39 ` [PATCH RFC v2 2/2] ASoC: amd: acp70: Add rt713 + rt1320 SoundWire machine " fixca
2026-11-11  2:05   ` Mukunda,Vijendar
2026-11-11  1:55 ` [PATCH RFC v2 0/2] ASoC: amd: SoundWire audio for LG gram 16Z95U (rt713 + rt1320), speaker still silent Mukunda,Vijendar
2026-11-11  2:20 ` Mark Brown
2026-11-12  4:01 ` fixca [this message]
2026-11-12  4:01   ` [PATCH RFC 1/1] ASoC: rt1320: Use the BIOS init values on LG gram 16Z95U fixca
2026-11-12  4:46   ` [PATCH RFC 0/1] ASoC: rt1320: LG gram 16Z95U speaker works with the BIOS init values fixca

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261112040143.6945-1-jaehoon1744@gmail.com \
    --to=jaehoon1744@dankook.ac.kr \
    --cc=Vijendar.Mukunda@amd.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=shumingf@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®