From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.177 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794456979; b=imFQe5pyZ/49HuRdeDXpuJxeYgU91RspBcYHPef/11nXPOLwxz3ahbs/Yvhl7FG11dZm bhvdP9ybzxaW9XrIVwGX+6uI1FgFQpZ2VHp9CXawKesLZvU9jwOn4KuaU5sezMzm1dLNT gmQL5rrKjJL8NJyHMBY9Qe10lv5c41uS4Llxt2ipipJqvpybKRof7LxSVeOCJUXqlGSDg EaB9twlvXXWkXhMEHABZvY5hWYp1cHc3aZ4SG0k46RC1fuHAP2JIUkcxZUBHUJZVvodd7 EGlzzBed6gE6R79Hz6rQwnPPig7PL4gQTnE672kzCoTGPtq7Yf2XssEo33mH4B0JHSg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794456979; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=cx07ziGcA50aUj85Mm/ZBnVBryK8gFtKvDY2YMtoJYc=; b=mRlCQUkJzA+AeYuNP9FxUAOAbgFkS1JH1gSxO6S1mwWCSovJgm1HuPuiQfEvf0sb0FmJ J3DVtNy/pAKNtJCHcX/0nnKpdWcXlTNdw80FE/RakTRby6lg+6cRymNrYjUvMZmaPYcXN pB/adiNI74xEfyxsZ7VERcLXnBUsPJTvsKsb75P5673Vo7FnV+qm/GAZFW7GM5rz4jTMH fV/PotPgvkChAwTQR3xiNAgG/bbdXqsFA1k7JnHLLTzfPiDoGB4EOxzkOUPH080lFrHyh pZtAv4SNE22QvjPEedvfBra72p0dhrMboakzzAkxQ4AMsmNq4uwWyBhqtHbVw2ioGgA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=RmJGZdJg; arc=none smtp.remote-ip=74.125.82.177 Received: from mail-dy1-f177.google.com (mail-dy1-f177.google.com [74.125.82.177]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72BDD606A33E for ; Thu, 12 Nov 2026 04:16:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 72BDD606A33E Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=RmJGZdJg Received: by mail-dy1-f177.google.com with SMTP id 5a478bee46e88-37628596783so3608253eec.1 for ; Wed, 11 Nov 2026 20:16:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794456978; x=1795061778; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cx07ziGcA50aUj85Mm/ZBnVBryK8gFtKvDY2YMtoJYc=; b=RmJGZdJg942OY9rPhScQBPvnVkEnUGRlsngqVgdkiF3pKXoGg2y1cYTwH4oLb8CQg2 5N585j9GpOm7a6X5s5k+2F0qU3kMRG0Id6ymOAWHgSX9fYdQTwd7cksIITmK2Y5HXVCH 63sRX9aIvluSZaVFvwDpVH1jBUVkYrv3HZT7LIl4X8K+9c0goL5LoyrxNSlZxGIpHstH u5Mx4zbi0PpsGq/6RETVOripdngpUkEHMA0Wu60KDVQHebkEwI6X6GM52/sMvAY+MHqm KzyvfCC3pvLX71DTrsb4OBfQAZe1Nv3lTGMyOUnCGnXQ1MSUZY/8tyjocmoE0RMOf2x7 gI8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794456978; x=1795061778; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=cx07ziGcA50aUj85Mm/ZBnVBryK8gFtKvDY2YMtoJYc=; b=Gqc5OReVpq/PNx2HRIcx45vYqU/dV67fzLCUTpwx43va+6ZIIc77kmwgexLBjly9qY SADqknjdEmxUFtXZmLh0nQODFJQ9umO6B5BjbUo2ff+AqN98f4Mf/E5LmB6gpZHBdcdo K6j0aBd3g+UKTmqOJ5QLrryGnAtS6nuzM47hGrPCGPUP6Ipm/waJ66QEnrJBYlNpUjJS PSPqaR1YQyEbLZ3eqdjJAj4PFv9i2oQ4gq1hAZQQgqyamwMRe16UezSk98sdamuVqgse yGXOHOBJz341qY2cCaEHqyaTuOa030NZiGqXixidFcExNfxkOZPIaYqgW09Nw2PJ0yx5 NRaA== X-Forwarded-Encrypted: i=1; AL+hErEtQvtUtBsOq/sM9y49iaJf8CAujItHlVcBc1+MW+YjlOH96tYeMgvJFqhcfZmWUtToetl1xsYQsNS1hd8=@vger.kernel.org X-Gm-Message-State: APuU4Z/Rex60JpPRI/2w6Z67IP9XHUCIf6XEpBwJe/DGpYqyVjkOLFjK stUVlWvmH8zQTFT+jTt2xDmsXxMSqP1GIhWbG390ik5uh208aDWnTlk4 X-Gm-Gg: AYBFou3UUMGl3TZ6anCbx5l8hrTeiQPlgVc+akLEB7bl49AjiQuhufPcGGlThmKElHz 59Oku4ZyBHV0rwHxmuS926yp11LSZsqRt/qKLG87CkQIC7+HrNbmBsHWC2iAzClXo9xlIG5HZ7M V45iDEDMazF0f9itG++hAUj7hK2ifTpw5mR2jOyPprEM+OYCBlGbPXNCpUjKQT0j2cBdLcKGDIB WODSnRY5UUWhdEz9pSCExPQTDiAYUHi2EnNjCJeJgR7+DnPDlhImmPLyE0H5VUBl9HYXk9q5p68 Yossky7C6q/uJJ/T7riFVp3nacR33HL13e4J/jIVAtFsotNyUiomWcX0aFwa9Om9R4XAn+eTUL4 Dt+JmBEBuj2+0ZiPZGVC0syoR1HS3JGnB071eE/F3uIG8vGMGp/9cLrQ0089SVcNIMXJ+lzVfjr D6lfR1doLPwqdO8/kH5T1hJuFbkuAaHGnoPgOCujnZ/4RwU2IDdAo3UUgCXP12oTJEPtF2IMadg Fcxy33ik3RLk+JfeVOZ9g9RhqBNcHUt9Tg6YnFtb9QpPGwJZj4Jw3VakZwzwnVZPBHjiyd168Th wnGRHrBw X-Received: by 2002:a05:701b:45d8:20b0:1ab:9266:f50 with SMTP id a92af1059eb24-1b3c03766d2mr4147018c88.46.1794456978493; Wed, 11 Nov 2026 20:16:18 -0800 (PST) Received: from eldorado ([2600:8802:b00:1f88::287]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1b3b5890c0esm21300801c88.1.2026.11.11.20.16.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2026 20:16:15 -0800 (PST) From: Florian Fainelli To: linux-mips@vger.kernel.org Cc: Florian Fainelli , stable@vger.kernel.org, Paul Cercueil , Thomas Bogendoerfer , Paul Burton , Stephen Boyd , Brian Masney , Jerome Brunet , =?UTF-8?q?=E5=91=A8=E7=90=B0=E6=9D=B0=20=28Zhou=20Yanjie=29?= , Jiaxun Yang , linux-kernel@vger.kernel.org (open list), linux-clk@vger.kernel.org (open list:COMMON CLK FRAMEWORK), hns@goldelico.com, paul@boddie.org.uk Subject: [PATCH v3 1/3] clk: ingenic: Poll JZ4780 CPU1 power status atomically Date: Wed, 11 Nov 2026 20:14:20 -0800 Message-ID: <20261112041422.2997275-2-f.fainelli@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261112041422.2997275-1-f.fainelli@gmail.com> References: <20261112041422.2997275-1-f.fainelli@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The CPU1 clock enable callback runs under the clock framework's spinlock with interrupts disabled. Its readl_poll_timeout() can sleep between reads, which is invalid in this context when SMP powers up CPU1. Use readl_poll_timeout_atomic() with the existing interval and timeout. This is a prerequisite for the JZ4780 SMP bring-up path. The original CPU1 clock implementation by Zhou Yanjie is already upstream. Cross-built for CI20; the subsequent SMP-enabled image brought up both CPU cores. Development and validation used Codex assistance. CC: stable@vger.kernel.org Fixes: 6673db4f3f26 ("clk: JZ4780: Add function for enable the second core.") Link: https://lkml.kernel.org/r/1582215889-113034-3-git-send-email-zhouyanjie@wanyeetech.com Reviewed-by: Paul Cercueil Tested-by: Paul Cercueil Signed-off-by: Florian Fainelli --- drivers/clk/ingenic/jz4780-cgu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/ingenic/jz4780-cgu.c b/drivers/clk/ingenic/jz4780-cgu.c index 1e88aef7ac0f..1809f8859c7e 100644 --- a/drivers/clk/ingenic/jz4780-cgu.c +++ b/drivers/clk/ingenic/jz4780-cgu.c @@ -242,8 +242,8 @@ static int jz4780_core1_enable(struct clk_hw *hw) spin_unlock_irqrestore(&cgu->lock, flags); /* wait for the CPU to be powered up */ - retval = readl_poll_timeout(cgu->base + CGU_REG_LCR, lcr, - !(lcr & LCR_SCPUS), 10, timeout); + retval = readl_poll_timeout_atomic(cgu->base + CGU_REG_LCR, lcr, + !(lcr & LCR_SCPUS), 10, timeout); if (retval == -ETIMEDOUT) { pr_err("%s: Wait for power up core1 timeout\n", __func__); return retval; -- 2.53.0