From: Michail Andreas Michalopoulos <mike.michalo@gmail.com>
To: icb@fastmail.org, linkinjeon@kernel.org
Cc: senozhatsky@chromium.org, tom@talpey.com,
chenxiaosong@chenxiaosong.com, linux-cifs@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Michail Andreas Michalopoulos <mike.michalo@gmail.com>
Subject: Re: [PATCH] ksmbd: fix out-of-bounds read in expired-session LOCK check
Date: Thu, 12 Nov 2026 11:52:38 +0700 [thread overview]
Message-ID: <20261112045238.4688-1-mike.michalo@gmail.com> (raw)
In-Reply-To: <MESSAGE-ID>
On top of linux-next 20261105 with the four newer ksmbd-for-next commits
up to a4277e7b7682, under KASAN, with session expiry forced by a
test-only hook as in your notes. With well-formed requests on an expired
session, before and after the patch:
- an unlock succeeds and releases the range; another client can then
lock it
- a new lock, and a request that unlocks one range and locks another,
both return STATUS_NETWORK_SESSION_EXPIRED and change nothing
- a compound of an unlock and a lock returns STATUS_SUCCESS and
STATUS_NETWORK_SESSION_EXPIRED
- READ is refused; CLOSE and LOGOFF succeed
These results are the same with and without the patch, with no KASAN
reports.
I did not test the malformed request itself.
One difference, for the better: a LOCK with a bad signature on an
expired session now goes through the signature check in
__process_request(), so it gets an unsigned STATUS_ACCESS_DENIED instead
of a STATUS_NETWORK_SESSION_EXPIRED signed with the session's key. Patch
5/8 of my v5 signing series fixes the same thing for the other commands;
the two patches do not overlap.
Tested-by: Michail Andreas Michalopoulos <mike.michalo@gmail.com>
next prev parent reply other threads:[~2026-11-12 4:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <MESSAGE-ID>
2026-06-24 4:44 ` [PATCH v2] staging: sm750fb: rename CamelCase pvMem and pvReg Arnav Kapoor
2026-07-07 6:25 ` Krzysztof Kozlowski
2026-11-12 4:52 ` Michail Andreas Michalopoulos [this message]
2026-11-12 3:18 [PATCH] ksmbd: fix out-of-bounds read in expired-session LOCK check Ian Bridges
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261112045238.4688-1-mike.michalo@gmail.com \
--to=mike.michalo@gmail.com \
--cc=chenxiaosong@chenxiaosong.com \
--cc=icb@fastmail.org \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=senozhatsky@chromium.org \
--cc=stable@vger.kernel.org \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®