From: Jakub Kicinski <kuba@kernel.org>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: netdev@vger.kernel.org, Jonas Gorski <jonas.gorski@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH net v4 7/8] net: dsa: b53: harden mirror register programming
Date: Thu, 12 Nov 2026 09:19:27 -0800 [thread overview]
Message-ID: <20261112091927.7773f0a3@kernel.org> (raw)
In-Reply-To: <20261110035018.2169370-8-florian.fainelli@broadcom.com>
On Mon, 9 Nov 2026 19:50:17 -0800 Florian Fainelli wrote:
> --- a/drivers/net/dsa/b53/b53_priv.h
> +++ b/drivers/net/dsa/b53/b53_priv.h
> @@ -548,6 +548,7 @@ int b53_mdb_add(struct dsa_switch *ds, int port,
> int b53_mdb_del(struct dsa_switch *ds, int port,
> const struct switchdev_obj_port_mdb *mdb,
> struct dsa_db db);
> +int b53_mirror_init(struct dsa_switch *ds);
this needs to go to patch 6, otherwise there's a transient:
drivers/net/dsa/b53/b53_common.c:2607:5: warning: no previous prototype for function 'b53_mirror_init' [-Wmissing-prototypes]
2607 | int b53_mirror_init(struct dsa_switch *ds)
| ^
--
pw-bot: cr
next prev parent reply other threads:[~2026-11-12 17:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 3:50 [PATCH net v4 0/8] net: dsa: b53: Preliminary fixes Florian Fainelli
2026-11-10 3:50 ` [PATCH net v4 1/8] net: dsa: b53: initialize the jumbo frame size register offset Florian Fainelli
2026-11-10 3:50 ` [PATCH net v4 2/8] net: dsa: b53: fix the SRAB grant timeout check Florian Fainelli
2026-11-10 3:50 ` [PATCH net v4 3/8] net: dsa: b53: clear stale state when creating an ARL entry Florian Fainelli
2026-11-10 3:50 ` [PATCH net v4 4/8] net: dsa: b53: reject conflicting mirror destinations Florian Fainelli
2026-11-10 3:50 ` [PATCH net v4 5/8] net: dsa: b53: use the correct override register 2 Gbps bit Florian Fainelli
2026-11-10 3:50 ` [PATCH net v4 6/8] net: dsa: b53: reference count shared mirror source bits Florian Fainelli
2026-11-10 3:50 ` [PATCH net v4 7/8] net: dsa: b53: harden mirror register programming Florian Fainelli
2026-11-12 17:19 ` Jakub Kicinski [this message]
2026-11-10 3:50 ` [PATCH net v4 8/8] net: dsa: b53: fix mirror port encoding on BCM5325 and BCM5365 Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261112091927.7773f0a3@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=jonas.gorski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®