mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kees Cook <kees@kernel.org>
To: Mariia Nikitash <nikitash.mariiaw@gmail.com>
Cc: mchehab@kernel.org, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
	justinstitt@google.com, morbo@google.com, alx@kernel.org,
	shlomojune6@gmail.com
Subject: Re: [PATCH v4] media: siano: Replace strlcat() with scnprintf() in sms_ir_init()
Date: Thu, 12 Nov 2026 10:23:11 -0800	[thread overview]
Message-ID: <202611121022.A022CD5A4@keescook> (raw)
In-Reply-To: <20261107033928.13891-1-nikitash.mariiaw@gmail.com>

On Fri, Nov 06, 2026 at 07:39:28PM -0800, Mariia Nikitash wrote:
> In preparation for removing the deprecated strlcat() API[1], replace
> the strscpy() and strlcat() calls with a single bounded scnprintf()
> call to construct the IR device path.
> 
> This preserves the original NUL-terminated output, including partial
> or omitted "/ir0" suffixes when the 32-byte buffer is too small.
> 
> Link: https://github.com/KSPP/linux/issues/370 [1]
> Signed-off-by: Mariia Nikitash <nikitash.mariiaw@gmail.com>

Thanks for the revisions! :)

Reviewed-by: Kees Cook <kees@kernel.org>

-- 
Kees Cook

      parent reply	other threads:[~2026-11-12 18:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04  9:02 [PATCH] media: siano: Replace strlcat() with snprintf() " Mariia Nikitash
2026-11-04 11:25 ` Alejandro Colomar
2026-11-04 19:01   ` Mariia Nikitash
2026-11-05 11:32   ` David Laight
2026-11-06  4:08     ` Mariia Nikitash
     [not found]     ` <CAPDEY+X7q2yeWaa7J=Nre+pQqUa2C760Hh9NovdGNSQ=VsEr8w@mail.gmail.com>
2026-11-06 10:27       ` David Laight
2026-11-06 16:06         ` Kees Cook
2026-11-07  3:50           ` Mariia Nikitash
2026-11-04 16:33 ` Shihuang Liu
2026-11-04 18:50 ` [PATCH v2] " Mariia Nikitash
2026-11-07  3:39 ` [PATCH v4] media: siano: Replace strlcat() with scnprintf() " Mariia Nikitash
2026-11-07  7:35   ` Alejandro Colomar
2026-11-07 10:28   ` Shihuang Liu
2026-11-12 18:23   ` Kees Cook [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202611121022.A022CD5A4@keescook \
    --to=kees@kernel.org \
    --cc=alx@kernel.org \
    --cc=justinstitt@google.com \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=morbo@google.com \
    --cc=nikitash.mariiaw@gmail.com \
    --cc=shlomojune6@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®