mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Leo Yan <leo.yan@arm.com>
To: Shuai Xue <xueshuai@linux.alibaba.com>
Cc: stable@vger.kernel.org, sashal@kernel.org,
	gregkh@linuxfoundation.org, yeoreum.yun@arm.com,
	suzuki.poulose@arm.com, coresight@lists.linaro.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] coresight/etm4: fix missing disable active config
Date: Thu, 12 Nov 2026 14:46:07 +0000	[thread overview]
Message-ID: <20261112144607.GJ9176@e132581.arm.com> (raw)
In-Reply-To: <20261112135406.71749-1-xueshuai@linux.alibaba.com>

On Thu, Nov 12, 2026 at 09:54:06PM +0800, Shuai Xue wrote:
> From: Yeoreum Yun <yeoreum.yun@arm.com>
> 
> commit 895b12b7d7b8c651f73f57a1ea040d35aa7048cb upstream.
> 
> When etm4 device is disabled via sysfs, it should disable its active
> count.
> 
> Fixes: 7ebd0ec6cf94 ("coresight: configfs: Allow configfs to activate configuration")
> Signed-off-by: Yeoreum Yun <yeoreum.yun@arm.com>
> Reviewed-by: Leo Yan <leo.yan@arm.com>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> [ shuai: kept spin_lock()/spin_unlock() in etm4_disable_sysfs(); 6.6.y does not have the raw spinlock conversion ]
> Signed-off-by: Shuai Xue <xueshuai@linux.alibaba.com>

> ---
> Note for stable maintainers: this is patch 1/3 of LKML series
> 20250514161951.3427590. Its siblings are already in 6.6.y: 2/3
> (53b9e2659719) as 1cd09aaf47a5 and 3/3 (408c97c4a5e0) as
> b3b4efa2e623, but this one was only ever picked into 6.15.y
> (c7f2b00d5e17e) because it does not apply cleanly to 6.6.y without the
> raw spinlock conversion. Without it, each sysfs enable/disable cycle
> leaks one config_desc->active_cnt reference and the module reference
> taken on the config load owner, so the configuration module can never
> be unloaded.

Makes sense for me. This backport should be applied on both 6.6.y
and 6.12.y.

      reply	other threads:[~2026-11-12 14:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12 13:54 Shuai Xue
2026-11-12 14:46 ` Leo Yan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261112144607.GJ9176@e132581.arm.com \
    --to=leo.yan@arm.com \
    --cc=coresight@lists.linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=suzuki.poulose@arm.com \
    --cc=xueshuai@linux.alibaba.com \
    --cc=yeoreum.yun@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®