From: Sasha Levin <sashal@kernel.org>
To: Kartik Rajput <kkartik@nvidia.com>
Cc: Kees Cook <kees@kernel.org>, Tony Luck <tony.luck@intel.com>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
Jon Hunter <jonathanh@nvidia.com>,
Thierry Reding <thierry.reding@kernel.org>,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v2 RESEND] pstore/zone: Emit registration message as a single pr_info()
Date: Thu, 12 Nov 2026 09:50:43 -0500 [thread overview]
Message-ID: <20261112145043.1507232-1-sashal@kernel.org> (raw)
In-Reply-To: <20260710094404.995355-1-kkartik@nvidia.com>
Two comments below, but not worth a respin for these.
On Fri, Jul 10, 2026 at 03:14:04PM +0530, Kartik Rajput wrote:
>@@ -1301,6 +1302,10 @@ int register_pstore_zone(struct pstore_zone_info *info)
> {
> int err = -EINVAL;
> struct psz_context *cxt = &pstore_zone_cxt;
>+ char buf[256];
The line can't get longer than about 50 characters, so 256 bytes of stack is a
lot.
>+ struct seq_buf s;
>+
>+ seq_buf_init(&s, buf, sizeof(buf));
DECLARE_SEQ_BUF(s, 64) would replace the buffer, the struct and this call with
one line.
Reviewed-by: Sasha Levin <sashal@kernel.org>
--
Thanks,
Sasha
prev parent reply other threads:[~2026-11-12 14:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 9:44 Kartik Rajput
2026-10-13 10:51 ` Jon Hunter
2026-11-12 14:50 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261112145043.1507232-1-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=gpiccoli@igalia.com \
--cc=jonathanh@nvidia.com \
--cc=kees@kernel.org \
--cc=kkartik@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®