From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794529660; b=mnvN932OpIiMGYc2NRD0YG9EmO2H9y2nnM73yK5rhHT4iWgU+AQ3LgCoZRyFFBThvSAH nC8tYue4HeTZfJPxrzSj1TBw5irXNJE55WB6/e2suREvTFUSBiF/EGFgqsiZzrr4Hced2 lKe7fdXCFmYcvAQCvhUuG9ZHStcyeVKb7YbPb9T+D2uCjNAuyQH595S0b/EcHolRi2VoJ cYrYHfNh0xOlOwyMBN9Zdof/7WV3Pi2z+7pjaGkwR75nFTUZg8SZp809KsG4Vb5w9ODUx LeVfSPd2INs/0SFVOBpx46g+vsn56CtYpMk3igLEB0tvfYFcZwIHTSHhMhm0KC6wtxQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794529660; h=Received:DKIM-Signature:Date:From:To:Cc:Subject:Message-Id: In-Reply-To:References:X-Mailer:Mime-Version:Content-Type: Content-Transfer-Encoding; bh=J4uyCKwoU2ZUCtJEnB2UmwB5w4/Naib62nyhZDy72sc=; b=aR0kWvppmXgd13VPLcv5mz3/mxbXRgQdKz1kV/X2qJxCLHj0/wTU2eXafhDlOON02dLV J+5p6EeE+ECrz5h7sfKU81823ZQCz8q4PDEqSR5jc7IapicIYNCDeqFNXT0WEHF56vLgP VzZlQhL1HdpykwstJoYCdRfX6O2uCpoWph1xItYd/zSOSGHMDYuice/zdOg734MGSNhIO xiXkkUR119cqG9ZM/gcC/ANGDlVmkC+Nn9BCBHHUXG60mYGfJciaWK6IMsCKU8XXffhom Hhfvop8gefStTVFeMPFO9fAPhWcLXcz7hQaO0XttP47eeUb1HsXHUsyqmNGVoCxCxgw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linux-foundation.org header.i=@linux-foundation.org header.a=rsa-sha256 header.s=korg header.b=EKlCtyFR; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CD82606A321 for ; Fri, 13 Nov 2026 00:27:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux-foundation.org header.i=@linux-foundation.org header.a=rsa-sha256 header.s=korg header.b=EKlCtyFR Received: by smtp.kernel.org (Postfix) with ESMTPSA id D3FF91F000C4; Fri, 13 Nov 2026 00:27:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=korg; t=1794529659; bh=J4uyCKwoU2ZUCtJEnB2UmwB5w4/Naib62nyhZDy72sc=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=EKlCtyFR0G3LjMnWtYrdKkTgBAehi0VR4yOuK+2aRnoodEo+e1zmWIfkZTHLjYB1P pMSxyfyQ0J0Ri07DLyGs/JZxFILKGtIY+BkEeQRW7wJpPeGqeemXoa8tbeg0Wce32L dyK4nVN/Bzh+LcPW6JZ9e5fRVWKngprMwyRK+Xp0= Date: Thu, 12 Nov 2026 16:27:38 -0800 From: Andrew Morton To: Mika =?ISO-8859-1?Q?Penttil=E4?= Cc: Jason Gunthorpe , Alexandru Elisei , linux-mm@kvack.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-kernel@vger.kernel.org, David Hildenbrand , Leon Romanovsky , Alistair Popple , Balbir Singh , Zi Yan , Matthew Brost , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Lyude Paul , Danilo Krummrich Subject: Re: [PATCH v17 00/12] migrate on fault for device pages Message-Id: <20261112162738.d689b46268e077ac06f41d91@linux-foundation.org> In-Reply-To: References: <20261103061629.972669-1-mpenttil@redhat.com> <79f33ab0-2e43-4efb-94d0-addaf40745ec@redhat.com> <20261112164752.GA3692174@nvidia.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Thu, 12 Nov 2026 19:01:58 +0200 Mika Penttil=E4 wr= ote: >=20 > On 11/12/26 18:47, Jason Gunthorpe wrote: > > On Thu, Nov 12, 2026 at 04:24:05PM +0000, Alexandru Elisei wrote: > >> Hi Mika, > >> > >> On Thu, Nov 12, 2026 at 04:00:09PM +0200, Mika Penttil=E4 wrote: > >>> Hi Alexandru! > >>> > >>> On 11/12/26 13:56, Alexandru Elisei wrote: > >>>> Hi Mika, > >>>> > >>>> I want to help getting this series merged, and I've been familiarizi= ng myself > >>>> with hmm and device migration, please bare with me if the questions = I'm asking > >>>> are obvious or downright silly. > >>> Thanks for the interest and willing to help! I am preparing a v18 of = the > >>> series and plan to post it early next week. > >> The series is big, and as far as I can tell the MM people are hard at = work > >> reviewing bug fixes. It might be better to wait a while, to give peopl= e a > >> chance to have a look? I know that if I see a series being reposted of= ten, > >> I am less inclined to review the patches since probably a new iteration > >> will be posted soon. But I can only speak for myself, you know best. > > It is at v17 and it is still getting high severity sashiko errors > v14 was first that sashiko managed to review. There was a regression in > last posting, but also false potsitives, and sashiko reports same issue > then 3-4 times, so the reality is not that bad.=A0 Pining for the days when all we had to deal with was checkpatch. =20 Mika, afaict the entire patchset is a performance optimization, yet you say "I don't have a benchmark showing a gain". Recipients look at patchsets wondering "why should I spend time on this", especially in these times. It's best to answer this question right there in the first sentence of the [0/N]. That means numbers, and the better they are, the more attention the patchset will get. > Documentation/mm/hmm.rst | 45 + > drivers/gpu/drm/nouveau/nouveau_dmem.c | 402 ++++++++- > drivers/gpu/drm/nouveau/nouveau_dmem.h | 12 + > drivers/gpu/drm/nouveau/nouveau_svm.c | 155 ++-- > drivers/gpu/drm/nouveau/nouveau_svm.h | 5 + > include/linux/hmm.h | 51 +- > include/linux/migrate.h | 59 +- > lib/test_hmm.c | 174 +++- > lib/test_hmm_uapi.h | 21 +- > mm/Kconfig | 1 + > mm/hmm.c | 1075 ++++++++++++++++++++++-- > mm/migrate_device.c | 618 +++----------- > tools/testing/selftests/mm/hmm-tests.c | 56 ++ > 13 files changed, 1984 insertions(+), 690 deletions(-) also, yikes!