From: Peter Hunt <peter.hunt@opengear.com>
To: kuba@kernel.org
Cc: netdev@vger.kernel.org, loic.poulain@oss.qualcomm.com,
ryazanov.s.a@gmail.com, johannes@sipsolutions.net,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org,
pabeni@redhat.com, linux-kernel@vger.kernel.org,
dnlplm@gmail.com
Subject: Re: [PATCH net-next] net: wwan: mhi_wwan_ctrl: say the DTR drop flush is best effort
Date: Thu, 12 Nov 2026 10:19:07 -0700 [thread overview]
Message-ID: <20261112171907.30297-1-peter.hunt@opengear.com> (raw)
In-Reply-To: <20261112014152.3352925-1-kuba@kernel.org>
On Wed, 11 Nov 2026 17:41:52 -0800, Jakub Kicinski wrote:
> Should the comment in mhi_wwan_ctrl_stop() get the same treatment? The
> patch leaves it as is, and it uses the same flush_delayed_work() pattern:
Yes, I missed that one. The flush in stop() makes one attempt like the
one in ->dtr_rts(), and a retry goes out from dtr_work after the channel
has stopped. v2 says so.
> A smaller point: the new comment here gives only a full UL ring as the
> retry cause. -ENOMEM from kzalloc_obj() in mhi_wwan_ctrl_send_dtr() is
> retried the same way. Would it help to mention both, as the comment above
> mhi_wwan_ctrl_dtr_work() already does?
Agreed, v2 names both.
Thanks, v2 to follow.
prev parent reply other threads:[~2026-11-12 17:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 18:57 Peter Hunt
2026-11-12 1:41 ` Jakub Kicinski
2026-11-12 17:19 ` Peter Hunt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261112171907.30297-1-peter.hunt@opengear.com \
--to=peter.hunt@opengear.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dnlplm@gmail.com \
--cc=edumazet@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ryazanov.s.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®