mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Nicolas Schier <nsc@kernel.org>
Cc: Julian Braha <julianbraha@gmail.com>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Bill Wendling <morbo@google.com>,
	Justin Stitt <justinstitt@google.com>,
	Arnd Bergmann <arnd@arndb.de>, Kees Cook <kees@kernel.org>,
	linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
	llvm@lists.linux.dev,
	Charlie Jenkins <thecharlesjenkins@gmail.com>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 4/6] riscv: checksum: Fix CC_HAS_ASM_GOTO_TIED_OUTPUT check
Date: Thu, 12 Nov 2026 10:21:28 -0700	[thread overview]
Message-ID: <20261112172128.GB4107043@ax162> (raw)
In-Reply-To: <avWiaIuhkYw_xE5A@levanger>

On Thu, Nov 12, 2026 at 12:26:32PM +0100, Nicolas Schier wrote:
> On Wed, Nov 11, 2026 at 05:52:06PM -0700, Nathan Chancellor wrote:
> > The defined symbol is CONFIG_CC_HAS_ASM_GOTO_TIED_OUTPUT, not
> > CC_HAS_ASM_GOTO_TIED_OUTPUT.
> > 
> > Fixes: 4525462dd0db ("riscv: lib: Check if output in asm goto supported")
> > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> > ---
> > Cc: Charlie Jenkins <thecharlesjenkins@gmail.com>
> > Cc: Paul Walmsley <pjw@kernel.org>
> > Cc: Palmer Dabbelt <palmer@dabbelt.com>
> > Cc: linux-riscv@lists.infradead.org
> > ---
> >  arch/riscv/lib/csum.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> 
> Thanks for catching!
> 
> Reviewed-by: Nicolas Schier <nsc@kernel.org>
> 
> Since 4525462dd0db (v6.7) still supported clang-11: shall we add 'Cc: stable'?

I was a little on the fence about the 'Cc: stable'. On the one hand, it
is definitely a bug and it would totally qualify for stable. On the
other hand, nobody has noticed for almost three years and it is
exercising a new code path. I'll leave that up to you when you apply it
(or the RISC-V people can give their input as well).

-- 
Cheers,
Nathan

  reply	other threads:[~2026-11-12 17:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12  0:52 [PATCH v2 0/6] scripts/Kconfig.toolchain: Document minimum supported versions for dynamic checks Nathan Chancellor
2026-11-12  0:52 ` [PATCH v2 1/6] scripts/Kconfig.toolchain: Remove CONFIG_CC_HAS_NO_PROFILE_FN_ATTR Nathan Chancellor
2026-11-12 11:15   ` Nicolas Schier
2026-11-12  0:52 ` [PATCH v2 2/6] scripts/Kconfig.toolchain: Do not dynamically probe '-fno-addrsig' Nathan Chancellor
2026-11-12 11:21   ` Nicolas Schier
2026-11-12  0:52 ` [PATCH v2 3/6] scripts/Kconfig.toolchain: Clean up '-fno-allow-store-data-races' handling Nathan Chancellor
2026-11-12 11:25   ` Nicolas Schier
2026-11-12  0:52 ` [PATCH v2 4/6] riscv: checksum: Fix CC_HAS_ASM_GOTO_TIED_OUTPUT check Nathan Chancellor
2026-11-12 11:26   ` Nicolas Schier
2026-11-12 17:21     ` Nathan Chancellor [this message]
2026-11-12  0:52 ` [PATCH v2 5/6] Eliminate CONFIG_CC_HAS_ASM_GOTO_TIED_OUTPUT Nathan Chancellor
2026-11-12 11:34   ` Nicolas Schier
2026-11-12 17:47     ` Nathan Chancellor
2026-11-12  0:52 ` [PATCH v2 6/6] scripts/Kconfig.toolchain: Document minimum supported versions for dynamic checks Nathan Chancellor
2026-11-12 11:42   ` Nicolas Schier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261112172128.GB4107043@ax162 \
    --to=nathan@kernel.org \
    --cc=arnd@arndb.de \
    --cc=julianbraha@gmail.com \
    --cc=justinstitt@google.com \
    --cc=kees@kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=llvm@lists.linux.dev \
    --cc=morbo@google.com \
    --cc=ndesaulniers@google.com \
    --cc=nsc@kernel.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=thecharlesjenkins@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®