From: Ian Bridges <icb@fastmail.org>
To: mike.michalo@gmail.com
Cc: linkinjeon@kernel.org, senozhatsky@chromium.org, tom@talpey.com,
linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org,
Ian Bridges <icb@fastmail.org>
Subject: Re: [PATCH] ksmbd: sign the last response of a compound that ends early
Date: Thu, 12 Nov 2026 14:55:51 -0600 [thread overview]
Message-ID: <20261112205551.1668102-1-icb@fastmail.org> (raw)
In-Reply-To: <20261112194744.47047-1-mike.michalo@gmail.com>
I tested this with the ksmbd code from ksmbd-for-next. I sent a signed
compound of two ECHOs whose second NextCommand covers only that
command, so the compound ends early. Before the patch, the first
response carried a signature that did not verify and the second was
not signed. With the patch, both responses are signed and verify. A
normal signed compound gives the same result as before, and the
connection keeps working in both cases. smbtorture gives the same
results as without the patch, and KASAN reports nothing.
Reviewed-by: Ian Bridges <icb@fastmail.org>
Tested-by: Ian Bridges <icb@fastmail.org>
prev parent reply other threads:[~2026-11-12 20:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 19:47 Michail Andreas Michalopoulos
2026-11-12 20:55 ` Ian Bridges [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261112205551.1668102-1-icb@fastmail.org \
--to=icb@fastmail.org \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.michalo@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®