mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnav Kapoor <kapoorarnav43@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Andy Shevchenko" <andriy.shevchenko@intel.com>,
	"Gwendal Grignou" <gwendal@chromium.org>,
	"Joshua Crofts" <joshua.crofts1@gmail.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/3] iio: proximity: sx93xx: keep the IRQ balanced across suspend and resume
Date: Fri, 13 Nov 2026 03:35:47 +0530	[thread overview]
Message-ID: <20261112220547.508369-1-kapoorarnav43@gmail.com> (raw)
In-Reply-To: <20261108012904.4555e72b@jic23-hlaptop>

On Sun, Nov 08, 2026 at 01:29:04AM +0000, Jonathan Cameron wrote:
> All 3 of these look fine to me, but given they aren't totally trivial
> I'm going to leave them for a while in the hope someone will test at least
> one of them! If it looks like that's not happening I may pick them
> up in a week or two.

Please don't pick these up yet, I found a problem with v4.

Moving disable_irq_nosync() to the end of suspend leaves the interrupt
enabled while suspend holds data->mutex for the register writes. If the
sensor fires then, the threaded handler blocks on the mutex, and since
disable_irq_nosync() doesn't wait for it, it runs once suspend returns,
against a paused sensor. Sashiko pointed this out on sx9310, and sx9324
and sx9360 have the same pattern.

I'll send v5 that calls disable_irq() before taking the mutex and
enables the interrupt again if suspend fails.

Thanks,
Arnav

      reply	other threads:[~2026-11-12 22:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-01 10:25 Arnav Kapoor
2026-11-01 10:25 ` [PATCH v4 1/3] iio: proximity: sx9310: " Arnav Kapoor
2026-11-01 10:25 ` [PATCH v4 2/3] iio: proximity: sx9324: " Arnav Kapoor
2026-11-01 10:25 ` [PATCH v4 3/3] iio: proximity: sx9360: " Arnav Kapoor
2026-11-08  1:29 ` [PATCH v4 0/3] iio: proximity: sx93xx: " Jonathan Cameron
2026-11-12 22:05   ` Arnav Kapoor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261112220547.508369-1-kapoorarnav43@gmail.com \
    --to=kapoorarnav43@gmail.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=gwendal@chromium.org \
    --cc=jic23@kernel.org \
    --cc=joshua.crofts1@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®