From: Breno Leitao <leitao@debian.org>
To: Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: catalin.marinas@arm.com, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-team@meta.com,
Breno Leitao <leitao@debian.org>
Subject: [PATCH] gpiolib: fix leaked descriptor labels in gpiodev_release()
Date: Fri, 13 Nov 2026 06:38:28 -0800 [thread overview]
Message-ID: <20261113-gpio-label-leak-v1-1-c6c00f8ebfff@debian.org> (raw)
We are seeing kmemleak report a leaked descriptor label on linux-next.
unreferenced object 0xffff0005d420f280 (size 32):
comm "gpio-cdev-uaf", pid 21987, jiffies 4297166145
backtrace (crc 7ff222d9):
kmemleak_alloc+0x40/0xd0
__kmalloc_noprof+0x300/0x670
desc_set_label+0x50/0x190
gpiod_request_commit+0x1e8/0x358
gpiod_request+0x88/0x290
gpio_ioctl+0x7e4/0x1b48
__arm64_sys_ioctl+0xc10/0x1360
The test requests a line, removes the gpio-sim chip under it, and only
then closes the request. By that time gpiochip_remove() has cleared
gdev->chip, so gpiod_free_commit() skips desc_set_label(desc, NULL), and
gpiodev_release() frees the descriptor array without the labels still
attached to it.
Free those labels in gpiodev_release(). No reader can reach the
descriptors once the device is released, so they can be freed directly
rather than through call_srcu(). gdev->descs is NULL there when
gpiochip_add_data_with_key() failed to allocate it.
Fixes: 35b545332b80 ("gpio: remove gpio_lock")
Signed-off-by: Breno Leitao <leitao@debian.org>
---
drivers/gpio/gpiolib.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 033c6fce4fc8da..3d301234dff44d 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -896,11 +896,16 @@ static void gpiochip_free_remaining_irqs(struct gpio_chip *gc)
static void gpiodev_release(struct device *dev)
{
struct gpio_device *gdev = to_gpio_device(dev);
+ unsigned int i;
/* Call pending kfree()s for descriptor labels. */
synchronize_srcu(&gdev->desc_srcu);
cleanup_srcu_struct(&gdev->desc_srcu);
+ /* Lines released after the chip was removed still hold their label. */
+ for (i = 0; gdev->descs && i < gdev->ngpio; i++)
+ kfree(rcu_access_pointer(gdev->descs[i].label));
+
ida_free(&gpio_ida, gdev->id);
kfree_const(gdev->label);
kfree(gdev->descs);
---
base-commit: 6d582d78fad9d828e575ca0cdcff8ea47a77220b
change-id: 20261113-gpio-label-leak-4c296355d62b
Best regards,
--
Breno Leitao <leitao@debian.org>
next reply other threads:[~2026-11-13 14:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 14:38 Breno Leitao [this message]
2026-11-13 15:29 ` Andy Shevchenko
2026-11-13 17:00 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261113-gpio-label-leak-v1-1-c6c00f8ebfff@debian.org \
--to=leitao@debian.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=kernel-team@meta.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®