From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794589614; b=SHzvQVdOBrHtZMcb+lxcMrqI5VoMeMUATM8p+50y5tk2HmuwVk567VfiHK9nJfHR5CRI /MZ//krji2BFrxYVxCDIDsyE1aEB7OIMBM/P2L+OI0t8xGMPDO6rAMDiWwC4725k2pPBy KDu6gcb6/gn3k4IZd5wTmSQ0swR/ebetAr9OBgiEUyWKd+qr1Llz0f1hs3Y0h4nMta152 vPJOeKwIOvpz4ExGWxM+4grzE/gSv1cQAOCsy4kc4OwBWm2RvzF3+E5YDYvalj2ng9+uv pkR+vPkCsukyTiL8AuWpO4DHGlgDvfc3CeYuZUdMnqUHiSSm32EvreQthxDLTSGV8pA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794589614; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:From:Date: Subject:MIME-Version:Content-Type:Content-Transfer-Encoding: Message-Id:X-B4-Tracking:X-Change-ID:To:Cc:X-Mailer: X-Developer-Signature:X-Developer-Key; bh=/Kki3X4dpm9KxQ2mH9Sq8u46jfClQkMQattSavxbdrg=; b=i25Xa3RXj9v56F4nX6kb6XN9lXjKU7BMWuxbAf1HgkMSEbQ2ABJyAC2HxFpr5KHFWSYj EawlAxIDx5teBJ4a7pv1GT4CSsLzxW16JuqT6p4WvzkPLuOtuljcikTVLGs9QA+azpReo QpymlQ7rhJz1llJ0aSdJ3smbSmQi0nApqgC5bU5hrb09K8rWqskS+rZVDWiPOv2ka5GEG ksO7T+8b+tl1zl9VgGw5Tm+ia0cSF6Xt8ob6/SXdNzxVnMJPPlOSxlTJpFkzx7aS+f2mY Q5Gs+/riO2QU/oA4Cpj8dJYM3Wd1zyrulfA0i4U2MvwpBRuLCwOWtMYybVfN8hGEnJA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b="Ekzg/bbg"; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=DN0A8kzP; arc=none smtp.remote-ip=170.10.129.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55F8B606A334 for ; Fri, 13 Nov 2026 17:06:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 55F8B606A334 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Ekzg/bbg; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=DN0A8kzP DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1794589613; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/Kki3X4dpm9KxQ2mH9Sq8u46jfClQkMQattSavxbdrg=; b=Ekzg/bbgkihF+aYzObecGMCLkF+PV4ImBG3tKDtW1XNLgZ5O9/O+RQUwAqgCAZCZVLwjRK 4c+wm49gm/rfTr5Rx50iG44af2EPbMQxo+uJiMizSoK3crn46Q5KTQWCauT55Ub0Viz5ax 1BRzJQ/PDnXIGBUVZEqhpivP/Z2D3SQ= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-49-YorxFobPMf2D8hzCeq5CvA-1; Fri, 13 Nov 2026 12:06:50 -0500 X-MC-Unique: YorxFobPMf2D8hzCeq5CvA-1 X-Mimecast-MFC-AGG-ID: YorxFobPMf2D8hzCeq5CvA_1794589609 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4a1fdde384cso6349685e9.3 for ; Fri, 13 Nov 2026 09:06:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1794589609; x=1795194409; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=/Kki3X4dpm9KxQ2mH9Sq8u46jfClQkMQattSavxbdrg=; b=DN0A8kzP7RKo5fQGq5KIDkrbwb79NY3IE65mhKRVjpzPSTFMS9eMdYv6wgN7jB03k8 S5OFWCcwkMw5tCtB16JOMgqvqLtXGNFC2gmc8g41p0IXmkraV2y7AcK3Q39pBERBptw6 IWS40Bc1CIAH64kHFFyf+RGmHxuIJ0fhyAxUWfHmKevHbVfSUm4F6PNY8oAnX3S42pyp SUyXtLrVzeJSsN3MLTG9GmVNGNR3xgl2nw0Gm3n8mbAgJZVZapgbaQfXKj2fb2ZIkM3i J6/228HRBxCKwci4uHO4D2EJeBiJnknWP//bRZo/7Q623qGSFAYF1puHjnZTsRalv9ym ZErQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794589609; x=1795194409; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=/Kki3X4dpm9KxQ2mH9Sq8u46jfClQkMQattSavxbdrg=; b=PG9C1SamaumLwcsbUS47CmX1KlfUQg+iVLzQRPE1LNvHDuNhuGuCadEVtQYVmzVKgD qrm0EMcMHHtkfc67iwyuRSIMfKeOuTHjiF+7sHv9fr/weYYKI0FkFaEfi4zDr1mldXPZ aU8czVbJlK4IYmhn4ULLnILMrnbwEXSKzt5LkIgLN+HFc6NZgtH8H/7VENXssjxw9bwF OaGipjntCFEohgW2rifgxyRBHoCQTfMQNm4iHeQxVG0/LlhAS+E0QpQMQq1J4tq4s9Fs jwCpkXSWfjPBcznAwhCWO/JOrKwDkLBHFO23I891VWw/qvCPi5D6HD3aJ+fWywgPu6Wx WcDQ== X-Gm-Message-State: APuU4Z9jLU24RYy67Odcuoj1f14QExdVQLsV5cjuAocqAbPFUtPUk1ym 9lLCMFMICFw++Olq2RFxlKHxUX3CjjRz+NdExDyHWBEAiXcc4k+fpyirgFQ8C2WRlmgvmwcUikq sGbnHMyKysBMHCwG3aRvlgPBT6YIpbNGEJCtILUn/s4bwFpmiED/3s3uymCUCXcKiJQ== X-Gm-Gg: AYBFou0mW6n/b0Tk7X2gIL23GsVr48G3mFDAyx/ArNHv8iwLsIs1VvJyIKE4mejvJ7O TgcckOrtXYsmFDXTekqiWbdAp4TfAdpBJuhkNCs9wJDj/54cBncOoqrZR/rPJ9lg4NGw2DD5zNi S5FCHqfdHnZNlOY4wWqp7vsEAs9p+0GvmnNC8QiZOFYJ5R85s0mXBAlyHurMJeNAivfHEjPJN2H 1vpe37615sBrAtTDgAIr+MmeTFvZwYVUXrDO5H2tOx5Z3jxNfwt7R45tv6RRQ2TOzTrRseJiXXI MnwJzPtpUiG/bNw0XYJOE8QPySMv2kAUtIS6jf1++t6YBJM6fJmnbj6Njw+OMyIepjciJipkofq 09CSN27cEnmNW6B/sJl6pgyVvwoxbCNnhIoHEtvITXbAavGESn+CRsA/HYsC2n9Xl//QRhRD4xG naOtOPAWcBeNs= X-Received: by 2002:a05:600c:c84:b0:4a5:e6fd:65e5 with SMTP id 5b1f17b1804b1-4bb55aa3a2dmr71557525e9.31.1794589609300; Fri, 13 Nov 2026 09:06:49 -0800 (PST) X-Received: by 2002:a05:600c:c84:b0:4a5:e6fd:65e5 with SMTP id 5b1f17b1804b1-4bb55aa3a2dmr71556725e9.31.1794589608889; Fri, 13 Nov 2026 09:06:48 -0800 (PST) Received: from [192.168.0.19] (217.red-88-4-146.dynamicip.rima-tde.net. [88.4.146.217]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-49c5f7828a4sm6409906f8f.23.2026.11.13.09.06.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2026 09:06:47 -0800 (PST) From: Sergio Lopez Date: Fri, 13 Nov 2026 18:04:40 +0100 Subject: [PATCH] vsock/vmci: reject datagram binds in local network namespaces X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261113-vsock-vmci-netns-isolation-v1-1-ced02054ea61@redhat.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/x3MQQqAIBBA0avErBtIjYSuEi1CpxoqDSckiO6et HyL/x8QSkwCffVAoszCMRSougK3TmEhZF8MutGdUspglug2zIdjDHQFQZa4T1fJ0FLbWaO989Z AGZyJZr7/+TC+7we3RtBCbAAAAA== X-Change-ID: 20261113-vsock-vmci-netns-isolation-7e46732dcd73 To: Bryan Tan , Vishnu Dasa , Broadcom internal kernel review list , Stefano Garzarella , Bobby Eshleman , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, netdev@vger.kernel.org, stable@vger.kernel.org, Sergio Lopez X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2143; i=slp@redhat.com; h=from:subject:message-id; bh=KbQnqpP7rtV1X6O9hhQI+C1Zj1a1cacc8D6sCunHM3M=; b=owEBbQKS/ZANAwAKAfRpJ40vDAI1AcsmYgBq90Ol4hWRYE7DbdCG5kDAinIgd4TLSotKXr8+l VPEwubE0OiJAjMEAAEKAB0WIQS+1fz3US2GgJFC6KL0aSeNLwwCNQUCavdDpQAKCRD0aSeNLwwC NTBrEACV2PMED4/7MyILMjnxuQfgS6QtiXtgSOjXHHrW3NfewioLlE1yJq6GEI03bNZP+lqKNQR AccWn/H2lR3qiABFWlijCpj1bJ6X26crcqVK0PEnG0KLdQkz356ogEpbDZtka1wFJR8w2JDhbRh Ys3iF93SvftH8KvSXnk+4rtMnbeUgKgHuL36L9XydhATObsweqMwrKlFJsNMdNpfOAJcpnxaAYg OqRFXGGO7Os0d1wmnsJL1uW/b/rMPdDxqWa6DTa1fPo4y4eqlIeWBO7HN7/pkHF7/tyUN+1DH/3 MQkWZwr+IHTEuF7W29ASzuHcYsauRC2kn9sOFhkT/sEIRAo2exPo7Z9R/WQujO5VG2ZyhvFeWMg ymJ2iO2YcbzSPwiuXvjCBEPbht32xQmpRGvFMC/Cc7ZLvKZ0h+62sIROMdWZdi+keTkFZfCLn7O hHs6bbahrRf96RF/J30sUH/2kZ5Jkq6gROnToNOk1HJK3bjL/CyMOoTohBR3sR0+uZOaH69RTRl 8ZSXuy0vIkwZM68jjduCnqtEMeMi8JT2yvpqyV6cq/IXhBqvQ7Jw/1Ik9hioviwwfvY5KyGML9i tK5qfhNnseLN7nPGYt4cCJRlBOfE7RajO1maGZq0JO+9wSiQa49D/53RC5VP+bmBLvPGjbT7C05 ixnW7xHwBAI1d5g== X-Developer-Key: i=slp@redhat.com; a=openpgp; fpr=BED5FCF7512D86809142E8A2F469278D2F0C0235 VMCI already rejects datagram sends from local network namespaces, but a datagram bind still creates a receive handle in VMCI's global port space. A VMCI sender outside the namespace can therefore deliver to the local socket. Its handle also prevents a global-namespace socket from binding the same port. Reject VMCI datagram binds in local namespaces. No namespace-local datagram transport exists, so EOPNOTSUPP reflects the available receive paths. The receive callback also rejects any local-mode socket as a defensive check. In a KASAN/lockdep QEMU guest, a reproducer observed cross-namespace delivery and the global port collision before the fix. After the fix, local bind returns EOPNOTSUPP, the global bind succeeds, and a global VMCI datagram still reaches the global socket. Fixes: eafb64f40ca4 ("vsock: add netns to vsock core") Cc: stable@vger.kernel.org Link: https://lore.kernel.org/all/sashiko-outbox-212907@kernel.org/ Signed-off-by: Sergio Lopez --- net/vmw_vsock/vmci_transport.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/net/vmw_vsock/vmci_transport.c b/net/vmw_vsock/vmci_transport.c index 1f186e8f8364..282131544c42 100644 --- a/net/vmw_vsock/vmci_transport.c +++ b/net/vmw_vsock/vmci_transport.c @@ -627,6 +627,8 @@ static int vmci_transport_recv_dgram_cb(void *data, struct vmci_datagram *dg) * outside of the create and destruct socket functions. */ vsk = vsock_sk(sk); + if (!vsock_net_mode_global(vsk)) + return VMCI_ERROR_NO_ACCESS; if (!vmci_transport_allow_dgram(vsk, dg->src.context)) return VMCI_ERROR_NO_ACCESS; @@ -1697,6 +1699,10 @@ static int vmci_transport_dgram_bind(struct vsock_sock *vsk, u32 flags; int err; + /* VMCI handles are global and cannot serve local namespaces. */ + if (!vsock_net_mode_global(vsk)) + return -EOPNOTSUPP; + /* VMCI will select a resource ID for us if we provide * VMCI_INVALID_ID. */ --- base-commit: 65ba8f34ec886ec72b2c07ddc8cf3d815c32869d change-id: 20261113-vsock-vmci-netns-isolation-7e46732dcd73 Best regards, -- Sergio Lopez