From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=pass header.oldest-pass=0 smtp.remote-ip=52.101.126.86 ARC-Seal: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=pass; t=1794585846; b=N3iD0nNFTe0aJ2vI703gh49WyWRzwENSacc1DpDa849osnXQiEvHB+jrS3qQKIkeNmVk 68D9MrNXpW9mUGaUC6mKlyuCTtXd4ewehJQTdk26cXZmm1wVlhFt1MreVRU4SIyDC/bVa fYYJNhYTVtdhOiTNCd25WXUAI0c6gIwNcK+tk/yWVbzoEvuALTrP9jFyD/Dfj6ZZkgSIb b/klsKwKelGxGCKJhgwxMnqwUdv6qNlAvcu0ZGa5JKvnQFtgJFKK7e3zXf5CZbOJ2xRne 9bHpCHHaajBGPYKqYGSLTmY8BNRp2LC/o96EuQGL+z/AVILNzwEcfKyqIblCwnLd2Ig== ARC-Message-Signature: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794585846; h=DMARC-Filter:Received:Received:X-MS-Exchange-Authentication-Results: Received-SPF:Received:Received:From:To:Cc:Subject:Date:Message-ID: X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding:X-EOPAttributedMessage: X-MS-PublicTrafficType:X-MS-TrafficTypeDiagnostic:Content-Type: X-MS-Office365-Filtering-Correlation-Id:X-MS-Exchange-SenderADCheck: X-MS-Exchange-AntiSpam-Relay:X-Microsoft-Antispam: X-Microsoft-Antispam-Message-Info:X-Forefront-Antispam-Report: X-MS-Exchange-AntiSpam-MessageData-ChunkCount: X-MS-Exchange-AntiSpam-MessageData-0:X-OriginatorOrg: X-MS-Exchange-CrossTenant-OriginalArrivalTime: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-Id: X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-FromEntityHeader: X-MS-Exchange-Transport-CrossTenantHeadersStamped; bh=WngfGjRncINeVNYDlRokTVicUnjpqrAZJQiuhDN9Ysc=; b=Y/wdFJYB2l5fz0N+FSCvqaTBcMJ/cJCM+RhXUeGB4JM4t8HGpbg5pCU4A7zAoHtm1Yfj sR4h0Iel/0B1bdID4tsWLKCDbjkpz+gKvqT67bxZw1J0PuWQWXJo8SZBPg0uJLPAT4tSM 0cFkEwqo6wusbR3qyYYQl/F6l0zqQqFequQwrnKeTlBHacexhnTMnfHyQxmNJaA6nGhCw JXBCnXXTyscU8FDTvF7fEUpwjZfNDvw26XD2aUvVllOt82hosZlSjAVoftfm5C6aqaKbV 0V9zVn0WvO6MAq4fZkdpPtUZoUEu5Rh56vzZ2p9zvY6h/xoZX5b4LCQQJfdMvqN3TMQ== ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=none header.from=cixtech.com; spf=pass smtp.mailfrom=cixtech.com; arc=pass header.oldest-pass=0 smtp.remote-ip=52.101.126.86 Received: from TYPPR03CU001.outbound.protection.outlook.com (mail-japaneastazon11022086.outbound.protection.outlook.com [52.101.126.86]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (secp384r1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CF4C606A88A; Fri, 13 Nov 2026 16:04:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 1CF4C606A88A Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cixtech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cixtech.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YzOZX+GLCVJXYEiKBFwmwq9Lys3ygMCFwzb7yF4JFGuSgVBDpl28FktjDJnjdDXw6Vd6+5Ezd3GRuelgDkva2ZibfTDDo1iFRJKGOqldznOARSaVwCoRC2mjrc89aXCIhW1HpKxihqkxE4HryjpxqQ31oCkJtOYPkAyuZjotPLxmo9QQY2i4hUGzCIBgVN3q1UVKkI38Akp3jtuf+XUQrNjzerGitgmXT3DBihQ3z2TVusHfwkUj1IcWNZMMtXfFfRLtgitNx1pYs15Wq+Wz/jXnH1DSCIy3KU2eBysOH41ovqHoEbfhm6wmVnr+prgfH9Q1uQ5EaGPXqh4LlaruTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WngfGjRncINeVNYDlRokTVicUnjpqrAZJQiuhDN9Ysc=; b=BhElquhTAO20KLNIfMdqtEYlO26InQrtZ4JPDJ+ypMNLSqW/CZ9GJcpYvC2Y59N5Ddtfw498QG53pL1o3U5bpVIwsE5VNLOPHqH/Pqkv53M/h7S/nKpwwNdTgqALFXdhW5kYzK525r91qbTHy1Qu0MDdrNJtYUhvqUScxANQywBhURQPFFFieXpC3fkTDBLsgz1A67Q2LrE2v2gq/0HQL2sOnK9q30jkERqPCJDn4NPPYDWAIYsz2gEeaqVfCbe3ECAEeIe9ErGIpWyUQd0JZFymryDEWp1gtNzcNuEH76AxQKFpku0H2Fpn5JvmVScInaXH8loHlQs1og/W5AFvHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 222.71.101.198) smtp.rcpttodomain=cadence.com smtp.mailfrom=cixtech.com; dmarc=bestguesspass action=none header.from=cixtech.com; dkim=none (message not signed); arc=none (0) Received: from SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) by SE1PPF7C5444CB3.apcprd06.prod.outlook.com (2603:1096:108:1::41e) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.615.10; Fri, 13 Nov 2026 16:04:01 +0000 Received: from SG2PEPF000B66CD.apcprd03.prod.outlook.com (2603:1096:4:140:cafe::9) by SI2P153CA0017.outlook.office365.com (2603:1096:4:140::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.639.0 via Frontend Transport; Fri, 13 Nov 2026 16:04:01 +0000 X-MS-Exchange-Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 222.71.101.198) smtp.mailfrom=cixtech.com; dkim=none (message not signed) header.d=none;dmarc=bestguesspass action=none header.from=cixtech.com; Received-SPF: Pass (protection.outlook.com: domain of cixtech.com designates 222.71.101.198 as permitted sender) receiver=protection.outlook.com; client-ip=222.71.101.198; helo=smtprelay.cixcomputing.com; pr=C Received: from smtprelay.cixcomputing.com (222.71.101.198) by SG2PEPF000B66CD.mail.protection.outlook.com (10.167.240.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.615.4 via Frontend Transport; Fri, 13 Nov 2026 16:04:01 +0000 Received: from hongliang-System-Product-Name (unknown [172.20.64.180]) by smtprelay.cixcomputing.com (Postfix) with ESMTPSA id 7C69B41A9A83; Fri, 13 Nov 2026 11:31:24 +0800 (CST) From: Hongliang Yang To: linux-usb@vger.kernel.org Cc: Hongliang Yang , Greg Kroah-Hartman , Peter Chen , Pawel Laszczak , Roger Quadros , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Gary Yang , Fugang Duan , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, cix-kernel-upstream Subject: Re: [PATCH v8 2/2] usb: cdns3: Add CIX Sky1 glue driver Date: Fri, 13 Nov 2026 11:31:22 +0800 Message-ID: <20261113033122.1438152-1-hongliang.yang@cixtech.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: References: <20261112022141.4136099-1-hongliang.yang@cixtech.com> <20261112022141.4136099-3-hongliang.yang@cixtech.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SG2PEPF000B66CD:EE_|SE1PPF7C5444CB3:EE_ Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: 5595ac13-ac34-41c8-9b5c-08df419fbbaa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|36860700016|1800799024|23010399003|82310400026|261009223027099003|10067099003|261026140227099003|4143699003|261021121427099003|56012099006|261022113327099003|261022105027099003|261022075727099003|261102123227099003|261028144727099003|261026121527099003|18002099003|22082099003|6133799003; X-Microsoft-Antispam-Message-Info: M8mENAsBv2Jm7ic3d9VFOqNb+2oiQyMLlE3ys0KAh4gHF8NTXb0NDhGt1YjUovmGtZ+Dl7LO3cF/YzJVkecdQcjJQbvbVjt18jyxhlKz6sHa3TpdaifUL2HIwmHvl+TLwtWJ6Gr27W3n9nnPGqqOonkJn9Pi8V11lOUStoWTApEvf5FkfGXUE5JhPCWAU0p9XpO7R7k5IW2FzMfc7ndEWIotQ8dh4yomGNw9XcMgLdEoI3aKnpYmYHND74NCpLmPQMaPfxdX4DZscUmHU40yM7fpEm2uFNGRzmePGACqPMg9Rqo37mjhIdQW0K8UuquWLNPguu712e3LbYgT7flvzcxKyMOTamO9HvlRT9dZw1g/vyMYXm91hA7W4v3azTkoRIkbxt8quKfyMkb2zsZHuNhusRZGX8qxU9Wqr0QaCYm50yi4pH6rCtC4vjy81aggT5x5daMryuO1NQEDNCnkje6lDfp1a0Xz3pxJl2U2HW6+9YXTiZWBViNYhWMzJf9bMDzHOBl6SNIOGzV5vZZsJ5T2OQzplfjirI2mZeNp3ZT70saTRODSwbRZGFZxoToOGCCQGIlYOvwWn3/iZL3zRshCMfopTkkCz4gB0OsIyLR/MMBrcBsGbNrtPpqzUjMxuUfCzB5owIeaPecAtUMO0KJyfg4n3LHjN6y+cmIYJmmNfVLNAsKSBXpmbuCVoJH/Wx8jgBRvIRUrsAc2xVuK2Q== X-Forefront-Antispam-Report: CIP:222.71.101.198;CTRY:CN;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:smtprelay.cixcomputing.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(7416014)(376014)(36860700016)(1800799024)(23010399003)(82310400026)(261009223027099003)(10067099003)(261026140227099003)(4143699003)(261021121427099003)(56012099006)(261022113327099003)(261022105027099003)(261022075727099003)(261102123227099003)(261028144727099003)(261026121527099003)(18002099003)(22082099003)(6133799003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: iXGPzLXhkbKRobYftR+WusIyIeok5j+ABBKoovn75qf2rWFjcZZdTYuw+I0dbCoL+mC1xsFxnDbU/LHY5ba5ciaeTuBXXpRxisrje8ul/i17tqNxBC3Uog88mYg/VAp7xW9RgT/olWwcTHReaA6qWrmapkwuHqPrfNR/8UFcwGeNFvnNm4coE7YMxlSiW94yBKnh0B3pY5mxVMygMQ2wuJCGYjGxrzk0zHdUdxAUNkVgR0NRjbGDpzrjkrxkotECJsYtawvj7S7w2pvrFU6kkYpdXWqrFzvCBgbGW6bX6VIOmwiAUAaULEmw5SN+tdxEtBOIAmYyFUGiwVfwJ537u02/px1or80qGq6Bx7GQKIMvPHJnhrp/QfW3qTLDaIplnDDMNOXOBdrNzojJjeVFQiclN4rwWDLwJY42MF5O/TUgLud/jJJ78Hr9M4hanOhG X-OriginatorOrg: cixtech.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Nov 2026 16:04:01.2368 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5595ac13-ac34-41c8-9b5c-08df419fbbaa X-MS-Exchange-CrossTenant-Id: 0409f77a-e53d-4d23-943e-ccade7cb4811 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=0409f77a-e53d-4d23-943e-ccade7cb4811;Ip=[222.71.101.198];Helo=[smtprelay.cixcomputing.com] X-MS-Exchange-CrossTenant-AuthSource: SG2PEPF000B66CD.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SE1PPF7C5444CB3 All five are real. Fixes go into v9; the binding patch is unaffected. > [Low] missing MFD_SYSCON dependency for USB_CDNSP_SKY1 Confirmed. ARCH_CIX does not select MFD_SYSCON, and without it syscon_regmap_lookup_by_phandle_args() returns -ENOTSUPP, so probe fails with a minimal configuration. v9 adds "select MFD_SYSCON". > [Medium] clock refcount underflow after resume failure Confirmed, and it is not limited to a failed resume: shutting the system down or removing the driver after system suspend, without an intervening resume, reaches cdnsp_sky1_clk_disable_all() and disables the sof and axi clocks a second time. v9 records which clocks are on in a bitmap and routes every user through one idempotent pair, cdnsp_sky1_clk_enable(data, mask) and cdnsp_sky1_clk_disable(data, mask). A clock that is already on is skipped, and the enable error path disables only the clocks that call enabled. CIX_USB_CLK_OFF_NUM goes away; the suspend window is a mask instead. > [Low] PS_PME_En not cleared in cdns_sky1_platform_suspend() Confirmed, the read-modify-write keeps whatever PS_PME_En was left in the register. v9 clears PS_PME_En together with PS_MASK before setting the new power state. You are also right that the core drops the return value. That means -ETIMEDOUT does not prevent the half-suspended state, so v9 restores PS_D0 when the D3 entry times out, as the vendor driver does, and keeps the error return for when the core propagates it. > [Medium] cdns_sky1_pdata leak in cdnsp_sky1_probe() Confirmed. of_platform_bus_create() returns 0 when the child device is not created, so the if (ret) branch after of_platform_populate() never runs. v9 checks the children twice. Before the populate it requires exactly one enabled cdns,usb3 child node, so the auxdata platform data can never be handed to more than one device, which would be a double free in platform_device_release(). After the populate it looks for the created child and, when there is none, frees the platform data and fails probe. > [Medium] unconditional clock gating in cdnsp_sky1_system_suspend() Confirmed, the function contradicts the comment above it. v9 gates the clocks only when both conditions hold: - the child device, which owns the shared wakeup interrupt, does not have wakeup enabled; - AXI_CLOCK_VALID reads 0, that is the controller has stopped using AXI. The second test answers the device/idle role and the D3 entry timeout cases without depending on the role, and it is the same status bit that cdns_sky1_platform_suspend() polls on a successful D3 entry. Best regards, Hongliang Yang