From: phucduc.bui@gmail.com
To: Shengjiu Wang <shengjiu.wang@gmail.com>,
Shengjiu Wang <shengjiu.wang@nxp.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linuxppc-dev@lists.ozlabs.org, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org,
bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH v2 6/6] ASoC: fsl_asrc: Use devm for m2m cleanup
Date: Fri, 13 Nov 2026 12:07:27 +0700 [thread overview]
Message-ID: <20261113050727.14053-7-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20261113050727.14053-1-phucduc.bui@gmail.com>
From: bui duc phuc <phucduc.bui@gmail.com>
Register fsl_asrc_m2m_exit() as a devm action and drop
fsl_asrc_remove(), which has nothing else left to do.
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
sound/soc/fsl/fsl_asrc.c | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c
index 317ce0a5c765..c8db02f16453 100644
--- a/sound/soc/fsl/fsl_asrc.c
+++ b/sound/soc/fsl/fsl_asrc.c
@@ -1267,6 +1267,11 @@ static void fsl_asrc_runtime_suspend_action(void *data)
fsl_asrc_runtime_suspend(dev);
}
+static void fsl_asrc_m2m_exit_action(void *data)
+{
+ fsl_asrc_m2m_exit(data);
+}
+
static int fsl_asrc_probe(struct platform_device *pdev)
{
struct device_node *np = pdev->dev.of_node;
@@ -1479,14 +1484,7 @@ static int fsl_asrc_probe(struct platform_device *pdev)
return ret;
}
- return 0;
-}
-
-static void fsl_asrc_remove(struct platform_device *pdev)
-{
- struct fsl_asrc *asrc = dev_get_drvdata(&pdev->dev);
-
- fsl_asrc_m2m_exit(asrc);
+ return devm_add_action_or_reset(&pdev->dev, fsl_asrc_m2m_exit_action, asrc);
}
static int fsl_asrc_runtime_resume(struct device *dev)
@@ -1648,7 +1646,6 @@ MODULE_DEVICE_TABLE(of, fsl_asrc_ids);
static struct platform_driver fsl_asrc_driver = {
.probe = fsl_asrc_probe,
- .remove = fsl_asrc_remove,
.driver = {
.name = "fsl-asrc",
.of_match_table = fsl_asrc_ids,
--
2.43.0
prev parent reply other threads:[~2026-11-13 5:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 5:07 [PATCH v2 0/6] ASoC: fsl_asrc: Fix probe and resource management issues phucduc.bui
2026-11-13 5:07 ` [PATCH v2 1/6] ASoC: fsl_asrc: Improve probe error handling phucduc.bui
2026-11-13 5:07 ` [PATCH v2 2/6] ASoC: fsl_asrc: Fix handling of deferred spba clock phucduc.bui
2026-11-13 5:07 ` [PATCH v2 3/6] ASoC: fsl_asrc: Fix runtime PM usage count on init failure phucduc.bui
2026-11-13 5:07 ` [PATCH v2 4/6] ASoC: fsl_asrc: Request the IRQ after the device is initialized phucduc.bui
2026-11-13 5:07 ` [PATCH v2 5/6] ASoC: fsl_asrc: Use devm for runtime PM cleanup phucduc.bui
2026-11-13 5:07 ` phucduc.bui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261113050727.14053-7-phucduc.bui@gmail.com \
--to=phucduc.bui@gmail.com \
--cc=Xiubo.Lee@gmail.com \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=shengjiu.wang@gmail.com \
--cc=shengjiu.wang@nxp.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®