From: Yuanhe Shu <xiangzao@linux.alibaba.com>
To: bp@alien8.de
Cc: dave.hansen@linux.intel.com, jarkko@kernel.org, tglx@kernel.org,
mingo@redhat.com, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-sgx@vger.kernel.org,
linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
challvy.tee@gmail.com, xiangzao@linux.alibaba.com
Subject: Re: [PATCH v2] x86/crash: Disable SGX in the kdump kernel
Date: Fri, 13 Nov 2026 13:57:34 +0800 [thread overview]
Message-ID: <20261113055734.3976582-1-xiangzao@linux.alibaba.com> (raw)
In-Reply-To: <20261113041516.GAavaO1CiqZ3otjh3I@fat_crate.local>
On 11/13/26 04:15, Borislav Petkov wrote:
> First of all this cmdline param naming is maximally unintuitive and why does
> it even exist in the first place?
Thanks for the review.
elfcorehdr= is passed by kexec, so every capture kernel boots with it
on the command line. We use it to detect the capture kernel, the same
way is_kdump_kernel() does: that helper checks
elfcorehdr_addr != ELFCORE_ADDR_MAX, and this parameter is what sets
the address.
It also keeps the disable logic in kdump-specific code in the x86
path, as suggested in the v1 review.
We looked at two places: adding an is_kdump_kernel() check in
setup_arch(), and this handler. We chose the latter to keep the
disable logic in kdump code rather than the generic boot path. As an
early parameter, it clears SGX before alternatives are patched.
--
Yuanhe
next prev parent reply other threads:[~2026-11-13 5:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 3:50 Yuanhe Shu
2026-11-13 4:15 ` Borislav Petkov
2026-11-13 5:57 ` Yuanhe Shu [this message]
2026-11-13 6:18 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261113055734.3976582-1-xiangzao@linux.alibaba.com \
--to=xiangzao@linux.alibaba.com \
--cc=bp@alien8.de \
--cc=challvy.tee@gmail.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jarkko@kernel.org \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®