From: Vladislav Zaharov <vladazaharova2018@gmail.com>
To: dakr@kernel.org, jhubbard@nvidia.com
Cc: acourbot@nvidia.com, aliceryhl@google.com, ttabi@nvidia.com,
gary@garyguo.net, nova-gpu@lists.linux.dev,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, vladazaharova2018@gmail.com
Subject: [PATCH v7 0/4] gpu: nova-core: retain the GSP-RM log buffers
Date: Fri, 13 Nov 2026 14:53:13 +0700 [thread overview]
Message-ID: <20261113075317.934264-1-vladazaharova2018@gmail.com> (raw)
The GSP-RM log buffers are exposed through debugfs, but they go away
when the GPU is unbound, including when probe() fails, which is when
they are most useful.
Patch 1 moves the debugfs root into the module data, which also fixes
the root being leaked when the driver registration fails. Patch 2 moves
the log buffer code into its own file. Patch 3 adds a gsp_keep_logs
module parameter that keeps a copy of the buffers after unbind. Patch 4
drops the completed item from todo.rst.
Changes since v6:
- drop the "retained/" directory: the copies are exposed in the same
files as the live buffers, and are dropped when the GPU is bound
again (Danilo, John)
- split the code move out of the retain patch (Alexandre)
- move DebugfsData into debugfs.rs, make the accessor
NovaCoreModule::debugfs_data(), reword the comments around
DEBUGFS_DATA as invariants, add a Fixes: tag (Alexandre, Danilo)
- shorten the commit messages and comments (Alexandre)
- rebase onto current drm-rust-next
The code and the commit messages were drafted with an LLM coding
assistant and reviewed by me. Each patch builds on its own, and the
series was tested on a GB203:
- without gsp_keep_logs nothing changes;
- with gsp_keep_logs=1, <BDF>/{loginit,logintr,logrm} keep the full
64 KiB of each buffer after unbind, show the live buffers again
after the next bind, and a second unbind replaces the copies;
- with a failure injected after the GSP has booted, probe() fails
with -EINVAL and the logs of that attempt are still readable;
- with a failure injected into the driver registration, the module
fails to load and leaves no debugfs directory behind;
- 40 load/bind/unbind/unload cycles use no more memory with
gsp_keep_logs=1 than without it.
v6: https://lore.kernel.org/nova-gpu/20261014154554.231015-1-vladazaharova2018@gmail.com/
Vladislav Zaharov (4):
gpu: nova-core: move the debugfs root into the module data
gpu: nova-core: gsp: move the log buffers into their own file
gpu: nova-core: gsp: retain the GSP-RM log buffers after unbind
Documentation: nova: remove completed GSP log buffer task
Documentation/gpu/nova/core/todo.rst | 12 --
drivers/gpu/nova-core/debugfs.rs | 44 ++++++
drivers/gpu/nova-core/gsp.rs | 100 +++---------
drivers/gpu/nova-core/gsp/logbuffer.rs | 204 +++++++++++++++++++++++++
drivers/gpu/nova-core/nova_core.rs | 68 ++++++---
5 files changed, 311 insertions(+), 117 deletions(-)
create mode 100644 drivers/gpu/nova-core/debugfs.rs
create mode 100644 drivers/gpu/nova-core/gsp/logbuffer.rs
base-commit: 0ff9e5b9ff6736c37593cd7db89f4593ec4f8e86
--
2.56.0
next reply other threads:[~2026-11-13 7:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 7:53 Vladislav Zaharov [this message]
2026-11-13 7:53 ` [PATCH v7 1/4] gpu: nova-core: move the debugfs root into the module data Vladislav Zaharov
2026-11-13 7:53 ` [PATCH v7 2/4] gpu: nova-core: gsp: move the log buffers into their own file Vladislav Zaharov
2026-11-13 7:53 ` [PATCH v7 3/4] gpu: nova-core: gsp: retain the GSP-RM log buffers after unbind Vladislav Zaharov
2026-11-13 20:34 ` Danilo Krummrich
2026-11-13 7:53 ` [PATCH v7 4/4] Documentation: nova: remove completed GSP log buffer task Vladislav Zaharov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261113075317.934264-1-vladazaharova2018@gmail.com \
--to=vladazaharova2018@gmail.com \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nova-gpu@lists.linux.dev \
--cc=ttabi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®