From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=8.221.36.217 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794558222; b=MqMF+NM0UlYvUrDDf8I31s95dYNNr+m+xmM8uFLVzTHFS6wVRZJ+vSApKiAkkviLYqtd PgE2b7XfCe51Nr+ePu8w7iOlw8xpvCHpc8pnuRztnlJOdC+j4xAbNVAd+TxuFPR3B7MSl h0WLWXwt/+lYHseEdPVKFbwbqFkzM8CMa2xBwGnKNw8glo/81stpWrsvDEiTMKRhKz8cQ 0MH/i5RrXLKAf8hPCfqaBcPnK8o3BM8u8yGdxVgw3QpHmtcnewVOn5Uh36OgiOTnLt+1l BhyIKWVKUGjtvejV+hTyT2UIROkazpfeZ3ZwJMPgaa0E3SUzveJgDRlMYNFXOI83GlQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794558222; h=DMARC-Filter:Received:From:To:Cc:Subject:Date:Message-Id:X-Mailer: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding: X-HM-Tid:X-HM-MType:X-HM-Spam-Status:DKIM-Signature; bh=IjC/8t2i/kN8GWSD3FIAe1B/UxMrwa2ZYacA7/WfeWA=; b=V08sO9+GA6ffkGgShqQ0uRDGKK4OLMDh6duw9Vku+Vpn6RTM7Qd4s9/Md/xzkzKd7zYc O4CoOFmyGbQuOP70Umf9XD+1ZA9/OI63nZCeZLC7CcjhqRMhZ01bko63uTSlIBiXeZXsv 6BVBg3MHvXccBV/LN5v4flAKSMojrudw/RJMQmLjO7LTueq6iIE2LQcTr5gME500GloWf /wp/EJlKOQg/r7RfYJKi0wdTL1sw2V9cPhpI0w/2BEkOVIdueTDpDgv4mVAU9tkyPwm6m a9T0fUtrxOuM8KQrrhi20rGOM4+TI+PmBUaX0idTGQsa5r1JL4L5FntJBQSru56Db3Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass header.d=rock-chips.com header.i=@rock-chips.com header.a=rsa-sha256 header.s=default header.b=AcSvs2CT; arc=none smtp.remote-ip=8.221.36.217 Received: from mail-m822136217.xmail.ntesmail.com (mail-m822136217.xmail.ntesmail.com [8.221.36.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 387DC60A6F7E; Fri, 13 Nov 2026 08:23:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 387DC60A6F7E Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.a=rsa-sha256 header.s=default header.b=AcSvs2CT Received: from zyb-HP-ProDesk-680-G2-MT.. (unknown [61.154.14.86]) by smtp.qiye.163.com (Hmail) with ESMTP id 54921be54; Fri, 13 Nov 2026 16:23:29 +0800 (GMT+08:00) From: Damon Ding To: Andrzej Hajda , Neil Armstrong , Robert Foss , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Heiko Stuebner , Sandy Huang , Andy Yan Cc: Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Dmitry Baryshkov , Marek Szyprowski , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Damon Ding Subject: [PATCH v6 10/18] drm/bridge: analogix_dp: Use platform-specific HPD detection scheme Date: Fri, 13 Nov 2026 16:22:57 +0800 Message-Id: <20261113082305.541652-11-damon.ding@rock-chips.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20261113082305.541652-1-damon.ding@rock-chips.com> References: <20261113082305.541652-1-damon.ding@rock-chips.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-HM-Tid: 0aa1d4012d9903a8kunm073aab0481aa9 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWRgWCB1ZQUpXWS1ZQUlXWQ8JGhUIEh9ZQVlDH0hPVh1DGEJDQhhJHUNPGFYVFA kWGhdVEwETFhoSFyQUDg9ZV1kYEgtZQVlNSlVKTk9VSk9VQ01ZV1kWGg8SFR0UWUFZT0tIVUpLSE pKQk1VSktLVUpCWQY+ DKIM-Signature: a=rsa-sha256; b=AcSvs2CTFKgmrK5Ji3jabLkJa58RntjqmsMIiQcH/mN8C75VZj2mSjnGtB6KOD7X/BsCaAtcCS5UR0IrtMjsJhlhAq5PuaGz2Z1moViFcj6gl2LQpWIZ6D65zRBgbrf3TPac5Yy0mAqCkA1X1tMuEOfgH/w5Ytu5Ja/qPi7hUAc=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=IjC/8t2i/kN8GWSD3FIAe1B/UxMrwa2ZYacA7/WfeWA=; h=date:mime-version:subject:message-id:from; The Analogix DP controller provides two sets of interrupt sources for hotplug detection: HOTPLUG_CHG for any HPD level change, and the PLUG/HPD_LOST pair for connect/disconnect transitions respectively. On Rockchip platforms, configure the HPD deglitch filter and use HOTPLUG_CHG interrupt for hotplug detection. Other platforms retain the original PLUG + HPD_LOST scheme with unchanged deglitch values. Move the HPD deglitch configuration into analogix_dp_reset() so that platform-specific values are set alongside the existing register defaults in a single location. Update the threaded IRQ handler to check the corresponding interrupt flag based on platform type. Tested-by: Heiko Stuebner Tested-by: Marek Szyprowski Signed-off-by: Damon Ding --- Changes in v2: - Move ANALOGIX_DP_HPD_DEGLITCH_L/ANALOGIX_DP_HPD_DEGLITCH_H configs to analogix_dp_reset(). Changes in v3: - Modify the commit msg. - Replace macro HPD_IRQ with HPD_IRQ_ALL. Changes in v4: - Add Tested-by tag. Changes in v6: - Add Tested-by tag. --- .../drm/bridge/analogix/analogix_dp_core.c | 9 ++++++-- .../gpu/drm/bridge/analogix/analogix_dp_reg.c | 22 ++++++++++++++++--- 2 files changed, 26 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index 97a943f29cf1..db0aefaf6754 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -717,13 +717,18 @@ static irqreturn_t analogix_dp_irq_thread(int irq, void *arg) { struct analogix_dp_device *dp = arg; u32 irq_type; + bool hpd_detected; irq_type = analogix_dp_get_irq_type(dp); if (irq_type) analogix_dp_clear_hotplug_interrupts(dp, irq_type); - if (irq_type & DP_IRQ_TYPE_HP_CABLE_IN || - irq_type & DP_IRQ_TYPE_HP_CABLE_OUT) { + if (!dp->hpd_gpiod && analogix_dp_is_rockchip(dp->plat_data->dev_type)) + hpd_detected = irq_type & DP_IRQ_TYPE_HP_CHANGE; + else + hpd_detected = (irq_type & DP_IRQ_TYPE_HP_CABLE_IN) || + (irq_type & DP_IRQ_TYPE_HP_CABLE_OUT); + if (hpd_detected) { dev_dbg(dp->dev, "Detected cable status changed!\n"); if (dp->drm_dev) drm_helper_hpd_irq_event(dp->drm_dev); diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c index 0f1406e4a5d3..025da25463a8 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c @@ -160,8 +160,13 @@ void analogix_dp_reset(struct analogix_dp_device *dp) writel(0x0, dp->reg_base + ANALOGIX_DP_PKT_SEND_CTL); writel(0x0, dp->reg_base + ANALOGIX_DP_HDCP_CTL); - writel(0x5e, dp->reg_base + ANALOGIX_DP_HPD_DEGLITCH_L); - writel(0x1a, dp->reg_base + ANALOGIX_DP_HPD_DEGLITCH_H); + if (analogix_dp_is_rockchip(dp->plat_data->dev_type)) { + writel(0x80, dp->reg_base + ANALOGIX_DP_HPD_DEGLITCH_L); + writel(0xbb, dp->reg_base + ANALOGIX_DP_HPD_DEGLITCH_H); + } else { + writel(0x5e, dp->reg_base + ANALOGIX_DP_HPD_DEGLITCH_L); + writel(0x1a, dp->reg_base + ANALOGIX_DP_HPD_DEGLITCH_H); + } writel(0x10, dp->reg_base + ANALOGIX_DP_LINK_DEBUG_CTL); @@ -188,7 +193,18 @@ void analogix_dp_config_interrupt(struct analogix_dp_device *dp) writel(0, dp->reg_base + ANALOGIX_DP_COMMON_INT_MASK_2); writel(0, dp->reg_base + ANALOGIX_DP_COMMON_INT_MASK_3); - analogix_dp_unmute_hpd_interrupt(dp, HPD_IRQ_ALL); + /* + * Either HOTPLUG_CHG interrupt or PLUG + HPD_LOST interrupt + * pair can be used to implement hotplug detection. + * + * On Rockchip platforms, configuring HPD deglitch to 2ms and + * using HOTPLUG_CHG interrupt for hotplug detection is proven + * as a better solution via engineering verification. + */ + if (analogix_dp_is_rockchip(dp->plat_data->dev_type)) + analogix_dp_unmute_hpd_interrupt(dp, DP_IRQ_TYPE_HP_CHANGE); + else + analogix_dp_unmute_hpd_interrupt(dp, HPD_IRQ_ALL); } /* -- 2.34.1