From: "Oscar Alejandro Sánchez Lucero" <aleszlucero@gmail.com>
To: Priyanshu Singh <singhpriyanshu9838@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: octeon: fix asymmetric output buffer pool accounting
Date: Fri, 13 Nov 2026 04:15:54 -0600 [thread overview]
Message-ID: <20261113101554.68060-1-aleszlucero@gmail.com> (raw)
In-Reply-To: <20261113091847.117705-1-singhpriyanshu9838@gmail.com>
On Fri, Nov 13, 2026 at 09:18:47AM +0000, Priyanshu Singh wrote:
> In cvm_oct_configure_common_hw(), when CVMX_FPA_OUTPUT_BUFFER_POOL differs
> from CVMX_FPA_PACKET_POOL, 1024 output buffers are allocated and added to
> the hardware Free Pool Allocator (FPA) pool. However, in cvm_oct_probe()
> (err_tx:) and in cvm_oct_remove(),cvm_oct_mem_empty_fpa() is called with
> 128 instead of 1024 as the expected buffer count.
Hi Priyanshu,
A couple of quick comments:
Was this found via static analysis or code inspection? Since this changes
runtime buffer accounting rather than just coding style, it would be helpful
to mention how it was verified (e.g., compile-tested only) in the commit
message. Also, there is a missing space after the comma in
cvm_oct_remove(),cvm_oct_mem_empty_fpa().
Best regards,
Alejandro Lucero
prev parent reply other threads:[~2026-11-13 10:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 9:18 Priyanshu Singh
2026-11-13 10:15 ` Oscar Alejandro Sánchez Lucero [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261113101554.68060-1-aleszlucero@gmail.com \
--to=aleszlucero@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=singhpriyanshu9838@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®