From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: broonie@kernel.org
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com
Subject: [PATCH 0/2] ASoC: cs35l56: Series to stop writing ASP registers the driver doesn't own
Date: Fri, 13 Nov 2026 11:29:33 +0000 [thread overview]
Message-ID: <20261113112935.2926431-1-rf@opensource.cirrus.com> (raw)
The driver was writing to the ASP registers on systems where it didn't own
control of those registers. These two patches prevent that.
There is more detail in the commit messages of why this problem exists, but
the summary is that these registers are usually owned by the firmware
and/or a secondary (or tertiary) host using the I2C/SPI control interfaces.
Richard Fitzgerald (2):
ASoC: cs35l56: Only write ASP1TXn registers when widget is powered-up
ASoC: cs35l56: Fix unwanted writes to ASP config registers
include/sound/cs35l56.h | 2 +-
sound/soc/codecs/cs35l56-shared.c | 38 +-------
sound/soc/codecs/cs35l56.c | 147 ++++++++++++++++++++++++------
sound/soc/codecs/cs35l56.h | 1 +
4 files changed, 124 insertions(+), 64 deletions(-)
--
2.47.3
next reply other threads:[~2026-11-13 11:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 11:29 Richard Fitzgerald [this message]
2026-11-13 11:29 ` [PATCH 1/2] ASoC: cs35l56: Only write ASP1TXn registers when widget is powered-up Richard Fitzgerald
2026-11-13 11:29 ` [PATCH 2/2] ASoC: cs35l56: Fix unwanted writes to ASP config registers Richard Fitzgerald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261113112935.2926431-1-rf@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®