From: SJ Park <sj@kernel.org>
To: Enze Li <lienze@kylinos.cn>
Cc: SJ Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>,
Randy Dunlap <rdunlap@infradead.org>,
Shuah Khan <skhan@linuxfoundation.org>,
damon@lists.linux.dev, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 4/4] Docs/mm/damon/design: update for DAMON_FILTER_TYPE_ACTIVE
Date: Fri, 13 Nov 2026 06:43:14 -0800 [thread overview]
Message-ID: <20261113144314.97829-1-sj@kernel.org> (raw)
In-Reply-To: <db00f01d-c9c1-4207-ae7d-9dd77cf5afa7@kylinos.cn>
On Fri, 13 Nov 2026 17:54:37 +0800 Enze Li <lienze@kylinos.cn> wrote:
> Hi SJ,
>
> On 11/13/26 1:17 PM, SJ Park wrote:
> > Update DAMON design document for the newly added LRU-activeness DAMON
> > filter type.
> >
> > Signed-off-by: SJ Park <sj@kernel.org>
> > ---
> > Documentation/mm/damon/design.rst | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst
> > index 8440c4954090e..b676be6971589 100644
> > --- a/Documentation/mm/damon/design.rst
> > +++ b/Documentation/mm/damon/design.rst
> > @@ -302,6 +302,7 @@ filter types. Currently below filter types are supported.
> > - ``pgidle_set``: Matches if the page for the memory is marked as access-idle.
> > - ``hugepage_size``: Matches if the page for the memory is a part of a hugepage
> > of a given size range.
> > +- ``active``: Same to that for DAMOS filters.
>
> This reads a bit awkward to me. How about:
>
> "Same as that for DAMOS filters."
>
> The ``anon`` and ``memcg`` entries above use the same wording, so
> it would be nice to fix those at the same time.
>
> WDYT?
Makes sense to me, thank you for sharing the finding, Enze! I also find more
"same to" usages in the doc. Would you like to send a patch for fixing those
at once?
Thanks,
SJ
[...]
prev parent reply other threads:[~2026-11-13 14:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 5:17 [PATCH 0/4] mm/damon: add lru-active probe filter type SJ Park
2026-11-13 5:17 ` [PATCH 1/4] mm/damon/api: define DAMON_FILTER_TYPE_ACTIVE SJ Park
2026-11-13 5:17 ` [PATCH 2/4] mm/damon/ops-common: implement DAMON_FILTER_TYPE_ACTIVE operation SJ Park
2026-11-13 5:17 ` [PATCH 3/4] mm/damon/sysfs: support LRU-activeness based DAMON filter setup SJ Park
2026-11-13 5:17 ` [PATCH 4/4] Docs/mm/damon/design: update for DAMON_FILTER_TYPE_ACTIVE SJ Park
2026-11-13 9:54 ` Enze Li
2026-11-13 14:43 ` SJ Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261113144314.97829-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=damon@lists.linux.dev \
--cc=lienze@kylinos.cn \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®