From: Mehmet Fide <mehmet.fide@gmail.com>
To: Luka Gejak <luka.gejak@linux.dev>,
Zong-Zhe Yang <kevin_yang@realtek.com>
Cc: Ping-Ke Shih <pkshih@realtek.com>,
Tzu-En Huang <tehuang@realtek.com>,
Yan-Hsuan Chuang <yhchuang@realtek.com>,
Kalle Valo <kvalo@kernel.org>,
Stanislaw Gruszka <sgruszka@redhat.com>,
Brian Norris <briannorris@chromium.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
mehmet.fide@screeningeagle.com
Subject: Re: [PATCH rtw-next 1/3] wifi: rtw88: free the reserved pages of an interface on firmware recovery
Date: Fri, 13 Nov 2026 18:24:49 +0100 [thread overview]
Message-ID: <20261113172449.3313425-1-mehmet.fide@gmail.com> (raw)
In-Reply-To: <5FA04DA4-863E-46D3-A993-5F3C074ABC37@linux.dev>
On Fri, 13 Nov 2026, Luka Gejak wrote:
> Maybe rtw_fw_update_beacon_work() could skip the download while
> RTW_FLAG_RESTARTING is set? The reconfig downloads the beacon again for
> BSS_CHANGED_BEACON anyway.
On Fri, 13 Nov 2026, Zong-Zhe Yang wrote:
> How about adding a flag to indicate if this rtwvif has been init-ed or not ?
> If init-ed and rtw_ops_add_interface() again, call rtw_remove_rsvd_page() first.
Thank you both. I could reproduce it: with a test build that queues the
work right after rtw_enter_ips() in the recovery, v1 gives the "Should
not have an empty reserved page" warning on an RTL8822CE with an AP
interface.
I will take the RTW_FLAG_RESTARTING check for v2, as the flag already
covers the time from the reset to the end of the reconfiguration. With
it the same test build does not warn.
Best regards,
Mehmet
next prev parent reply other threads:[~2026-11-13 17:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 21:32 [PATCH rtw-next 0/3] wifi: rtw88: three fixes around the " Mehmet Fide
2026-11-11 21:32 ` [PATCH rtw-next 1/3] wifi: rtw88: free the reserved pages of an interface on " Mehmet Fide
2026-11-13 6:54 ` Luka Gejak
2026-11-13 10:21 ` Zong-Zhe Yang
2026-11-13 16:32 ` Luka Gejak
2026-11-13 17:24 ` Mehmet Fide [this message]
2026-11-11 21:32 ` [PATCH rtw-next 2/3] wifi: rtw88: report the frames purged from the TX report queue Mehmet Fide
2026-11-13 6:55 ` Luka Gejak
2026-11-11 21:32 ` [PATCH rtw-next 3/3] wifi: rtw88: reset the stations outside of RCU on firmware recovery Mehmet Fide
2026-11-13 6:57 ` Luka Gejak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261113172449.3313425-1-mehmet.fide@gmail.com \
--to=mehmet.fide@gmail.com \
--cc=briannorris@chromium.org \
--cc=kevin_yang@realtek.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luka.gejak@linux.dev \
--cc=mehmet.fide@screeningeagle.com \
--cc=pkshih@realtek.com \
--cc=sgruszka@redhat.com \
--cc=tehuang@realtek.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®