Re: [PATCH v4 2/2] leds: is31f132xx: Add support for is31fl3206

[Lee Jones <lee@kernel.org>]

On Fri, 13 Nov 2026, Flávio Amieiro wrote:

> 
> Thank you very much for the review.
> 
> > Lee Jones <lee@kernel.org> writes:
> > --- checkpatch.pl (1 issue) ---
> > Line 83: WARNING: DT compatible string "issi,is31fl3206" appears un-documented -- check ./Documentation/devicetree/bindings/
> > ----------------------------------
> >
> 
> This is documented in the first patch of the series, as requested as
> part of the review for v1[1].
> 
> > On Wed, 28 Oct 2026, Flavio Amieiro wrote:
> >
> >> + * @enable_bit_offset_in_led_control_reg determines the offset of the
> >> + * enable bits from the least significant bit of the LED control
> >
> > Make sure you run W=1, particularly when changing Kerneldoc.
> >
> 
> I checked and get no warnings with `make W=1
> ./drivers/leds/leds-is31fl32xx.o`, `./scripts/checkpatch.pl --strict`,
> and `./scripts/kernel-doc -N drivers/leds/leds-is31fl32xx.c`. Am I
> missing some other check here?

Ah, it's because the first one is spelt correctly.

This mention however, is not:

@enable_bit_offset_in_led_control_reg

> Again, thank you very much for the review. I will address the other
> points and send a v5 as soon as possible.
> 
> Best regards,
> Flávio Amieiro
> 
> 
> [1]: https://lore.kernel.org/all/20261013-jolly-salamander-of-tact-7cf46e@quoll/

-- 
Lee Jones