mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mehmet Fide <mehmet.fide@gmail.com>
To: Luka Gejak <luka.gejak@linux.dev>
Cc: Ping-Ke Shih <pkshih@realtek.com>,
	Bitterblue Smith <rtl8821cerfe2@gmail.com>,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	mehmet.fide@screeningeagle.com
Subject: Re: [PATCH rtw-next v10 3/3] wifi: rtw88: time the countdown downloads from the TBTT
Date: Fri, 13 Nov 2026 23:05:46 +0100	[thread overview]
Message-ID: <20261113220546.826710-1-mehmet.fide@gmail.com> (raw)
In-Reply-To: <1D396970-35B7-4B0B-82E9-24B523AD69C2@linux.dev>

Hi Luka,

Thanks for the review.

> Could you check the beacon spacing in a capture with beacon_int=200? If
> it stays at 100 TU, that is a separate bug. Would you be willing to send
> a fix for that too?

You are right. With beacon_int 200 and 50 in hostapd, the beacons of an
RTL8822CE, RTL8822CU, RTL8822BU and RTL8821CU stay 102.4 ms apart on
the air, while the beacon interval field in them says 200 and 50. The
register reads 0x00640064 in every case. I will send a fix for it as a
separate patch.

> rtw88 sets BIT_DIS_TSF_UDT for AP and IBSS and has no reset_tsf op, so I
> think this mostly catches a download that ran more than a beacon
> interval late, not a TSF jump. Maybe say that in the comment?
>
> The start case computes the same next TBTT, so it could share this
> branch:

Yes to both. I will reword the comment and let the start case share
the branch in v11.

Best regards,
Mehmet

      reply	other threads:[~2026-11-13 22:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 12:15 [PATCH rtw-next v10 0/3] wifi: rtw88: channel switch in AP mode Mehmet Fide
2026-11-11 12:15 ` [PATCH rtw-next v10 1/3] wifi: rtw88: download the beacon the reserved page was built with Mehmet Fide
2026-11-11 12:15 ` [PATCH rtw-next v10 2/3] wifi: rtw88: support channel switch in AP mode Mehmet Fide
2026-11-12 11:46   ` Luka Gejak
2026-11-13 22:05     ` Mehmet Fide
2026-11-11 12:15 ` [PATCH rtw-next v10 3/3] wifi: rtw88: time the countdown downloads from the TBTT Mehmet Fide
2026-11-12 11:50   ` Luka Gejak
2026-11-13 22:05     ` Mehmet Fide [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261113220546.826710-1-mehmet.fide@gmail.com \
    --to=mehmet.fide@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luka.gejak@linux.dev \
    --cc=mehmet.fide@screeningeagle.com \
    --cc=pkshih@realtek.com \
    --cc=rtl8821cerfe2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®