From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.210.173 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794658733; b=OYuXYUhRl0PQp5Rhkp3m9eWxqF9aTS7c69JWFLalqob5F3pgQ74Y+Xq3tSEV0koc/HIF xITzE/rnKcfWMUjZA88VHnKRg2ttdBMffGPT+M+9vv1vDSnOv/Koh+hGM1d9hYvo/ma2g eQJdEvhqsvDVCDB3IVc/WLjEJUMPhQVFyDjKqI4e6kXnXBeP+IDxx8m+wR26XZFiQ5vz4 ZYNUEDUIZtArvtT8qD+kQHyi8+DCB+P6gtHOJDXXbdrhRXhp8Og+VkO6AE2GTjLcpQEPg L/VwsgK1y8OV3dTcWDGTqh0gnL/b5NB/kTHQEFb+ScQFIF2SizxFSScKqvT3ZUbFGVw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794658733; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:Date:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding: Message-Id:References:In-Reply-To:To:Cc:X-Mailer; bh=8aCyDVugFTgDmxcEvIKcJWse+PFQb7Di/86YRfNsvCI=; b=vw1ASOiPb+JcwILRhExm4uP4L+ULgwlzFKJW5Vp3vtRFt24qqY3lAFb2BDnr2THWSKDr ge41AAKD5VJLs7hGGjBUM+PBFPgMY7LNBqRTAOCnEoZ5hzYN1LBPDI0mGDnlRI1+PRDl3 bgOzglxxJFsOmg6ct1xchdQgTDSfrGcqURDz2zrfgFPETwYBtNbWbIoPa3DsceWa+6sNO YtiSDmrqc38jfuXy/qMBzpPSi7o2p+wEdtfId9vXVR62HSo0TTb/RxBgRceSYghB0xUXO ZCqj5Plml3xQ5GBzmdjKBx9XNxLRYh9DyfngjOlrnAd9BbbKN7494xM6BRv0CtxFx9Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=ZY3b4uOS; arc=none smtp.remote-ip=209.85.210.173 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A2B0606A334 for ; Sat, 14 Nov 2026 12:18:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 1A2B0606A334 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=ZY3b4uOS Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-8b67f25e6e1so975708b3a.0 for ; Sat, 14 Nov 2026 04:18:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794658732; x=1795263532; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8aCyDVugFTgDmxcEvIKcJWse+PFQb7Di/86YRfNsvCI=; b=ZY3b4uOSYvGz9nNcu1qwN/od2PeKMgIh+NV0BB2dFBwYawl8/E5HP46kuhu8OzpoPD o/5jQDYpkp2mxVM95AHfxs8uc2QGWKy05b2DAXCNarRN1SsRPD9z1ptc94kdKlxh5XI4 KUgJtwKI1ilBrkGWXepRoHRQpMmHxTCkbygrkELMU8ZDF1VnrmV+6qV3z8Rb/XgGnODa wxKK9O3jUFhzq6l4+U2DLkwqtzPmfY0KR2y1wCZMr9g2FwcWMAKTHBauFzb340w24Ath p5zMobbDqGzUNnBKxRshLt5wR1xDK6rL8oYgFeRnatqTwLxmkWR5fo37gKm9IToyf5Vm EF/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794658732; x=1795263532; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=8aCyDVugFTgDmxcEvIKcJWse+PFQb7Di/86YRfNsvCI=; b=DFCd3ZXhoYZhbcGv+W1A6UEOsr9FZNULhdeRpxfcOLL/yCH8SMahkuae4LTcpDfKLs vDC0uTQDmViFzq+b3Rg2U3qMqn7cpzooSS4QX1wbTKkU+l63/aPUi3hwDgdWdOT17zrr pgfVPw7vN9MPVel6Adb8ea8UXiyj0R3s4GAVMNDLbNvziV3k/nMZS/Wy/bZBLLCI+wBN oqGvckEgIHesVQyK+TxlcRqIUvzIMewCCx2I7um4+uDNV4iSW2SV9btjNewfuLfb+ocV FkZIurantWJQvynPXj/DCV2tz22c6B65MmYDlNQ1UkPOPI+m8oXMMCqMHrnRCH5TKPll xCeA== X-Forwarded-Encrypted: i=1; AL+hErFMBJ2XNpbWqylDjlVZUDcjiMk2W3aLUZUE0oo3uzSHRN6jN2Vp+v4JQBxaBpMA0jvAFC8PCKFJmqIhIVw=@vger.kernel.org X-Gm-Message-State: APuU4Z+bAH4eooFG6LNe37q7p3T96ozXInOKaxxQ9rLvyc+1Hwgc6s/w iamW6FI+WxTra2cTUcnv8sxcp2FDAJUxB/DAkBm5f0AfD8AufAHx7BMs X-Gm-Gg: AYBFou2Wsh+sqUvIi+QY/NNbcpMWArfZx/Bf+AXWUrgycm7ZFnm91vABCrzDLbGwrHN CEAcVTHqEm0Bf6431uN0l3EsB4AZ3v52COehvwOI2NfLHXqoGSIYYo8IwT6M/rxZwlIngZMKPDr x+fdOJR8Q4Otn8iK2H8YP57PUcOp5tFkZ8hdw81SSuobGTlhiEHrtSdKql+87sAf9JMapE9NyB0 yzqH8a+0usseAUOvbx6fj/58jZMqGvHmQU1hhc842oCS3kmc91FgP6S0jGk/x9/ZMcLcuEtUHYv 19ug86p/irmc6tKoKijXxV7j7lIUbtfPF1uobf7wk0HkK5AraBkqidV8YQkfADBLtwSRj5c4Yg9 p461oHn9pAWud+JluS/f3rqwPr9qCQDbGM6TIRV0gFR/mdld4hKJVDq6/4jBstV4vLSJGR6fAWi TG7PS9MbUfNatSNs+NZeUa7Kd6lcJ0Xd+sTpVYXLy5444yP+QAIHEoG7ax8XL8MFCjv+WFo0+8A Ka4e8jwSaOlAK3FH3ocf+35SL1jtalIdSgJVeKlEFYAcdMPuLFI2T+OGJHifC8wIAlA+pTBaB// Mi/UAGpW262LZrex4V1F7AjI6z96GToj9kFFtCnR4mIDMwVpa9gU+jy70PQIFL2PqG80HwA/Lr7 VpO/FcySLmzFB2n1NzTTvPqRSOllExtbMSS9FZ8G+uRopqDVAmkhlzKWXT9bA5tF2DELBa2y6zY AfCw== X-Received: by 2002:a05:6a21:4d17:b0:3f9:a6b6:e173 with SMTP id adf61e73a8af0-3f9a6b6e4b9mr771041637.26.1794658732403; Sat, 14 Nov 2026 04:18:52 -0800 (PST) Received: from [169.254.3.1] ([143.248.188.96]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8bececcca19sm2094389b3a.4.2026.11.14.04.18.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Nov 2026 04:18:52 -0800 (PST) From: SeungJong Ha Date: Sat, 14 Nov 2026 21:18:23 +0900 Subject: [PATCH net-next v2 1/3] rust: net: phy: drop read_mmd and write_mmd from Driver X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261114-exp-phy-rs-maybelocked-v2-1-19a4dd658b6b@gmail.com> References: <20261114-exp-phy-rs-maybelocked-v2-0-19a4dd658b6b@gmail.com> In-Reply-To: <20261114-exp-phy-rs-maybelocked-v2-0-19a4dd658b6b@gmail.com> To: FUJITA Tomonori , Trevor Gross , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , =?utf-8?q?Onur_=C3=96zkan?= , Andrew Lunn , Heiner Kallweit , Russell King Cc: netdev@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, SeungJong Ha X-Mailer: b4 0.15.2 The read_mmd and write_mmd callbacks hand the driver a `&mut Device` whose SAFETY comment says PHYLIB holds `phy_device->lock`. It does not have to: __phy_read_mmd() and __phy_write_mmd() call them with the MDIO bus lock held but not necessarily `phy_device->lock`, e.g. from phy_read_mmd() in a hwmon read. The register accessors on `Device` take the bus lock again, so using them there would deadlock. No Rust driver implements these callbacks, and none has since they were added with the abstraction. Drop them until there is a user and a way to express the MDIO bus lock context. Signed-off-by: SeungJong Ha --- rust/kernel/net/phy.rs | 58 -------------------------------------------------- 1 file changed, 58 deletions(-) diff --git a/rust/kernel/net/phy.rs b/rust/kernel/net/phy.rs index c4e7b1d6c6f4..7ca3f2329e6a 100644 --- a/rust/kernel/net/phy.rs +++ b/rust/kernel/net/phy.rs @@ -417,44 +417,6 @@ impl Adapter { T::match_phy_device(dev).into() } - /// # Safety - /// - /// `phydev` must be passed by the corresponding callback in `phy_driver`. - unsafe extern "C" fn read_mmd_callback( - phydev: *mut bindings::phy_device, - devnum: i32, - regnum: u16, - ) -> i32 { - from_result(|| { - // SAFETY: This callback is called only in contexts - // where we hold `phy_device->lock`, so the accessors on - // `Device` are okay to call. - let dev = unsafe { Device::from_raw(phydev) }; - // CAST: the C side verifies devnum < 32. - let ret = T::read_mmd(dev, devnum as u8, regnum)?; - Ok(ret.into()) - }) - } - - /// # Safety - /// - /// `phydev` must be passed by the corresponding callback in `phy_driver`. - unsafe extern "C" fn write_mmd_callback( - phydev: *mut bindings::phy_device, - devnum: i32, - regnum: u16, - val: u16, - ) -> i32 { - from_result(|| { - // SAFETY: This callback is called only in contexts - // where we hold `phy_device->lock`, so the accessors on - // `Device` are okay to call. - let dev = unsafe { Device::from_raw(phydev) }; - T::write_mmd(dev, devnum as u8, regnum, val)?; - Ok(0) - }) - } - /// # Safety /// /// `phydev` must be passed by the corresponding callback in `phy_driver`. @@ -536,16 +498,6 @@ pub const fn create_phy_driver() -> DriverVTable { } else { None }, - read_mmd: if T::HAS_READ_MMD { - Some(Adapter::::read_mmd_callback) - } else { - None - }, - write_mmd: if T::HAS_WRITE_MMD { - Some(Adapter::::write_mmd_callback) - } else { - None - }, link_change_notify: if T::HAS_LINK_CHANGE_NOTIFY { Some(Adapter::::link_change_notify_callback) } else { @@ -615,16 +567,6 @@ fn resume(_dev: &mut Device) -> Result { build_error!(VTABLE_DEFAULT_ERROR) } - /// Overrides the default MMD read function for reading a MMD register. - fn read_mmd(_dev: &mut Device, _devnum: u8, _regnum: u16) -> Result { - build_error!(VTABLE_DEFAULT_ERROR) - } - - /// Overrides the default MMD write function for writing a MMD register. - fn write_mmd(_dev: &mut Device, _devnum: u8, _regnum: u16, _val: u16) -> Result { - build_error!(VTABLE_DEFAULT_ERROR) - } - /// Callback for notification of link change. fn link_change_notify(_dev: &mut Device) {} } -- 2.54.0