From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=148.251.105.195 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794632462; b=5JEYftcaBTwADBQek1YCOTtuD3IRar4nOhk0fXNibAVsmBgwN7obc7hra9xT/MoqeZzn FNdTgsIe4YfTCjm9VApuH8NhHjZi7Lvxk7JqmG0rqDqL3uJQD9pKpJ6ERTsBl7B2sAWfd AGJ/OBxCCesZ97KlvKTp0kyuk9rfx+Bzpdu8y4zIkmJ5D73xhQWSGaC2fqncjjrUEkqBd 6dc2bZraexfvNgntqWljo1GvYklVNIU+0nvqvcoSMl6V8VCli/px9wWK1RwKQoLWghQ/4 Huyw4caqdiZag2dunOk0MbaRre1O9beTjd103tbbsslB8N0jn0yB1aPDoOCUjXFJ5jg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794632462; h=DMARC-Filter:DKIM-Signature:Received:Received:From:Date:Subject: MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id: References:In-Reply-To:To:Cc:X-Mailer:X-Developer-Signature: X-Developer-Key; bh=F1C8im9EaIbJjknF2DtqYY+ccSHvnsK8nioNPS+7OL0=; b=NcE6AnK3ULlh0wGeQfB5LkkK5ErlipM5y8xrhVONZm3AF4r8/fMAI27mVqVAKKZfabzf Y7BH1w4HEZ0VG65dhKnTUHyJNbGU6fFnvfpm1aazo5VJHzd27B9Q8wdfOU0Cywivqyj6y Jk0Hqmbne0QZcJkWSE0DVJvcI3GDCJf7IJ7aP7KfSaUMiovmWZ70pStDE3yslpi+9PyPF ltBGSY0CfR3CxQqJmNqxte03qyGgvYzMbVp6GUtLhz6A5gRKozebEmsHHowH9RPZUUbfN KoJ7xpE/HBoeeJFtK8Agxj6hKryXM7hKq75MNRlW0YNSCxHjpru0xhmlE+Oe/ZBPcRw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass header.d=collabora.com header.i=@collabora.com header.a=rsa-sha256 header.s=mail header.b="havA/dBs"; arc=none smtp.remote-ip=148.251.105.195 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B158E606A8A8; Sat, 14 Nov 2026 05:01:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B158E606A8A8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.a=rsa-sha256 header.s=mail header.b=havA/dBs DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1794632456; bh=s5L6s2fj0KUYXfVyQ1DqZ+JQ9NOwnY5J+JG3saptonk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=havA/dBs65Byi5UoQBP8wJtmf7zNcIySraIf79Fv8OC8/G2Lf/S6++QjOuhIuPfpl jne9hLLseMKfcArFLuEWAZpNf5DMpn5Sl2jD8cZg27+lHFBZw9MOXJkjMcPRKkEVlh xpny/G9Wh6hBu4bASFAoP+h7J8MGIRTOmY/KEMmo4Om/9SAw8et0WR+7C04N7t/hmx xBAUYw9O9OhxhdEUhrOh5j4OIFrzKDHqQXhSaQ/PHRrwPB0u1YWyZ5lpXmZ99uDzgg BhHKp0oKX65KLdpSYoD42KHUBJZJmoSbMFuxF7OAj/neqZ6FU5O0ABE9IvrBEpNKMV zMgxR6XOIwKKA== Received: from jupiter.universe (unknown [100.64.1.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) (Authenticated sender: sre) by bali.collaboradmins.com (Postfix) with ESMTPSA id B06F417E3873; Sat, 14 Nov 2026 06:00:56 +0100 (CET) Received: by jupiter.universe (Postfix, from userid 1000) id 176FA480041; Sat, 14 Nov 2026 06:00:56 +0100 (CET) From: Sebastian Reichel Date: Sat, 14 Nov 2026 06:00:41 +0100 Subject: [PATCH v12 08/23] drm/bridge: synopsys: dw-dp: Free output_fmts when none are valid X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261114-synopsys-dw-dp-improvements-v12-8-d42d3dc5bdd4@collabora.com> References: <20261114-synopsys-dw-dp-improvements-v12-0-d42d3dc5bdd4@collabora.com> In-Reply-To: <20261114-synopsys-dw-dp-improvements-v12-0-d42d3dc5bdd4@collabora.com> To: Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Rob Herring , Krzysztof Kozlowski , Conor Dooley , David Airlie , Simona Vetter , Dmitry Baryshkov , Luca Ceresoli , Philipp Zabel Cc: Cristian Ciocaltea , Damon Ding , Dmitry Baryshkov , Alexey Charkov , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@collabora.com, linux-arm-kernel@lists.infradead.org, Sebastian Reichel , Sashiko , Igor Paunovic , Andy Yan X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1171; i=sebastian.reichel@collabora.com; h=from:subject:message-id; bh=s5L6s2fj0KUYXfVyQ1DqZ+JQ9NOwnY5J+JG3saptonk=; b=owJ4nAFtApL9kA0DAAoB2O7X88g7+poByyZiAGr36wdVhJcVdhP9bjxZFQ1W/2gr23BLxdb50 iBoRxLYYN7nkIkCMwQAAQoAHRYhBO9mDQdGP4tyanlUE9ju1/PIO/qaBQJq9+sHAAoJENju1/PI O/qaNTMP/3PNDKw26kgszhl+kZVw6GXhu+cFR2amPDo/QudctDpi6POkP3xdts4iX/FAN+aM6qg iyK0qwwCxAVCJfOEHsHqfgf/ZJEuVxYun7fQ8dnjlOXJOc511FrNu3YbxdiWPchh889l0Uzy6zo HpGTCjgGX+ttaS7/BoWNAVyIgAGsgQIraXcMnVJ8VZdDcEhw4yPWwtZYKCWfpHAxAP+DSXODEIf Iw3lyVJEj8WPZS8dpvS+FmF2/dhOo0HmJl21hnzhs7wp1/Fy0To985rrehuUohuF+E40HIT/Fgt NhAfPtMMaG1FIDAdtsW3lrIqvWHBZkkNRmwxF8BsjRTPtbmr/KYa20r4bn7hEMdRZS2sTTBkCll UFH+GsmMF2vDeVcE+nHzRLrXrg+5521s7Z/ymoAW6uaOduNZpMOIRXqSZn3CoUIp0QxU/+Blb3u wPgPx0h7CIIsE0kKnq6cLnAFdFPrgSnD0OdaniYXzGNa5HzOTjiwm9N5UsQgMRbQ85BilqQ7Tqc qbBaMXF0PjoxvGOUd9qOJRutj8OaQXQDVGNb8k9zqvAhgQelA7uzOv7loUlpWMmK+BqgLUac7wj 1mx4UJ6Suuc/WPKTDI3Dt52zIcOi6qx4rqAHzM46DmNO/60Dz0QIw9Lqbb0bcC31qrRJDhtpRbX tg8POWXath6uekmYteTEu+w== X-Developer-Key: i=sebastian.reichel@collabora.com; a=openpgp; fpr=EF660D07463F8B726A795413D8EED7F3C83BFA9A If dw_dp_bandwidth_ok() returns false for all formats, *num_output_fmts might end up becoming 0. In this case functions calling it assume that nothing needs to be free'd, so free output_fmts within the function to avoid leaking memory. Fixes: 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support library") Reported-by: Sashiko Reviewed-by: Andy Yan Tested-by: Igor Paunovic # Orange Pi 5+ Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/bridge/synopsys/dw-dp.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/bridge/synopsys/dw-dp.c index 4afa57f4bce2..158c727ab58b 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c @@ -1821,6 +1821,11 @@ static u32 *dw_dp_bridge_atomic_get_output_bus_fmts(struct drm_bridge *bridge, output_fmts[j++] = fmt->bus_format; } + if (j == 0) { + kfree(output_fmts); + output_fmts = NULL; + } + *num_output_fmts = j; return output_fmts; -- 2.53.0