From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andy Shevchenko <andy@kernel.org>,
Svyatoslav Ryhel <clamor95@gmail.com>,
"H . Nikolaus Schaller" <hns@goldelico.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Andreas Kemnade <andreas@kemnade.info>,
Johannes Kirchmair <johannes.kirchmair@skidata.com>,
Yuki Horii <yuuki198708@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] Input: tsc2007 - drop redundant error message on IRQ request failure
Date: Fri, 13 Nov 2026 16:02:20 -0800 [thread overview]
Message-ID: <20261114000220.1280581-3-dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <20261114000220.1280581-1-dmitry.torokhov@gmail.com>
devm_request_threaded_irq() already logs an error message when
requesting the interrupt fails, so the additional dev_err() call in
tsc2007_input_configure() is redundant. Remove it.
Suggested-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/touchscreen/tsc2007_core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/input/touchscreen/tsc2007_core.c b/drivers/input/touchscreen/tsc2007_core.c
index d55034914808..3597f71f6c33 100644
--- a/drivers/input/touchscreen/tsc2007_core.c
+++ b/drivers/input/touchscreen/tsc2007_core.c
@@ -276,10 +276,8 @@ static int tsc2007_input_configure(struct tsc2007 *ts)
NULL, tsc2007_soft_irq,
IRQF_ONESHOT | IRQF_NO_AUTOEN,
dev->driver->name, ts);
- if (err) {
- dev_err(dev, "Failed to request irq %d: %d\n", ts->irq, err);
+ if (err)
return err;
- }
err = input_register_device(input_dev);
if (err) {
--
2.56.0.679.gc527c65306-goog
next prev parent reply other threads:[~2026-11-14 0:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 0:02 [PATCH 1/3] Input: tsc2007 - drop unnecessary cast in tsc2007_calculate_resistance() Dmitry Torokhov
2026-11-14 0:02 ` [PATCH 2/3] Input: tsc2007 - use scnprintf() when formatting phys string Dmitry Torokhov
2026-11-14 0:43 ` Andy Shevchenko
2026-11-14 0:02 ` Dmitry Torokhov [this message]
2026-11-14 0:44 ` [PATCH 3/3] Input: tsc2007 - drop redundant error message on IRQ request failure Andy Shevchenko
2026-11-14 0:43 ` [PATCH 1/3] Input: tsc2007 - drop unnecessary cast in tsc2007_calculate_resistance() Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261114000220.1280581-3-dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=andreas@kemnade.info \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=clamor95@gmail.com \
--cc=hns@goldelico.com \
--cc=johannes.kirchmair@skidata.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuuki198708@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®