Re: [PATCH v3 1/2] dt-bindings: iio: light: Add Capella CM3217

[Jonathan Cameron <jic23@kernel.org>]

On Fri, 13 Nov 2026 20:58:59 +0100
Patrick Fischer via B4 Relay <devnull+admin.tsv-stahl-riesa.de@kernel.org> wrote:

> From: Patrick Fischer <admin@tsv-stahl-riesa.de>
> 
> The Capella CM3217 is an ambient light sensor with an I2C interface but
> without registers and without an interrupt line. It always answers on
> the two fixed addresses 0x10 and 0x11, which are both listed in reg.
> 
> The sensor is used in the NVIDIA Tegra Note 7 and the NVIDIA Shield
> Tablet.
> 
> Signed-off-by: Patrick Fischer <admin@tsv-stahl-riesa.de>
> ---
>  .../bindings/iio/light/capella,cm3217.yaml         | 50 ++++++++++++++++++++++
>  1 file changed, 50 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/capella,cm3217.yaml b/Documentation/devicetree/bindings/iio/light/capella,cm3217.yaml
> new file mode 100644
> index 000000000000..9aba05949a27
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/capella,cm3217.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/light/capella,cm3217.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Capella CM3217 ambient light sensor
> +
> +maintainers:
> +  - Patrick Fischer <admin@tsv-stahl-riesa.de>
> +
> +description:
> +  The CM3217 is an I2C ambient light sensor without registers or interrupt
> +  line.
I'd drop the 'without registers or interrupt line' as one isn't relevant to DT
and the other one is seen by there not being an interrupts entry in the properties.

Other than that, looks fine to me.

Thanks

Jonathan

> +
> +properties:
> +  compatible:
> +    const: capella,cm3217
> +
> +  reg:
> +    items:
> +      - description:
> +          Command byte 1 (shutdown and IT_T) on write, high byte of the light
> +          count on read. Fixed at 0x10.
> +      - description:
> +          Command byte 2 (FD_IT) on write, low byte of the light count on
> +          read. Fixed at 0x11.
> +
> +  vdd-supply: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - vdd-supply
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        light-sensor@10 {
> +            compatible = "capella,cm3217";
> +            reg = <0x10>, <0x11>;
> +            vdd-supply = <&vdd_2v85_sen>;
> +        };
> +    };
> +...
>