[PATCH v5 0/6] media: Add the ST VD55G0 global shutter sensor

[Sergey Lebedev <lsa.uz@pm.me>]

The ST VD55G0 is a 644x604 monochrome global shutter sensor. It is the
infrared camera of the Microsoft Surface Pro 11 for Business with Intel
(Lunar Lake, IPU7), of the Surface Pro 9 (Alder Lake, IPU6) and of the
Surface Pro 8 (Tiger Lake, IPU6), ACPI device SMO55F0. Without a driver
the camera does not appear at all.

  1/6  dt-bindings: media: i2c: st,vd55g1: Add ST VD55G0
  2/6  media: i2c: Add ST VD55G0 global shutter sensor driver
  3/6  platform/x86: int3472: Map the VD55G0 supplies to "vddio" and "vana"
  4/6  media: ipu-bridge: Add ST VD55G0
  5/6  media: ipu-bridge: Index the sensor device properties as the endpoint ones
  6/6  media: ipu-bridge: Add the Surface Pro 8, 9 and 11 infrared illuminator

The driver is a port of ST's own downstream driver, firmware patch
included, as vd55g1 carries its own:
https://github.com/STMicroelectronics/vd55g0-linux-driver
2/6 carries Benjamin's Co-developed-by, and its clock tree is based on
his.

Changes in v5
=============

v5 is on media-committers next, where v4 no longer applies. It is sent
less than a week after v4 so that nobody reviews a version that cannot
be applied as posted.
- 3/6: type 0x10 is INT3472_GPIO_TYPE_AVDD there (Hans de Goede's
  int3472 series), so the vana entry keys on it. As posted, v4 matched
  0x0f there, and the sensor got no vana:
  https://lore.kernel.org/all/20261111063351.96951-1-lsa.uz@pm.me/
- 4/6: VD55G0 goes under IMX681, which next now carries at that place.
- 6/6: the Surface Pro 8, as Emfox tested it.
- Emfox's Tested-by on 3/6, 4/6 and 6/6, from the Surface Pro 8:
  https://lore.kernel.org/all/179439345249.5.16817789862917866412@debian.org/
- 1/6, 2/6 and 5/6 do not change.

v4: https://lore.kernel.org/all/20261110195454.48176-1-lsa.uz@pm.me/

On the supply names in 3/6: which rail each of the two pins feeds is not
documented. Measuring it here does not tell either: with the power
enable alone, or AVDD alone, the sensor never answered on I2C (0 of 6
each), and with both it always did (6 of 6). AVDD maps to vana, and the
power enable to vddio; VCORE stays a dummy. The driver enables all three
together, so the names do not change what the sensor gets. Hans, Hao,
Dan, D. Manresa: if you know what these two pins feed on this machine, I
will change 3/6 to match.

3/6 matches SMO55F0, which is also the Surface Pro 9's IR camera, and
v4 and v5 have not run there. Fernando, could you try it? If its INT3472
uses other pins for the sensor, 3/6 needs them too.

On all three machines the sensor needs Hao Yao's int3472 fix, which sets
the 24 MHz clock the SSDB asks for; without it the sensor runs at four
fifths of every rate this series computes. Its v2 fixes the Surface Pro
11; on the Surface Pro 8 and 9 the _DSM wants 0 rather than 3 (Fernando,
Emfox):
https://lore.kernel.org/all/20251208035122.2147678-1-hao.yao@intel.com/

Tested on the Surface Pro 11 for Business, on v7.4-rc1 with Hao Yao's
int3472 v2, KASAN and lockdep on, IPU7 run by the ipu6 driver.

v5 in one boot, with its vd55g0, its ipu-bridge (next's, with 4/6 to
6/6) and its int3472 discrete module (next's discrete.c, with 3/6)
built against that kernel:
- 3/6: INT3472 registers vana and vddio for the sensor and nothing else;
  vcore is a dummy;
- probe binds, and the sensor suspends about 1 s later, with no
  power-off inside probe. Probe forced to fail at registration: no clock
  or regulator warning. As a control, the same failure after a runtime
  suspend inside probe gives three warnings per probe;
- led_mode is offered (6/6), and the privacy LED is lit while streaming;
- v4l2-compliance 46 of 46; captures at 59.14 fps; three unload and
  reload cycles; the controls reach the sensor as in v4;
- the same results as v4's check, line for line, but for the supply
  names next gives the other two sensors and the IMX681 next now finds;
- no KASAN, lockdep or Oops report; the only other WARNING is the ipu6
  driver's lockdep_assert_held() at each stream start;
- on next: checkpatch --strict, W=1 and sparse clean on x86_64, i386,
  allmodconfig and without CONFIG_PM; smatch clean; coccicheck clean but
  for three scripts this spatch cannot run; each patch builds on its
  own; dt_binding_check clean, and it refuses a VD55G0 example at 125
  MHz.

v4, whose 2/6 v5 carries unchanged, also ran every mode at 59.14 fps,
read the controls back over I2C, went through ten runtime PM cycles and
s2idle with the camera idle and mid-stream, and passed 54 of 54 through
the media device. Emfox ran v4 on the Surface Pro 8, on v7.4-rc2: 3/6
maps its INT3472 as written, and 6/6 with the Surface Pro 8 entry lights
the illuminator.

5/6's lens-focus entry did not run: this machine's rear camera has a
VCM type ipu-bridge does not know. The Surface Pro 9 entry in 6/6 was
tested by Fernando on v2, not by me.

On the illuminator in 6/6: it stops lighting past about 70% of the
frame, and in the dark the AE runs past that, to exposure 1796 with both
gains at maximum. v5, as vd55g1, keeps that as the next stream's AE cold
start, so every later stream starts on a black frame and stays there
until the driver is bound again. On a white sheet the AE settles at 51
lines from the default cold start, and from 1796 with no gain, but never
leaves 1796 with full gains. A MAX_EXPOSURE_LINES cap while the strobe
is on should avoid both; I would send it on top of this series.
Benjamin, or should the cold start not carry over until then?

Tool use, per Documentation/process/generated-content.rst (Assisted-by
tags in commits were dropped in 7.4-rc1):

* My contributions to this series were prepared with Claude Code
  (claude-opus-5-5); work by others in it is their own.
* This replaces any Assisted-by tags in earlier versions.

Sergey Lebedev (6):
  dt-bindings: media: i2c: st,vd55g1: Add ST VD55G0
  media: i2c: Add ST VD55G0 global shutter sensor driver
  platform/x86: int3472: Map the VD55G0 supplies to "vddio" and "vana"
  media: ipu-bridge: Add ST VD55G0
  media: ipu-bridge: Index the sensor device properties as the endpoint
    ones
  media: ipu-bridge: Add the Surface Pro 8, 9 and 11 infrared
    illuminator

 .../bindings/media/i2c/st,vd55g1.yaml         |   27 +-
 MAINTAINERS                                   |    9 +
 drivers/media/i2c/Kconfig                     |   11 +
 drivers/media/i2c/Makefile                    |    1 +
 drivers/media/i2c/vd55g0.c                    | 2232 +++++++++++++++++
 drivers/media/pci/intel/ipu-bridge.c          |   92 +-
 drivers/platform/x86/intel/int3472/discrete.c |   24 +
 include/media/ipu-bridge.h                    |   16 +-
 8 files changed, 2396 insertions(+), 16 deletions(-)
 create mode 100644 drivers/media/i2c/vd55g0.c


base-commit: 42b94ef7358f04a0ad2e3541a0db307ed39402f1
-- 
2.54.0