mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: albin_yang@163.com
To: kayracizmeci@gmail.com
Cc: albin_yang@163.com, albinwyang@tencent.com, bsegall@google.com,
	dietmar.eggemann@arm.com, jstultz@google.com,
	juri.lelli@redhat.com, kprateek.nayak@amd.com,
	linux-kernel@vger.kernel.org, mgorman@suse.de, mingo@redhat.com,
	peterz@infradead.org, rostedt@goodmis.org,
	vincent.guittot@linaro.org, vschneid@redhat.com
Subject: Re: [PATCH v2] sched/stats: Fix run_delay over-count for tasks parked on the runqueue while blocked
Date: Sat, 14 Nov 2026 23:20:06 +0800	[thread overview]
Message-ID: <20261114152006.3397473-1-albin_yang@163.com> (raw)
In-Reply-To: <avhSzH_sRtg4g_Gs@scheduler.schedules>

Hi Kayra,

> So I see you removed some of the comments from Prateek's diff.
> Is there a reason or you just forgot to add them? :-).

I was just trying to simplify the patch, not an oversight. Those
comments are needed; I'll restore them in the next version.

> And what is your plan for v4?

v4: https://lore.kernel.org/all/20261024042753.2276779-1-albin_yang@163.com/

Two options as I see it:

  1) Drop v4. This patch fixes both the proxy and the DELAY_DEQUEUE
     over-counts on mainline, so a separate sched_delayed based fix
     is not needed here. Once this patch lands, I would submit v4
     to stable separately as the equivalent fix for the older series.

  2) Post a series with v4 as 1/2 (so it can be backported to older
     kernels) and this patch as 2/2. This is a bit odd, though, as
     1/2's change to sched_info_enqueue() would be overwritten by
     2/2 -- they touch the same line.

Happy to go either way if you have a preference.

Thanks,
Wei Yang


      reply	other threads:[~2026-11-14 15:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-14  9:26 albin_yang
2026-11-14 13:49 ` Kayra Cizmeci
2026-11-14 15:20   ` albin_yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261114152006.3397473-1-albin_yang@163.com \
    --to=albin_yang@163.com \
    --cc=albinwyang@tencent.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=jstultz@google.com \
    --cc=juri.lelli@redhat.com \
    --cc=kayracizmeci@gmail.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®