From: Safocl Stollmannovic <safocl88@gmail.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
Pavel Machek <pavel@kernel.org>, Len Brown <lenb@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: [PATCH v3 14/14] suspend: fix duplicate extern declarations
Date: Sat, 14 Nov 2026 20:55:54 +0400 [thread overview]
Message-ID: <20261114165612.368785-15-safocl88@gmail.com> (raw)
In-Reply-To: <20261114165612.368785-1-safocl88@gmail.com>
Compiling a kernel module with a C++ compiler results in a "duplicate
extern specifier" error.
This occurs because the code contains `extern asmlinkage`, and `asmlinkage`
expands to `extern C` when processed by a C++ compiler.
Since the code already contains sections that respond to a C++ compiler,
I believe it is a perfectly valid approach to gradually move toward a state
where kernel modules can be compiled by a C++ compiler without any issues.
The `extern` specifier must be removed.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=222257
Signed-off-by: Safocl Stollmannovic <safocl88@gmail.com>
---
include/linux/suspend.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/suspend.h b/include/linux/suspend.h
index a38150277..b97af3420 100644
--- a/include/linux/suspend.h
+++ b/include/linux/suspend.h
@@ -385,8 +385,8 @@ extern int swsusp_page_is_forbidden(struct page *);
extern void swsusp_set_page_free(struct page *);
extern void swsusp_unset_page_free(struct page *);
extern unsigned long get_safe_page(gfp_t gfp_mask);
-extern asmlinkage int swsusp_arch_suspend(void);
-extern asmlinkage int swsusp_arch_resume(void);
+asmlinkage int swsusp_arch_suspend(void);
+asmlinkage int swsusp_arch_resume(void);
extern u32 swsusp_hardware_signature;
extern void hibernation_set_ops(const struct platform_hibernation_ops *ops);
--
2.56.1
prev parent reply other threads:[~2026-11-14 16:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 16:55 [PATCH v3 00/14] Remove redundant " Safocl Stollmannovic
2026-11-14 16:55 ` [PATCH v3 01/14] ARM: fix duplicate " Safocl Stollmannovic
2026-11-14 16:55 ` [PATCH v3 02/14] loongarch: " Safocl Stollmannovic
2026-11-14 16:55 ` [PATCH v3 03/14] microblaze: " Safocl Stollmannovic
2026-11-14 16:55 ` [PATCH v3 04/14] MIPS: " Safocl Stollmannovic
2026-11-14 16:55 ` [PATCH v3 05/14] openrisc: " Safocl Stollmannovic
2026-11-14 16:55 ` [PATCH v3 06/14] riscv: " Safocl Stollmannovic
2026-11-14 16:55 ` [PATCH v3 07/14] x86: " Safocl Stollmannovic
2026-11-14 16:55 ` [PATCH v3 08/14] drivers: " Safocl Stollmannovic
2026-11-14 16:55 ` [PATCH v3 09/14] sched/preempt: " Safocl Stollmannovic
2026-11-14 16:55 ` [PATCH v3 10/14] lockdep: " Safocl Stollmannovic
2026-11-14 16:55 ` [PATCH v3 11/14] printk: " Safocl Stollmannovic
2026-11-14 16:55 ` [PATCH v3 12/14] shed/task: " Safocl Stollmannovic
2026-11-14 16:55 ` [PATCH v3 13/14] start_kernel: " Safocl Stollmannovic
2026-11-14 16:55 ` Safocl Stollmannovic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261114165612.368785-15-safocl88@gmail.com \
--to=safocl88@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®