Re: [PATCH v2] iio: adc: ad4134: Fix duplicate data_read mux state request

[Jonathan Cameron <jic23@kernel.org>]

On Sun, 8 Nov 2026 22:08:37 -0300
Marcelo Schmitt <marcelo.schmitt1@gmail.com> wrote:

> On 11/05, Chen Ni wrote:
> > devm_mux_state_get() is called twice in a row. The second call's result
> > is stored directly into st->mux_st[AD4134_DOUT0_INPUT] without error
> > checking, and then immediately overwritten by the first call's result.
> > 
> > Remove the duplicate call and check the return value before saving the
> > state.
> > 
> > Fixes: f12ecb3e147b ("iio: adc: ad4134: Support SPI 4-wire mode")
> > Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> > Reviewed-by: Joshua Crofts <crofts@kernel.org>
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> > ---  
> LGTM
> If still worth anything,
> Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>

Even if it is too later to add to the git log, it is still useful
to have this here for future reference!  On this occasion I
have just updated the commit to add the tag.

Thanks,

Jonathan

> 
> Thanks,
> Marcelo