From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.49 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794697729; b=l/EwmUGD+KmbfIcZKD5I/dgldhuChBTaU0MszH8tH1WJ3NK5jBtKqRI8dz9jwXLbHVmM jpQzayuMsX5TLgKcporOIZLV/ejOVIylihoHg7e7IYAX3UrlJSjws6ENov60cDTKcCBQG rd2s/GHbDxjmdvSWYsUWcDW0Zpxf6x6pykxck2Iljnyy8qxIrnO1Xybset/CMsVwa+jfk 0f7GvhzbGRHroPeMut21QZeuVQ3KrZfA/42tC/HsGwYh+n+Wlgv8DiGfgyWPYnOC0WONo D6CKTIOHlkU5CWAhgQJkMCflqgSFAX3uoFz4q7ZSO1kelR85/aW0odtVhZ/6BzkWa7Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794697729; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=tvw3aYJ/+J2kjwbuv/bkRl4wFmMEl8VZq/eLp4o6xu0=; b=VkKUNTmatZmN016wd/eydF3zpKOB4vW2XbjJU2bw8V30jFDToq0WX5pDgiwIMlnWVOIr U2FIS9bk+3XmiSpGfD1mfdaLL+mykNYyt8jX/RBy6CNri3accZUV5m455/DtSFcP0dn7Q O0sii0klAaO/iTGzUQN0avHn6v0th1D3iCnYUql58WYBP3aDMpVQ8C6XHLoO/DoKZ4Alh p76cmSl68WGWBsmO9A1Sx3TZvbr4Gry5UJsjQT+yx8rpdSVB90hB01nn1iFHS4XuC7DeD WOGv6rXAezRdPlbQKnn4Jcx8yOpCC6PDlmJSKgH4tkcb1w0g14MNooUE4RYyoz7snUg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=nSi67exh; arc=none smtp.remote-ip=209.85.128.49 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB79F606A32D for ; Sat, 14 Nov 2026 23:08:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org DB79F606A32D Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=nSi67exh Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4bb6adaf0f1so559555e9.0 for ; Sat, 14 Nov 2026 15:08:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794697727; x=1795302527; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tvw3aYJ/+J2kjwbuv/bkRl4wFmMEl8VZq/eLp4o6xu0=; b=nSi67exhIRk8jUdZadpDQoHD/04fLVAUkYOOP+LdYhSx260g/2XClJpqWX17ObFQQa Z/1VDW8W1ebcenrVuU+TC04JvOQbFqK0R1n2jZoFjyxuMxbQcAoQ1iEvT4Z/51iTrorm p/ab8oXYDYRO7FeGjqX+slsvbENiJfUFCvBq00ynbXHIuViuKW3cS/csOKCJ3xNNEgQG XgPjolRRj+yl+NSbi9MYFQAVVa5n8Lfj9sXXWMb9moSpZ6fQ6NUJPP6PLvoB2nKXNH2k TaePaWSBbfLex0By7nkTNN4KTKO6TZMiPau9ynJMrr9RHzzMhSX+EYF2ArszbCJpfz8K ztQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794697727; x=1795302527; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=tvw3aYJ/+J2kjwbuv/bkRl4wFmMEl8VZq/eLp4o6xu0=; b=tp4C2jI3iUxaq9IcED870scCWGV4hou9NfBugIx2e1d5wYqffYD5YXmx02Zij0KYVt p5JFQXs1HyGo+XUsUNAy+w9zbd1TvtdX1apfaiYuYLc04cLi76LjSzohmD/XYoXI+7dZ /woo99C1QxuVhJzBR7ej80O4l0FnpMICzYC+IMKJLMyVcWpg5B2jXnXckrZbxQIserGQ gO94vllodVuIpoUPf9IsV7+Avzr+utu/53ddfdlXnVPOkiXQtoMq9h6/VKoYsKTWjsKp NH0FmGPmU4xe+EbUk83fLWDuRINnNGou0QyAYE2i/FhSXcXMymEB9tcGyVSCERIpOvE3 0snA== X-Forwarded-Encrypted: i=1; AL+hErFIG9U+OF1YkdpJCB7FDHF7kCp4ZTI19CsoPJMZSPQpWDn0e/400tftI/mcWskH0x4kBJTLF/L/aE3NdVI=@vger.kernel.org X-Gm-Message-State: APuU4Z+9cB/Ob1qzvMRabSIi3WoCzb5yBqH96VJurrvU3AQfqTis+2YT 8J6CGA2J53/cHyibsf44ixNvLDFnXyBJrOW3Gpbs9vU4LOHo5zkhB0/F X-Gm-Gg: AYBFou2/YZm2kt/Cz5TSHQkCmWlheh3iHSIFTjn9gk3v784lcDSMxLCnOsyMkUPjjAp gTlfSYW0Wgkr5cKyikXIblmw9fccVSPadsB053Mj1YDfKXKyuE5Mi9UeOVrw8kVn8fVQyxS6EX5 mFEbLBm0+iwyAvEkNhPsIsyAgbCq8dANGHj4BtgAs1z4nwQoKO0+mBVj2YtqxGgBYGnS421F8dC RQgA28T+360yG0IFY5J200Y7YM8j71ZQLLkK+sFx15UOIl9OTv3xlTSfmHMtOt2U5FpYeDdwcYu nOonCdaW2usU5Se8roe42etfn5rjWbH4LG9aHVCF0FO5R4ih9iqswpfebbM7WY8BHaUXQdJTv0/ ReTvkv785IzRHhCGTCCgclmREbJAKGwua30wI9/CqYAYK+ve6ChL/DgHSvpAouyfC5fkH6T1+Wz CMzRYYpYGcwsMczzUx0C6r0zul4R7375OOlU7qDnazgiYV0AhTQzaEVrrYRiNeqfNhBR6mpBBTn v4wrAURLJp4MG9lo+Izot9ig90Cx1102ilIkhMJ7mxBfPrYG/tIzKThb6Bk+AREvhgw1I+MsRSD HlmVm9BXJWNUYyzxY+/frdOKY8lx X-Received: by 2002:a05:600c:2d2:b0:4af:c210:5b3f with SMTP id 5b1f17b1804b1-4bb55a63720mr101633985e9.24.1794697727220; Sat, 14 Nov 2026 15:08:47 -0800 (PST) Received: from m2.. ([37.142.149.161]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-49c5d03b10fsm14910018f8f.1.2026.11.14.15.08.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Nov 2026 15:08:46 -0800 (PST) From: Michael Zaidman To: Jiri Kosina , Benjamin Tissoires Cc: Linus Walleij , Bartosz Golaszewski , Greg Kroah-Hartman , Jiri Slaby , Raman Varabets , Germain Hebert , Christina Quast , Rio Liu , Bruno Giacomazzi , linux-input@vger.kernel.org, linux-serial@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Zaidman , Chris Keeser Subject: [PATCH v3 10/16] HID: ft260: i2c: fix large write transaction failure Date: Sun, 15 Nov 2026 01:07:54 +0200 Message-ID: <20261114230800.1344401-11-michael.zaidman@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261114230800.1344401-1-michael.zaidman@gmail.com> References: <20261114230800.1344401-1-michael.zaidman@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Fixes a regression from commit 5afac727defa ("HID: ft260: missed NACK from busy device"), which waited for bus-idle after every HID write report except when the report flag was exactly FT260_FLAG_START. Multi-report I2C writes keep the bus busy between chunks for atomicity. Treating those middle reports like a final STOP caused ft260_xfer_status() to spin on -EAGAIN after the second HID report and fail large writes. Write-then-read combined transfers still worked. Pass the bus-busy check policy from the caller: ft260_i2c_write() and ft260_smbus_write() wait for idle only when the report they send carries STOP; intermediate chunks and the command phase of a combined transfer do not. The SMBus side matters for register reads. The command phase is written with FT260_FLAG_START and no STOP, because a repeated START read follows and the controller deliberately keeps the bus busy to keep the transaction atomic. Checking the busy bit there makes ft260_xfer_status() return -EAGAIN on every retry and the command write fail with -EIO, which breaks probing of clients that read registers: ads1x19 6-0040: Failed to read config register: -5 leds-pca963x: probe of 6-0008 failed with error -5 Fixes: 5afac727defa ("HID: ft260: missed NACK from busy device") Reported-by: Chris Keeser Closes: https://github.com/MichaelZaidman/hid-ft260/issues/35 Tested-by: Chris Keeser Reported-by: Bruno Giacomazzi Closes: https://github.com/MichaelZaidman/hid-ft260/issues/42 Signed-off-by: Michael Zaidman --- drivers/hid/hid-ft260.c | 35 ++++++++++++++++------------------- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/drivers/hid/hid-ft260.c b/drivers/hid/hid-ft260.c index b68cb0748a23..f160b5360f89 100644 --- a/drivers/hid/hid-ft260.c +++ b/drivers/hid/hid-ft260.c @@ -580,9 +580,14 @@ static int ft260_xfer_status(struct ft260_device *dev, u8 bus_busy) } dev->clock = le16_to_cpu(report.clock); - ft260_dbg("bus_status %#02x, clock %u\n", report.bus_status, - dev->clock); + ft260_dbg("bus_status %#02x, clock %u, bus_busy %#02x\n", + report.bus_status, dev->clock, bus_busy); + /* + * Do not check the busy bit for combined transactions + * since the controller keeps the bus busy between writing + * and reading IOs to ensure an atomic operation. + */ if (report.bus_status & (FT260_I2C_STATUS_CTRL_BUSY | bus_busy)) return -EAGAIN; @@ -616,13 +621,10 @@ static int ft260_hid_output_report(struct hid_device *hdev, u8 *data, } static int ft260_hid_output_report_check_status(struct ft260_device *dev, - u8 *data, int len) + u8 *data, int len, u8 bus_busy) { - u8 bus_busy; int ret, usec, try = 100; struct hid_device *hdev = dev->hdev; - struct ft260_i2c_write_request_report *rep = - (struct ft260_i2c_write_request_report *)data; ret = ft260_hid_output_report(hdev, data, len); if (ret < 0) { @@ -639,16 +641,6 @@ static int ft260_hid_output_report_check_status(struct ft260_device *dev, ft260_dbg("wait %d usec, len %d\n", usec, len); } - /* - * Do not check the busy bit for combined transactions - * since the controller keeps the bus busy between writing - * and reading IOs to ensure an atomic operation. - */ - if (rep->flag == FT260_FLAG_START) - bus_busy = 0; - else - bus_busy = FT260_I2C_STATUS_BUS_BUSY; - do { ret = ft260_xfer_status(dev, bus_busy); if (ret != -EAGAIN) @@ -665,6 +657,7 @@ static int ft260_hid_output_report_check_status(struct ft260_device *dev, static int ft260_i2c_write(struct ft260_device *dev, u8 addr, u8 *data, int len, u8 flag) { + u8 bus_busy = 0; int ret, wr_len, idx = 0; struct ft260_i2c_write_request_report *rep = (struct ft260_i2c_write_request_report *)dev->i2c_wr_buf; @@ -677,8 +670,10 @@ static int ft260_i2c_write(struct ft260_device *dev, u8 addr, u8 *data, do { if (len <= FT260_WR_I2C_DATA_MAX) { wr_len = len; - if (flag == FT260_FLAG_START_STOP) + if (flag == FT260_FLAG_START_STOP) { rep->flag |= FT260_FLAG_STOP; + bus_busy = FT260_I2C_STATUS_BUS_BUSY; + } } else { wr_len = FT260_WR_I2C_DATA_MAX; } @@ -694,7 +689,7 @@ static int ft260_i2c_write(struct ft260_device *dev, u8 addr, u8 *data, rep->flag, data[0]); ret = ft260_hid_output_report_check_status(dev, (u8 *)rep, - wr_len + 4); + wr_len + 4, bus_busy); if (ret < 0) { ft260_dbg("failed with %d\n", ret); return ret; @@ -735,7 +730,9 @@ static int ft260_smbus_write(struct ft260_device *dev, u8 addr, u8 cmd, ft260_dbg("rep %#02x addr %#02x cmd %#02x datlen %d replen %d\n", rep->report, addr, cmd, rep->length, len); - ret = ft260_hid_output_report_check_status(dev, (u8 *)rep, len); + ret = ft260_hid_output_report_check_status(dev, (u8 *)rep, len, + (flag & FT260_FLAG_STOP) ? + FT260_I2C_STATUS_BUS_BUSY : 0); if (ret < 0) ft260_dbg("failed with %d\n", ret); -- 2.43.0