From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.43 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794697722; b=YTcn2yWefnldQVARuLT7Exff/CnbsWRHrH3MXTbCEXsAiv42gCCU43SNZwDKcV9Up2MN CzmHAA2fEw/P5n1tpqJ1BZZzJjKNv/LpQn6NjlRt5dryx8J3qkOCpjwkvnOJOCGkocSam YSzH/J1Akg9c61XQRD+cHoVnRr1KbG84RKiqgzhouiuBfUqKPl0xLFJUkUy2evPItGVse /bSiw83jB0bKEZMTfwL3crDgPqHqiUVI+RcwjCnMUd2RWibv80TOCP/SJQLRTkcNmz6LV EERM3Sc9zM0RnPijaFk6pC30jjxpWzzpK2HzaDD6hT8YV3TD9/Ixnu/XOmknxZIjyMw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794697722; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=OWq1ZPhXVsQ8TnLGQfYbZB9MhFN53DcQmkdOU8DAzLM=; b=ZQWgF3EqFdJsLOF7g7M7pnIYAvxDAzh+IKb5owmlnICagL5piSddUwuNx3Xxo3DtI3n/ LHc9t4w3aUUOYBgR73apZN9rF7jYBx+bauymdTEeH6tBgB7b5CSZ08tmUG9702aUasfmm MuxzodhU2SiobzpcL7YN0HYja7qXm0baYjxVnrhjHaaPb1BsQPM0ISbdukT6QtDMydjGQ GF7x8GjBGpaddKGCkuEI1xUJSAlbGFp7bdTrFoZJwmmqdchrB4cbbXodeaNc3h1VzRrXd SmcOfE6Kzwvpuz+E8catYcw/HxIPqSvrGpJ/t8V11gc9dnjC/eVgfBeMe0NNv96j7QA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=j2x4AYJG; arc=none smtp.remote-ip=209.85.221.43 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C24460A3811 for ; Sat, 14 Nov 2026 23:08:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 3C24460A3811 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=j2x4AYJG Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-491846221ffso2063265f8f.3 for ; Sat, 14 Nov 2026 15:08:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794697721; x=1795302521; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OWq1ZPhXVsQ8TnLGQfYbZB9MhFN53DcQmkdOU8DAzLM=; b=j2x4AYJG6n6Db9GW977oMzXHN7UsiOwbhnKGYzeeISR1q9eapPvmbYFZYhSzsWSPuW p1CKAdFyMmXR+i3GSjxLKah+pfHWNHAS9AVTE4YwlG6Micg5x5ZVyN4gbg6Kp3PAKKZv RzkhOdlAZm/ViIGOuyuRIBKJtuqDkTeiNG3UOPwme14HPlkPi8XkATuf/Jg+Vp/9lui8 As6cgonNIYPmg7jk291hVSLs53wjow5UAgAsiCtE0R3w9ZrzBQOfV2D3ODiru6nL92AI 9+bfz8dH04ZlrE6UNSmasbmJTfoPeWfRVD89xFcz/X9xZc5CAtzZQIX+mGVLKmCGu6uJ qXww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794697721; x=1795302521; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=OWq1ZPhXVsQ8TnLGQfYbZB9MhFN53DcQmkdOU8DAzLM=; b=BjcEMrIF0rAm60CTHAdcdIoQ5zqgGnRMfGlL7H2l6c5m1KzA8pgPuzdZx/sqzFGmLh dULTObknzOi/7DA8op+cx+uxnPnwfrxmb61SOavdr356n2vFAoH3kocGClN0hdI77Glz imWKInxaUEbhwPalSqYwmJkZSUKgTFwrIX0JteVSgyXmbjk40U6WMGUGEAi9GMDHGJ4w Y/ONPPC1iKzRlx4kSnDyn7x3kop/LWoxQJKPi/svldSEwrqaI6vfXK6pldSe38Y0zDno POKlzQtF9pVLyRmklnLVnI7TT6FthKCd85vRFUezPfz6PHw8qecNLONUjmvHV1vHu8D0 ET3A== X-Forwarded-Encrypted: i=1; AL+hErFQg8l73VZgmoZZMy9JzyWHcHCjx8VYIRZgaFIbvpRApdZRQ0gDSOepDgc2OJOgNgW4vyvF2bg95AyVxi4=@vger.kernel.org X-Gm-Message-State: APuU4Z9EoaCMkmkODPHvlMePtA1yvCsUxGf5uozJm+VDJFipnrS842kP CRhwXZAvii8+9I9Mca3109Hc0IBGMtNuGMfw5g9pQaEn5NLIschT5oqm X-Gm-Gg: AYBFou2ikrSyqDF6CHuOrhHmRoi7WC0UFFso68xsjOAQU+lYgKmujqWfqpXHQLW77LP 3Ajm+5YdJ3tf76BOYglE1MprZikqwYwK7iU9llicuyAeGnMkMyBhVfD3PDD57M3SCyoPDc1vMUd iVqA7BkMZhP07H2dy2DNkfgI3Sbj1fnrJMjefdqLooVTghDzxASYRqDO/v26R4vULiL0cgx4EFY 7X0u2ZV9loNI9XkH8yTyTkY+D552B91/dU6YhC0Ay7I5tzCRUMD8MBHYScWYQmdP8JCV5G+dNsL TN/BNDxpzYpI5qyRZuPktb7XkR5h5IMj5OAK3/LDt19dpIN5QIJ4cpLe8k2xUP7GApHMoQOnX9C Q7Kb2FCejKI/2Albs6Ie+UPi6jJXqJXjEpKHSKEhFSPjlJ8jXb7tMEYBO5OziSqcz16hRz/CWtg +fZJMWdL0Yauwf7rjAqc1o1ywsVA3FdJ3rdFNPbF5rqk0widPyXqujo33LBwzBEXdtthIpHh617 c+n5efUXQBxDmLhhIg6P1ARZgFjdM470ikKFlMozTBOyQMDc9pc48jVczgugq2U6I6d5KpintUx n343fVcwk09O/ZD0hluQMqXusWLz X-Received: by 2002:a05:6000:2586:b0:48e:2f7e:bdbb with SMTP id ffacd0b85a97d-49c72c9c8b4mr15192826f8f.50.1794697720582; Sat, 14 Nov 2026 15:08:40 -0800 (PST) Received: from m2.. ([37.142.149.161]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-49c5d03b10fsm14910018f8f.1.2026.11.14.15.08.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Nov 2026 15:08:40 -0800 (PST) From: Michael Zaidman To: Jiri Kosina , Benjamin Tissoires Cc: Linus Walleij , Bartosz Golaszewski , Greg Kroah-Hartman , Jiri Slaby , Raman Varabets , Germain Hebert , Christina Quast , Rio Liu , Bruno Giacomazzi , linux-input@vger.kernel.org, linux-serial@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Zaidman Subject: [PATCH v3 07/16] HID: ft260: uart: enable flow control Date: Sun, 15 Nov 2026 01:07:51 +0200 Message-ID: <20261114230800.1344401-8-michael.zaidman@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261114230800.1344401-1-michael.zaidman@gmail.com> References: <20261114230800.1344401-1-michael.zaidman@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The FT260 is a full-speed USB device. Interrupt transfers poll at 1 ms with a 64-byte max packet size, so the theoretical UART payload ceiling is about 60 kB/s (~600 kbaud in 8N1). The chip advertises baud rates above 1M and small transfers can work there, but large transfers are not reliable above 460800 baud without flow control. Stop forcing FT260_UART_CFG_FLOW_CTRL_NONE after termios setup. Honor CRTSCTS (RTS/CTS) and IXON/IXOFF (XON/XOFF) when configuring the UART. Tested at 1500000 baud both directions against an FT2232H with XON/XOFF and with RTS/CTS (~2.9 MB transfers, no data corruption). Signed-off-by: Michael Zaidman --- drivers/hid/hid-ft260.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/hid/hid-ft260.c b/drivers/hid/hid-ft260.c index 270481766e2c..75ba68e2e8fc 100644 --- a/drivers/hid/hid-ft260.c +++ b/drivers/hid/hid-ft260.c @@ -1903,8 +1903,12 @@ static int ft260_uart_change_speed(struct ft260_device *port, if (termios->c_cflag & CRTSCTS) req.flow_ctrl = FT260_UART_CFG_FLOW_CTRL_RTS_CTS; + else if (termios->c_iflag & (IXON | IXOFF)) + req.flow_ctrl = FT260_UART_CFG_FLOW_CTRL_XON_XOFF; else - req.flow_ctrl = FT260_UART_CFG_FLOW_CTRL_OFF; + req.flow_ctrl = FT260_UART_CFG_FLOW_CTRL_NONE; + + req.breaking = FT260_UART_CFG_BREAKING_NO; ft260_dbg("configured termios: flow control: %d, baudrate: %d, ", req.flow_ctrl, baud); @@ -1912,9 +1916,6 @@ static int ft260_uart_change_speed(struct ft260_device *port, req.data_bit, req.parity, req.stop_bit, req.breaking); - req.flow_ctrl = FT260_UART_CFG_FLOW_CTRL_NONE; - req.breaking = FT260_UART_CFG_BREAKING_NO; - mutex_lock(&port->lock); ret = ft260_hid_feature_report_set(hdev, (u8 *)&req, sizeof(req)); -- 2.43.0