mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Arka Mondal <arka@arkamondal.net>
Cc: "David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Robert Eshleman" <bobbyeshleman@gmail.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] iio: light: Report the available lists via read_avail()
Date: Sat, 14 Nov 2026 23:44:40 +0000	[thread overview]
Message-ID: <20261114234440.60d61186@jic23-hlaptop> (raw)
In-Reply-To: <20261109050738.93424-1-arka@arkamondal.net>

On Mon,  9 Nov 2026 14:07:36 +0900
Arka Mondal <arka@arkamondal.net> wrote:

> These are patches 1 and 3 of the v1 series. Patches 2, 4, 5 and 6 are
> applied and are not resent.
> 
> Changes since v1:
> 
> - isl29125: the available bit goes in info_mask_shared_by_all_available
>   instead of info_mask_shared_by_type_available, which is the sharing
>   level that names the file scale_available, so the attribute keeps the
>   name it has and no ABI changes. The Fixes: tag is gone with it, and
>   the patch is a cleanup rather than a fix.
> 
> - max44009: the list is IIO_VAL_INT_PLUS_MICRO instead of
>   IIO_VAL_INT_PLUS_NANO. All eight values are a whole number of
>   microseconds, so three zeros go and nothing is rounded.
> 
> I loaded both drivers against CONFIG_I2C_STUB under qemu and read the
> attributes. isl29125 shows in_intensity_scale and scale_available, no
> in_intensity_scale_available, and scale_available still reads
> 0.005722 0.152590. max44009 shows in_illuminance_integration_time_available
> reading 0.800000 0.400000 0.200000 0.100000 0.050000 0.025000 0.012500 0.006250,
> and no unprefixed name.
> 
> Link: https://lore.kernel.org/r/20261102074700.63075-1-arka@arkamondal.net

Applied both to the testing branch of iio.git.
I added a note on the ABI break in patch 2 being a fix of buggy ABI and
cross our fingers case

Thanks

Jonathan

> 
> Arka Mondal (2):
>   iio: light: isl29125: Report the scale list via read_avail()
>   iio: light: max44009: Report the integration time via read_avail()
> 
>  drivers/iio/light/isl29125.c | 29 +++++++++++++++-------
>  drivers/iio/light/max44009.c | 48 ++++++++++++++++++++----------------
>  2 files changed, 47 insertions(+), 30 deletions(-)
> 
> 
> base-commit: d135ab453a7400a34930bdda1ef4bdc8acfac80e


      parent reply	other threads:[~2026-11-14 23:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09  5:07 Arka Mondal
2026-11-09  5:07 ` [PATCH v2 1/2] iio: light: isl29125: Report the scale list " Arka Mondal
2026-11-09  5:07 ` [PATCH v2 2/2] iio: light: max44009: Report the integration time " Arka Mondal
2026-11-09 23:19   ` Andy Shevchenko
2026-11-14 23:41     ` Jonathan Cameron
2026-11-14 23:44 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261114234440.60d61186@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=andy@kernel.org \
    --cc=arka@arkamondal.net \
    --cc=bobbyeshleman@gmail.com \
    --cc=dlechner@baylibre.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®