From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.216.41 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794725282; b=2D0Vg6eKHT+JVUFV3ipd31kuuoR8z4wHW4OT7CnujXfJcbu25Kr779JnBToghi/6gwHz UCFL8SvYDJbtcDXojXxF0nGV8STBh7RoQfW5ZzE489a01+3O5u7gclJ9n1j/cqKciZ3Ev OT4xuWMMAkQanIQC5C6lmze7vzC4+e88f4+MJxUxsszhiS1cW6X1YQ6174jB6aLmx7X9y hVseWnbb6xMi70HwcGKOA+AE5P+zNA9CsDQVtvWijc6ZPQ2td2EPQT7BZmeVSS0Qd9haJ 8G7gsLfibxdZEefOLMrP6mGOyA457CXNknJ8mwzNQyu+12sHtFBoNVEe/n4HabjN89A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794725282; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:Date:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding: Message-Id:References:In-Reply-To:To:Cc:X-Mailer; bh=8aCyDVugFTgDmxcEvIKcJWse+PFQb7Di/86YRfNsvCI=; b=Sqt1Ib6SZr2Kxwj5ZdLMmbsV/PCtbbk0HJGXXo1BtJJW/vy68tO+aOc9tCbtVTb5alka vImBTYen7X4BRuMYYxdhq13oiqbizPXwH5qUbX8jIKbuiwaiHy0jxLMjGnQ03XfOCSTLs TeUxsD0StSA0JVPk+agn7RubLqAJXp590UokkITVtG+5Kk4EGhxqxAXnkTMvdePldHJQl v1NLQnUpJArnpZhadK3FZJ1RmgdINalcAcpGXQc76+pDGcdTwcHV0V3EkyfMB+aEZ4uhj g9xdnuq93uuI+yW7A4bsMbcBTZBcKxOJAhrb+cVyf4zCJnl9aHgf0BRDESpjC74L9wQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=B3GWvUEM; arc=none smtp.remote-ip=209.85.216.41 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7299606A32E for ; Sun, 15 Nov 2026 06:48:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B7299606A32E Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=B3GWvUEM Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-3b18717a193so1350430a91.1 for ; Sat, 14 Nov 2026 22:48:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794725281; x=1795330081; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8aCyDVugFTgDmxcEvIKcJWse+PFQb7Di/86YRfNsvCI=; b=B3GWvUEMoHdmiTkYjZmsLjMMR19mRPYxAeCW8d7JxN51JEh4ylSSFq5sOIsnjlI03l H4q3ff5MpjrWWGAvc4KDXmsZchRylu75+EZ5vUnexjuXm45OuG0eXe55ymUzmrUKMNfd kL5fUAlyDP62rMCFg7JuZcKWC6ru5T2G3TKIEa498hiCE9JPN36nmPgSkOWpFF7Puovz O+1bHxr5W+ymyR/BfRLraz+Qvzm14L/3mO9zYWfX2px8gllNtszznoGVB7UDs+spKXGu halR+HiKpE5QBwpMBXyCELw6TPde/hOlCp6N5c+0oU9un65Zg4TthGNArwNxmM5984/M bALg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794725281; x=1795330081; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=8aCyDVugFTgDmxcEvIKcJWse+PFQb7Di/86YRfNsvCI=; b=MwJxWoJaCHnBPd7b/oYCgRfPJEKUaT3khIJ5YZ1aBe3FLyz038q+ezXtLahRNabOy9 OcOcq/6hH7XMrsAqz65wso7+Wu8LaT6EsW3vPDQDMaVYF/TlFreSYUbbGbdGK1/UzE/X NmeGkbCZnF/kulBm/o+Dn3X53b5ISJzXszbiCf14vadM9tdhCeGekbZd7WbdxJg4H12g /rUORrdoBNAGBsGz4HT3UbFxvf4JWrdGquNKWMLKax493NacgBmpy4Gb+la8Wej8ah5b eZE5e06Q3IFUDHvodSrUYe58UeL0Huh/LbHptw4XATNG/kqMSFgUFJi+vFQ8WZGo4Ndv AlCQ== X-Forwarded-Encrypted: i=1; AL+hErGUWn3BCC/cilCJZ/Blu5/o6ABSI28tdCDETvdrp4n7/sQ+hvDFkCDjmt56DQaak+1EK8QYK3Kla2CqfcY=@vger.kernel.org X-Gm-Message-State: APuU4Z9aEMIQ1G+vU3SyUF0YsGV4ZOYSbIRbX/xoux2TwAQm0387PhD4 w7rT2xiylU6Hs2ZCSBUuwkhBNsgU1DmUbQCH6nc5eCbBCtxy+5k4E6Cl X-Gm-Gg: AYBFou2f8hRc33w6QnO9vmHj+ja1GH33FAK9om42GDln4OS3g22KMqln9XqmKI0Qe/k fnjX9ND0p1TbR2q1z11Yq1sg07WohVfOdi7vrNWJWPVHlh15fSv/8nbO6HJsjiWPbca//FGcUvV DYDG8p/HODRRCzFMSUU8M1hFdRpJQOCeApM4uE14BYVW3Sn9r4YpRSxZo+DPMJ+v6aWGmVGzTXI D1sLupziGw1jAV8gA3E74NyuNsnpf3vinyIxhmueja0uBpLqklrO7++iQjZMRggkw24x0ES+514 ZtmvlhehyOgSuOCXa6iH79hgzQvuwgfVLocKztBUmbiY3xi0XUPeyiKtuyjLq8d9FJdadN/dojI AqkQeVTSOmwoA9hgNn3zKbPECuy+CVmG0SjmpB4bDHUwOmvMsxt5upxEIWB93yBwvYNu4AUH/L5 f9YZ7KflnHPq6UhE70Z7F/vGiLa2HxjJFIIkba7mv6iqfaI7MT8eLk+VnFS6ogR1EKxUuZdWhdc McA0UowyjIeFCoacTiN2F+72S25q3ecDMSTsAYnIJBk8ACMrJknmrnl7cYaeHcHTtBTpgSTiFJw /iQll12p5dvJVEnhyx4y2Dw09/mycV0ilvzOeXhkZ9cE1o497W5hp8/UEaaFpf2xNYVpGWcSASo jpehVj6AKQyJ5zx7z1WwhmuJGpi+lNoGeOKWvnzABjyd8KyKDPGWcetui X-Received: by 2002:a17:90b:2783:b0:3b0:af68:77a with SMTP id 98e67ed59e1d1-3b1b07ef475mr6799366a91.6.1794725280970; Sat, 14 Nov 2026 22:48:00 -0800 (PST) Received: from [169.254.3.1] ([143.248.188.96]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3b197d27d26sm16136309a91.13.2026.11.14.22.47.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Nov 2026 22:48:00 -0800 (PST) From: SeungJong Ha Date: Sun, 15 Nov 2026 15:47:36 +0900 Subject: [PATCH RESEND net-next v2 1/3] rust: net: phy: drop read_mmd and write_mmd from Driver X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261115-exp-phy-rs-maybelocked-v2-1-8fa7897a0352@gmail.com> References: <20261115-exp-phy-rs-maybelocked-v2-0-8fa7897a0352@gmail.com> In-Reply-To: <20261115-exp-phy-rs-maybelocked-v2-0-8fa7897a0352@gmail.com> To: FUJITA Tomonori , Trevor Gross , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , =?utf-8?q?Onur_=C3=96zkan?= , Andrew Lunn , Heiner Kallweit , Russell King Cc: netdev@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, SeungJong Ha X-Mailer: b4 0.15.2 The read_mmd and write_mmd callbacks hand the driver a `&mut Device` whose SAFETY comment says PHYLIB holds `phy_device->lock`. It does not have to: __phy_read_mmd() and __phy_write_mmd() call them with the MDIO bus lock held but not necessarily `phy_device->lock`, e.g. from phy_read_mmd() in a hwmon read. The register accessors on `Device` take the bus lock again, so using them there would deadlock. No Rust driver implements these callbacks, and none has since they were added with the abstraction. Drop them until there is a user and a way to express the MDIO bus lock context. Signed-off-by: SeungJong Ha --- rust/kernel/net/phy.rs | 58 -------------------------------------------------- 1 file changed, 58 deletions(-) diff --git a/rust/kernel/net/phy.rs b/rust/kernel/net/phy.rs index c4e7b1d6c6f4..7ca3f2329e6a 100644 --- a/rust/kernel/net/phy.rs +++ b/rust/kernel/net/phy.rs @@ -417,44 +417,6 @@ impl Adapter { T::match_phy_device(dev).into() } - /// # Safety - /// - /// `phydev` must be passed by the corresponding callback in `phy_driver`. - unsafe extern "C" fn read_mmd_callback( - phydev: *mut bindings::phy_device, - devnum: i32, - regnum: u16, - ) -> i32 { - from_result(|| { - // SAFETY: This callback is called only in contexts - // where we hold `phy_device->lock`, so the accessors on - // `Device` are okay to call. - let dev = unsafe { Device::from_raw(phydev) }; - // CAST: the C side verifies devnum < 32. - let ret = T::read_mmd(dev, devnum as u8, regnum)?; - Ok(ret.into()) - }) - } - - /// # Safety - /// - /// `phydev` must be passed by the corresponding callback in `phy_driver`. - unsafe extern "C" fn write_mmd_callback( - phydev: *mut bindings::phy_device, - devnum: i32, - regnum: u16, - val: u16, - ) -> i32 { - from_result(|| { - // SAFETY: This callback is called only in contexts - // where we hold `phy_device->lock`, so the accessors on - // `Device` are okay to call. - let dev = unsafe { Device::from_raw(phydev) }; - T::write_mmd(dev, devnum as u8, regnum, val)?; - Ok(0) - }) - } - /// # Safety /// /// `phydev` must be passed by the corresponding callback in `phy_driver`. @@ -536,16 +498,6 @@ pub const fn create_phy_driver() -> DriverVTable { } else { None }, - read_mmd: if T::HAS_READ_MMD { - Some(Adapter::::read_mmd_callback) - } else { - None - }, - write_mmd: if T::HAS_WRITE_MMD { - Some(Adapter::::write_mmd_callback) - } else { - None - }, link_change_notify: if T::HAS_LINK_CHANGE_NOTIFY { Some(Adapter::::link_change_notify_callback) } else { @@ -615,16 +567,6 @@ fn resume(_dev: &mut Device) -> Result { build_error!(VTABLE_DEFAULT_ERROR) } - /// Overrides the default MMD read function for reading a MMD register. - fn read_mmd(_dev: &mut Device, _devnum: u8, _regnum: u16) -> Result { - build_error!(VTABLE_DEFAULT_ERROR) - } - - /// Overrides the default MMD write function for writing a MMD register. - fn write_mmd(_dev: &mut Device, _devnum: u8, _regnum: u16, _val: u16) -> Result { - build_error!(VTABLE_DEFAULT_ERROR) - } - /// Callback for notification of link change. fn link_change_notify(_dev: &mut Device) {} } -- 2.54.0