mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Qiliang Yuan <qiliang.yuan@linux.dev>
To: "Martin K. Petersen" <mkp@kernel.org>,
	Shuah Khan <shuah@kernel.org>,  Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	 Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	 target-devel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	 linux-doc@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
	 io-uring@vger.kernel.org,
	Mike Christie <michael.christie@oracle.com>,
	 Bodo Stroesser <bostroesser@gmail.com>,
	Ming Lei <tom.leiming@gmail.com>,
	 Qiliang Yuan <qiliang.yuan@linux.dev>
Subject: [PATCH RFC 00/18] scsi: target: Add target_core_uring, an io_uring based user backstore
Date: Sun, 15 Nov 2026 19:17:53 -0500	[thread overview]
Message-ID: <20261115-feat-target-core-uring-v1-0-28cdc137eac6@linux.dev> (raw)

TCM/USER is how a userspace process serves a LIO device, for instance
to export distributed storage over iSCSI or vhost-scsi. All commands of
a device go through one command ring under one mutex, the data of each
command is copied into and out of a shared data area, and the server
has to parse every SCSI CDB itself.

This series adds target_core_uring, a second user backstore next to
TCM/USER, built the way ublk is:

- The kernel emulates the SCSI commands. The server only sees reads,
  writes, flushes, UNMAP and WRITE SAME as an operation, an offset and a
  length.
- A device has several queues. Each queue is served through io_uring
  commands on its own ring, with no lock shared between queues.
- Data is copied once, with pread()/pwrite() on the character device, or
  not at all when the server registers the pages of a command as an
  io_uring fixed buffer.

Patches 1-4 create the device, its queues and the character device.
Patches 5-8 pass reads and writes to the server. Patches 9-11 handle a
server that exits or hangs, and aborts. Patches 12-14 add flush, UNMAP
and WRITE SAME, patch 15 adds fixed buffers. Patches 16-18 add a small
server, a selftest and the documentation.

Not covered yet: protection information, and a way for existing
tcmu-runner handlers to move over without changes, as they implement
SCSI rather than block commands.

Exporting a 2 GiB device through tcm_loop to fio (io_uring, direct I/O,
iodepth 32 for 4k and 8 for 1M, 6 seconds per job) on a 32 CPU VM, with
TCM/USER and a single-threaded handler, then with this series, 32 queues
and one server thread per queue. Both servers keep the data in memory.
A single job is slower; the gain comes with concurrency and with large
I/O. Three alternating runs (median, min-max in parentheses):

  workload               TCM/USER (MB/s)   uring (MB/s)          change
  4k randread, 1 job      426 (409-463)      369 (366-384)         -13%
  4k randread, 4 jobs    1165 (1072-1253)   1524 (1413-1541)       +31%
  4k randread, 16 jobs    920 (916-1162)    6193 (5845-6222)      +574%
  4k randwrite, 16 jobs   793 (711-886)     5701 (5257-5706)      +619%
  1M read, 4 jobs        6019 (5857-6047)  49460 (46706-57997)    +722%
  1M write, 4 jobs       2791 (2649-2907)  26692 (25958-27560)    +856%

Signed-off-by: Qiliang Yuan <qiliang.yuan@linux.dev>
---
Qiliang Yuan (18):
      scsi: target: uring: Introduce an io_uring based user backstore
      scsi: target: uring: Allocate per-queue command descriptors
      scsi: target: uring: Create a character device per backstore device
      scsi: target: uring: Map the command descriptors into the server
      scsi: target: uring: Queue commands until a server fetches them
      scsi: target: uring: Hand commands out through TCMUR_IO_FETCH
      scsi: target: uring: Complete commands with TCMUR_IO_COMMIT_AND_FETCH
      scsi: target: uring: Copy command data with pread() and pwrite()
      scsi: target: uring: Fail in-flight commands when the server exits
      scsi: target: uring: Time out commands the server does not complete
      scsi: target: uring: Drop aborted commands that are still queued
      scsi: target: uring: Support SYNCHRONIZE CACHE
      scsi: target: uring: Implement UNMAP
      scsi: target: uring: Handle WRITE SAME
      scsi: target: uring: Register command data as io_uring fixed buffers
      selftests: target_core_uring: Add a minimal server
      selftests: target_core_uring: Test a device exported through tcm_loop
      Documentation: target: Describe the uring backstore

 Documentation/target/index.rst                     |    1 +
 Documentation/target/tcm-uring.rst                 |   84 ++
 MAINTAINERS                                        |    2 +
 drivers/target/Kconfig                             |   10 +
 drivers/target/Makefile                            |    1 +
 drivers/target/target_core_uring.c                 | 1126 ++++++++++++++++++++
 include/uapi/linux/target_core_uring.h             |  126 +++
 tools/testing/selftests/Makefile                   |    1 +
 .../testing/selftests/target_core_uring/.gitignore |    1 +
 tools/testing/selftests/target_core_uring/Makefile |    8 +
 tools/testing/selftests/target_core_uring/config   |    5 +
 .../selftests/target_core_uring/tcmur_server.c     |  310 ++++++
 .../selftests/target_core_uring/tcmur_test.sh      |  137 +++
 13 files changed, 1812 insertions(+)
---
base-commit: 23c62304dde29abe92013d85910d03a77dada35d
change-id: 20261115-feat-target-core-uring-d1351dfe5fe1

Best regards,
-- 
Qiliang Yuan <qiliang.yuan@linux.dev>


             reply	other threads:[~2026-11-16  0:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  0:17 Qiliang Yuan [this message]
2026-11-16  0:17 ` [PATCH RFC 01/18] scsi: target: uring: Introduce " Qiliang Yuan
2026-11-16  0:17 ` [PATCH RFC 02/18] scsi: target: uring: Allocate per-queue command descriptors Qiliang Yuan
2026-11-16  0:17 ` [PATCH RFC 03/18] scsi: target: uring: Create a character device per backstore device Qiliang Yuan
2026-11-16  0:17 ` [PATCH RFC 04/18] scsi: target: uring: Map the command descriptors into the server Qiliang Yuan
2026-11-16  0:17 ` [PATCH RFC 05/18] scsi: target: uring: Queue commands until a server fetches them Qiliang Yuan
2026-11-16  0:17 ` [PATCH RFC 06/18] scsi: target: uring: Hand commands out through TCMUR_IO_FETCH Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 07/18] scsi: target: uring: Complete commands with TCMUR_IO_COMMIT_AND_FETCH Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 08/18] scsi: target: uring: Copy command data with pread() and pwrite() Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 09/18] scsi: target: uring: Fail in-flight commands when the server exits Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 10/18] scsi: target: uring: Time out commands the server does not complete Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 11/18] scsi: target: uring: Drop aborted commands that are still queued Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 12/18] scsi: target: uring: Support SYNCHRONIZE CACHE Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 13/18] scsi: target: uring: Implement UNMAP Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 14/18] scsi: target: uring: Handle WRITE SAME Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 15/18] scsi: target: uring: Register command data as io_uring fixed buffers Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 16/18] selftests: target_core_uring: Add a minimal server Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 17/18] selftests: target_core_uring: Test a device exported through tcm_loop Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 18/18] Documentation: target: Describe the uring backstore Qiliang Yuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261115-feat-target-core-uring-v1-0-28cdc137eac6@linux.dev \
    --to=qiliang.yuan@linux.dev \
    --cc=axboe@kernel.dk \
    --cc=bostroesser@gmail.com \
    --cc=corbet@lwn.net \
    --cc=io-uring@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=michael.christie@oracle.com \
    --cc=mkp@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=target-devel@vger.kernel.org \
    --cc=tom.leiming@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®