mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexey Skidanov via B4 Relay <devnull+alexeys.xsightlabs.com@kernel.org>
To: Andrew Lunn <andrew+netdev@lunn.ch>,
	 "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	 Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,  Shuah Khan <shuah@kernel.org>,
	Wei Wang <weiwan@google.com>
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
	 linux-kernel@vger.kernel.org, guyt@xsightlabs.com,
	 Alexey Skidanov <alexeys@xsightlabs.com>,
	 Lior Yizchak <liory@xsightlabs.com>
Subject: [PATCH net] selftests: drv-net: psp: skip unsupported versions in netkit data test
Date: Sun, 15 Nov 2026 15:03:29 +0200	[thread overview]
Message-ID: <20261115-main-v1-1-7011cd84e54a@xsightlabs.com> (raw)

From: Alexey Skidanov <alexeys@xsightlabs.com>

data_basic_send_netkit_psp_assoc() runs for PSP versions 0-3. The
non-netkit data path already skips versions the device does not
advertise in psp-versions-cap. The netkit path does not, so those
cases fail instead of skipping.

Version 0 stays mandatory. Skip an unadvertised version before opening
the PSP connection.

Fixes: 43cf629700fa ("selftests/net: psp: add dev-assoc data path test")
Signed-off-by: Alexey Skidanov <alexeys@xsightlabs.com>
Signed-off-by: Lior Yizchak <liory@xsightlabs.com>
---
 tools/testing/selftests/drivers/net/psp.py | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tools/testing/selftests/drivers/net/psp.py b/tools/testing/selftests/drivers/net/psp.py
index c114d2245135..7c8fb2200b39 100755
--- a/tools/testing/selftests/drivers/net/psp.py
+++ b/tools/testing/selftests/drivers/net/psp.py
@@ -728,6 +728,12 @@ def _data_basic_send_netkit_psp_assoc(cfg, version, ipver):
     """
     _assoc_nk_guest(cfg)
 
+    # Version 0 is required by spec, don't let it skip
+    if version:
+        name = cfg.pspnl.consts["version"].entries_by_val[version].name
+        if name not in cfg.psp_info['psp-versions-cap']:
+            raise KsftSkipEx("PSP version not supported", name)
+
     # Enter guest namespace (netns) to run PSP test
     with NetNSEnter(cfg.netns.name):
         cfg.pspnl = PSPFamily()

---
base-commit: aa40afa831ebfe45e40a23721711059f2ac584d4
change-id: 20261115-main-0b37fbe5e1d2

Best regards,
-- 
Alexey Skidanov <alexeys@xsightlabs.com>



                 reply	other threads:[~2026-11-15 13:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261115-main-v1-1-7011cd84e54a@xsightlabs.com \
    --to=devnull+alexeys.xsightlabs.com@kernel.org \
    --cc=alexeys@xsightlabs.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=guyt@xsightlabs.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=liory@xsightlabs.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    --cc=weiwan@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®