From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.53 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794723086; b=Qrek7SJUBPhda8flc7BxuZz6JsZTuk68wL1MdZVMji2X10DrfK0ckdOMhIFSU3cJvicH MbhyaJozDul7VANf798yrL6AFXkS5pacd8KhRam6vVsc1L0xRbmyIIByhZyNk6t4/SjNK dAhP37PE7dl41BS1f8j3HabeqIfrYEjpXniuRwK2XvTqcYVbv1lM3NIQIv0lB7NNpkrez oTnJJrsAN9gw9kM20mfx89FU0pDg6gUsOuZU+i8uMOrmmCnyb8XIkDcxwR6wHZpuXw8FN 1jxNRuxNl1OCkIKzgBcJPmFLmM+M8UEGj7uR4Ow+PW6tbJ3WtgM2FLn5wsLMB0Yqjsg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794723086; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=TCHhOy28B+0gI7cRQUKEe32H0lL50i1G3WDk1ReHlIc=; b=sTk3V/Z0BMIrqRVTpiVy5FcCIT9qGfQcjwl1ifWZN+QECKeQSlSz7VapSkyPWO6pW/Vc PDBUsXpZpipDWE4T9pKAE4WNbCMl6/roYjvQLPfl/C+xRUMxzLNyPI2VRPUiPkzVYU8BP tQ/Rsh0/qa7V0jJLtRgGzchttv61gPK3hwsc+LQMboTW/UMqZzGEoLXm7lq7rOU2FgmES eZN6vchai7uHabzHQJ3iRuNaOGcQ+0m5G4JhuqW0qsDEWphAV2S1QD4PZ+gvQHwmIeJbg GdRImZTcUOvjSITNIKVfENeBg6sEeVpTgV0PKQFcvjaccoBG3pAmbNjaGSqhjmef8dg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=ppKaYaec; arc=none smtp.remote-ip=209.85.128.53 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E315606A8A7 for ; Sun, 15 Nov 2026 06:11:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 8E315606A8A7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=ppKaYaec Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4bb6754bf2dso3197545e9.0 for ; Sat, 14 Nov 2026 22:11:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794723085; x=1795327885; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TCHhOy28B+0gI7cRQUKEe32H0lL50i1G3WDk1ReHlIc=; b=ppKaYaecUnUwNfedyST7zZsf86RJaPMvRVSELxnTMyR/I1MLubReMWsGZV0dUyKBXp kCo6CvtAr/ZYIlvGUTLv/9O2tDE7dc8LUEOE6UxOZ7hDKwBEyOJYRKd/9VQPVmbDgUDg cfVtckQBo5p9nsk/mQfbbx+3SsAqQmfARoTS9U047vJFuC8w18uFgjqw0tvmtFL65SYw HdeNy4cVbP3ol1AUIMkAGA8B5m29xKuleqLfNBQKbA6WGICAAeVYMqL8Ta6JFPSxe5jK eScBMCV3knABDT7mHr9MUAwLz+S8iqAG00xzGpjVixp/v8OdYJntV68IWDKaBSMnAbFW GjXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794723085; x=1795327885; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=TCHhOy28B+0gI7cRQUKEe32H0lL50i1G3WDk1ReHlIc=; b=RwkFPpiDn9LdlV63vLr6kFLX7N4nYl66VzdOHyzwS9Qbpx2PVdSR4t6ZrECqToUtMD mSHlo0teQI/0RrG4SEdGnJLbLdHvm7xM6+LwBhpRhT5T7IR+AdwLMVmUlU1ePuravHiT sr1MY8dxiHKOIsUBS8UUJJ2GdF6Cw545ri2YNlOQlQgm+KeidXlVTyhrkgXjvlB5RSrL k6DQl03I6iSPJeir6ACT5u4datW5e9+E/+HubLyTB6+6yO4AYRgukxbVBKKaWknhof+9 C5ZgoDTi3YQCvDBSUHQXV/gkO/VrWHWSDi01eHHzmEIS7XvE8wZwIRLOxW/ZlPplqvsA s2hw== X-Forwarded-Encrypted: i=1; AL+hErEiDGuXt4DTEDSmP4Hch0BxrtRWL/hKDwlHCg0vONigi4J5MD+KQFdB8Qx3sfQB7TRwZJdU709KfhkidII=@vger.kernel.org X-Gm-Message-State: APuU4Z9NWrvSe35q3syGlPfx+REz+vfEF2VykZn/Yf9i7UzWE98E2dBV drcJMr+E/PdbVe3cvGebX5LQzIGnNcPBaM/1PMDaLSwQkVPoHGWyAVX7 X-Gm-Gg: AYBFou0BWDZd2X5ke00veoIQ4yl6yzmS1DI+6L7kz3n2Fe0rEIDGkk3FezQHfUR9IhE 4mJLwAGZDm+JnfX9bgxbIfW6mFUHQpVlNCT8fv2KbW9hyYXC7bmbviuapEINcb3uCi2CA7NCwHJ HH38ZmSHMk8FCPZ36zG+DZahjue7gJSTA6Ijrc0FCkuyk4AzatrE65cwx9jCFTvNDkMv9f5U/03 Q1ZnXntrDsU+ugFgz4XN2z4/WtKw8lA4NC0w0Vja08WK3Li4RY4lnKmy5GQ7oBsSopEb8LInKLT SlTdK36J2XpN+euE30NBXObrQaAdEBFcqFyucUMYYbRv1SUrIKloJcz47SOq2uvbZbo//pg/Cj0 PcKTgSqRiliSt7ZYfOHBfY4RccOKTDnYRcN9z0cDLPLZcpdoSguef5cQgSojhl6j731kO5OwIjN +xFfDk3pgnZKAvniApr0nC6ugkWS++Qr+BLfMDqwWHtGZopmzqJmP+g3XgNfethUkhWvtmxDZjI X340lYETNmqEmOZkK2J9flazXxXLKExFe28Z69M1OPagrwXe2p+FCnu+esd2L0415BE925hRQRq TRgwmFVUr9E401618g/VRqL2L4gEmVHbx6qZAeVe6PIk0/eACNkpRUzQ3FuOylYYxZH9njHgmas QOYPVVTCEcdNo2diXBWt4ewijEmpRPTaCKF0Fe+ulszaCLvvLsjykyjJnN+1NCZEWdUUcmvtNAK sTAVJzH4vVa8YEAe0nXlajQnzWMV3NoldJwHvOvnx9sHxm0EUsguYbewXZwKfXWM8xJ301kYEzd +zAldvkUel/SQ== X-Received: by 2002:a05:600c:3b98:b0:4b7:6a8b:9df2 with SMTP id 5b1f17b1804b1-4bb55a8c128mr151718065e9.25.1794723084885; Sat, 14 Nov 2026 22:11:24 -0800 (PST) Received: from jernej-laptop ([2a00:ee2:6a02:9300:bb69:6bcf:1b11:e85b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4bb5ba25b50sm139331075e9.14.2026.11.14.22.11.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Nov 2026 22:11:24 -0800 (PST) From: Jernej Skrabec To: Chen-Yu Tsai , Samuel Holland Cc: mripard@kernel.org, maarten.lankhorst@linux.intel.com, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, bmasney+clk@redhat.com, jbrunet+clk@baylibre.com, sboyd@kernel.org, Andre Przywara , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: [PATCH v3 3/8] drm/sun4i: Add support for DE33 CSC Date: Sun, 15 Nov 2026 07:10:57 +0100 Message-ID: <20261115061102.229680-4-jernej.skrabec@gmail.com> X-Mailer: git-send-email 2.56.1 In-Reply-To: <20261115061102.229680-1-jernej.skrabec@gmail.com> References: <20261115061102.229680-1-jernej.skrabec@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit DE33 has channel CSC units (for each plane separately) so pipeline can be configured to output in desired colorspace. Reviewed-by: Chen-Yu Tsai Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun8i_csc.c | 71 +++++++++++++++++++++++++++++++ drivers/gpu/drm/sun4i/sun8i_csc.h | 5 +++ 2 files changed, 76 insertions(+) diff --git a/drivers/gpu/drm/sun4i/sun8i_csc.c b/drivers/gpu/drm/sun4i/sun8i_csc.c index ce81c12f511d..70fc9b017d17 100644 --- a/drivers/gpu/drm/sun4i/sun8i_csc.c +++ b/drivers/gpu/drm/sun4i/sun8i_csc.c @@ -205,6 +205,72 @@ static void sun8i_de3_ccsc_setup(struct regmap *map, int layer, mask, val); } +/* extract constant from high word and invert sign if necessary */ +static u32 sun8i_de33_ccsc_get_constant(u32 value) +{ + value >>= 16; + + if (value & BIT(15)) + return 0x400 - (value & 0x3ff); + + return value; +} + +static void sun8i_de33_convert_table(const u32 *src, u32 *dst) +{ + dst[0] = sun8i_de33_ccsc_get_constant(src[3]); + dst[1] = sun8i_de33_ccsc_get_constant(src[7]); + dst[2] = sun8i_de33_ccsc_get_constant(src[11]); + memcpy(&dst[3], src, sizeof(u32) * 12); + dst[6] &= 0xffff; + dst[10] &= 0xffff; + dst[14] &= 0xffff; +} + +static void sun8i_de33_ccsc_setup(struct regmap *map, int layer, + enum sun8i_csc_mode mode, + enum drm_color_encoding encoding, + enum drm_color_range range) +{ + u32 addr, val, base, csc[15]; + const u32 *table; + int i; + + table = yuv2rgb_de3[range][encoding]; + base = DE33_CCSC_BASE + layer * DE33_CH_SIZE; + + switch (mode) { + case SUN8I_CSC_MODE_OFF: + val = 0; + break; + case SUN8I_CSC_MODE_YUV2RGB: + val = SUN8I_CSC_CTRL_EN; + sun8i_de33_convert_table(table, csc); + regmap_bulk_write(map, SUN50I_CSC_COEFF(base, 0), csc, 15); + break; + case SUN8I_CSC_MODE_YVU2RGB: + val = SUN8I_CSC_CTRL_EN; + sun8i_de33_convert_table(table, csc); + for (i = 0; i < 15; i++) { + addr = SUN50I_CSC_COEFF(base, i); + if (i > 3) { + if (((i - 3) & 3) == 1) + addr = SUN50I_CSC_COEFF(base, i + 1); + else if (((i - 3) & 3) == 2) + addr = SUN50I_CSC_COEFF(base, i - 1); + } + regmap_write(map, addr, csc[i]); + } + break; + default: + val = 0; + DRM_WARN("Wrong CSC mode specified.\n"); + return; + } + + regmap_write(map, SUN8I_CSC_CTRL(base), val); +} + static u32 sun8i_csc_get_mode(struct drm_plane_state *state) { const struct drm_format_info *format; @@ -238,6 +304,11 @@ void sun8i_csc_config(struct sun8i_layer *layer, mode, state->color_encoding, state->color_range); return; + } else if (layer->cfg->de_type == SUN8I_MIXER_DE33) { + sun8i_de33_ccsc_setup(layer->regs, layer->channel, + mode, state->color_encoding, + state->color_range); + return; } base = ccsc_base[layer->cfg->ccsc][layer->channel]; diff --git a/drivers/gpu/drm/sun4i/sun8i_csc.h b/drivers/gpu/drm/sun4i/sun8i_csc.h index 2a4b79599610..d2ba5f8611aa 100644 --- a/drivers/gpu/drm/sun4i/sun8i_csc.h +++ b/drivers/gpu/drm/sun4i/sun8i_csc.h @@ -18,9 +18,14 @@ struct sun8i_layer; #define CCSC10_OFFSET 0xA0000 #define CCSC11_OFFSET 0xF0000 +#define DE33_CCSC_BASE 0x800 + #define SUN8I_CSC_CTRL(base) ((base) + 0x0) #define SUN8I_CSC_COEFF(base, i) ((base) + 0x10 + 4 * (i)) +#define SUN50I_CSC_COEFF(base, i) ((base) + 0x04 + 4 * (i)) +#define SUN50I_CSC_ALPHA(base) ((base) + 0x40) + #define SUN8I_CSC_CTRL_EN BIT(0) void sun8i_csc_config(struct sun8i_layer *layer, -- 2.43.0