From: Ido Schimmel <idosch@nvidia.com>
To: Anton Danilov <littlesmilingcloud@gmail.com>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, David Ahern <dsahern@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v6 0/8] tunnels: add core and gre drop reasons
Date: Sun, 15 Nov 2026 11:12:18 +0200 [thread overview]
Message-ID: <20261115091218.GA3828669@shredder> (raw)
In-Reply-To: <20261110202021.821224-1-littlesmilingcloud@gmail.com>
On Tue, Nov 10, 2026 at 11:20:13PM +0300, Anton Danilov wrote:
> This series covers the receive paths shared by ipip, sit, gre and their
> IPv6 counterparts, plus the GRE and ip6tnl specific receive code, and
> the IPv4 transmit side of ip_tunnel and ip_gre; the code specific to
> ipip and sit keeps kfree_skb(). So does the tunnel4 and tunnel6 demux,
> shared with the xfrm tunnels, which frees the packets that no ipip, sit
> or ip6tnl device takes. The IPv6 transmit side, ip6_tnl_xmit() and the
> ip6_gre handlers, is left for a later series. GRE reports the reasons
> vxlan reports for the same conditions, which commit 7629d6db839f
> ("vxlan: rename the drop reasons for use by other tunnels") made
> generic.
Looks OK to me. AFAICT, only four new drop reasons are added and the
series mostly reuses existing ones.
Going forward, please write more succinct commit messages without
omitting the important parts.
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
prev parent reply other threads:[~2026-11-15 9:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 20:20 Anton Danilov
2026-11-10 20:20 ` [PATCH net-next v6 1/8] ip_tunnel: add drop reasons to the generic RX path Anton Danilov
2026-11-10 20:20 ` [PATCH net-next v6 2/8] ip6_tunnel: add drop reasons to the receive path Anton Danilov
2026-11-10 20:20 ` [PATCH net-next v6 3/8] gre: make gre_parse_header() report a drop reason Anton Danilov
2026-11-10 20:20 ` [PATCH net-next v6 4/8] ip_gre: add drop reasons to the RX path Anton Danilov
2026-11-10 20:20 ` [PATCH net-next v6 5/8] ip6_gre: " Anton Danilov
2026-11-10 20:20 ` [PATCH net-next v6 6/8] ip_tunnel: make ip_tunnel_encap() return a drop reason Anton Danilov
2026-11-10 20:20 ` [PATCH net-next v6 7/8] ip_tunnel: add drop reasons to the transmit path Anton Danilov
2026-11-10 20:20 ` [PATCH net-next v6 8/8] ip_gre: " Anton Danilov
2026-11-15 9:12 ` Ido Schimmel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261115091218.GA3828669@shredder \
--to=idosch@nvidia.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=littlesmilingcloud@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®