From: Andrew Morton <akpm@linux-foundation.org>
To: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
Cc: David Hildenbrand <david@kernel.org>,
Frank van der Linden <fvdl@google.com>,
Ivy Lopez <skunkolee@gmail.com>, Lorenzo Stoakes <ljs@kernel.org>,
"Liam R. Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Oscar Salvador <osalvador@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] mm/cma: simplify cma_declare_contiguous_multi()
Date: Sun, 15 Nov 2026 10:58:55 -0800 [thread overview]
Message-ID: <20261115105855.551620784977f951f37e729f@linux-foundation.org> (raw)
In-Reply-To: <20261115-cma-multi-v4-1-d159631171d5@kernel.org>
On Sun, 15 Nov 2026 08:27:03 +0200 "Mike Rapoport (Microsoft)" <rppt@kernel.org> wrote:
> When cma_declare_contiguous_multi() cannot allocate a CMA area as a
> single range, it falls back to collecting a list of up to CMA_MAX_RANGES
> largest free ranges above 4G, reserves them in memblock and adds them to
> cma->ranges.
>
> The list and subsequently cma->ranges are supposed to be sorted in the
> order of base addresses of the "allocated" ranges.
>
> This implementation has two bugs:
>
> * The allocation may fail even when there is enough free memory because
> list_insert_sorted() sorts the list in the wrong order.
>
> When the list is full, the largest range is evicted rather than the
> smallest, the final list is not sorted by address, and the smallest
> ranges are used first.
>
> * the function may report success while it reserved less memory than
> requested because sizesum accounts for ranges that were skipped.
>
> And overall it is a lot of list management and open coded range
> selection for no real gain.
>
> Replace the current code with a loop that finds the largest free range
> above 4G, reserves as much of it as needed and repeats until the entire
> area is reserved or CMA_MAX_RANGES ranges are used.
>
> After successful alocation sort the cma->ranges by their base address.
>
> The new code scans free memory once for every range rather than once
> for all ranges, so it is slightly slower, but it is way simpler and more
> robust.
Updated, thanks.
> - silence smatch warning about SZ_4G on 32 bits
> - fix a type in a comment
delta:
--- a/mm/cma.c~mm-cma-simplify-cma_declare_contiguous_multi-v4
+++ a/mm/cma.c
@@ -485,12 +485,12 @@ static phys_addr_t __init cma_find_free_
phys_addr_t max = 0;
u64 i;
- /* no point searching if the system can't addres above 4G */
+ /* no point searching if the system can't address above 4G */
if (!IS_ENABLED(CONFIG_PHYS_ADDR_T_64BIT))
return 0;
for_each_free_mem_range(i, nid, MEMBLOCK_NONE, &start, &end, NULL) {
- if (start < SZ_4G)
+ if (!upper_32_bits(start))
continue;
start = ALIGN(start, align);
_
prev parent reply other threads:[~2026-11-15 18:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 6:27 Mike Rapoport (Microsoft)
2026-11-15 18:58 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261115105855.551620784977f951f37e729f@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=fvdl@google.com \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=osalvador@kernel.org \
--cc=rppt@kernel.org \
--cc=skunkolee@gmail.com \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®