From: Chrispine Tinega <dev@chrispinetinega.com>
To: broonie@kernel.org
Cc: lee@kernel.org, lgirdwood@gmail.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, aaro.koskinen@iki.fi,
andreas@kemnade.info, khilman@baylibre.com, rogerq@kernel.org,
tony@atomide.com, jerome.neanne@baylibre.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-omap@vger.kernel.org, mfd@lists.linux.dev
Subject: Re: [PATCH 2/3] regulator: dt-bindings: ti,tps65219: Add ti,no-warm-shutdown
Date: Sun, 15 Nov 2026 14:12:17 +0300 [thread overview]
Message-ID: <20261115111217.371268-1-dev@chrispinetinega.com> (raw)
In-Reply-To: <cedb08d0-cfa0-452d-b4cd-511d6c852eed@sirena.org.uk>
On Sat, Nov 14, 2026 at 02:20:01PM +0000, Mark Brown wrote:
> Reviewed-by: Mark Brown <broonie@kernel.org>
>
> though we might still want a runtime override for when the user is more
> cautious.
Thank you for the review.
I agree. Looking at it again, a cautious user also has nothing to act on
today. With the warm warning masked, the warm interrupt reaches the
regulator driver with no regulator attached, so it only logs "Error IRQ
trap warm temperature". Nothing is notified.
I would rather keep this series to the board default and add the
override as a follow-up, once there is a user who needs it. I would
also change the binding text in v2, so it no longer says the operating
system decides how to react. Does that work for you, or would you like
the override in this series?
Chrispine
next prev parent reply other threads:[~2026-11-15 11:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 3:24 [PATCH 0/3] mfd: tps65219: Let a board run past the warm threshold Chrispine Tinega
2026-11-14 3:24 ` [PATCH 1/3] mfd: tps65219: Correct the MASK_EFFECT field of MASK_CONFIG Chrispine Tinega
2026-11-14 3:24 ` [PATCH 2/3] regulator: dt-bindings: ti,tps65219: Add ti,no-warm-shutdown Chrispine Tinega
2026-11-14 14:20 ` Mark Brown
2026-11-15 11:12 ` Chrispine Tinega [this message]
2026-11-14 3:24 ` [PATCH 3/3] mfd: tps65219: Keep running past the warm threshold when asked Chrispine Tinega
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261115111217.371268-1-dev@chrispinetinega.com \
--to=dev@chrispinetinega.com \
--cc=aaro.koskinen@iki.fi \
--cc=andreas@kemnade.info \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jerome.neanne@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®